pgsql: Have BufFileSize() ereport() on FileSize() failure.

2018-11-28 Thread Peter Geoghegan
Have BufFileSize() ereport() on FileSize() failure. Move the responsibility for checking for and reporting a failure from the only current BufFileSize() caller, logtape.c, to BufFileSize() itself. Code within buffile.c is generally responsible for interfacing with fd.c to report irrecoverable fai

pgsql: Have BufFileSize() ereport() on FileSize() failure.

2018-11-28 Thread Peter Geoghegan
Have BufFileSize() ereport() on FileSize() failure. Move the responsibility for checking for and reporting a failure from the only current BufFileSize() caller, logtape.c, to BufFileSize() itself. Code within buffile.c is generally responsible for interfacing with fd.c to report irrecoverable fai