Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Amit Kapila
On Wed, Apr 28, 2021 at 8:51 AM Tom Lane wrote: > > Amit Kapila writes: > > On Wed, Apr 28, 2021 at 5:31 AM Tom Lane wrote: > >> It's griping about this: > >> curtxn->concurrent_abort = true; > >> and I think it's got a point. There is little if any reason to have > >> confidence t

Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Tom Lane
Amit Kapila writes: > On Wed, Apr 28, 2021 at 5:31 AM Tom Lane wrote: >> It's griping about this: >> curtxn->concurrent_abort = true; >> and I think it's got a point. There is little if any reason to have >> confidence that curtxn must be non-NULL when this code is reached, >> becau

Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Amit Kapila
On Wed, Apr 28, 2021 at 5:31 AM Tom Lane wrote: > > Amit Kapila writes: > > Implement streaming mode in ReorderBuffer. > > I notice that new buildfarm member wrasse is unhappy about some of the > code added by this commit: > > "/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/back

Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Tom Lane
Amit Kapila writes: > Implement streaming mode in ReorderBuffer. I notice that new buildfarm member wrasse is unhappy about some of the code added by this commit: "/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/replication/logical/reorderbuffer.c", line 2510: Warning:

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-09-10 Thread Amit Kapila
On Thu, Sep 10, 2020 at 9:18 AM Amit Kapila wrote: > > On Thu, Sep 10, 2020 at 4:17 AM Tom Lane wrote: > > > > Amit Kapila writes: > > > Implement streaming mode in ReorderBuffer. > > > > Looks like this test is somewhat unstable still: > > > > > > Thanks for pointing out. I'll analyze and share

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-09-09 Thread Amit Kapila
On Thu, Sep 10, 2020 at 4:17 AM Tom Lane wrote: > > Amit Kapila writes: > > Implement streaming mode in ReorderBuffer. > > Looks like this test is somewhat unstable still: > > Thanks for pointing out. I'll analyze and share my findings. -- With Regards, Amit Kapila.

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-09-09 Thread Tom Lane
Amit Kapila writes: > Implement streaming mode in ReorderBuffer. Looks like this test is somewhat unstable still: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2020-09-09%2003%3A42%3A19 diff -U3 /home/andres/build/buildfarm/HEAD/pgsql.build/../pgsql/contrib/test_decoding/exp

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-08-07 Thread Amit Kapila
On Sat, Aug 8, 2020 at 11:03 AM Amit Kapila wrote: > > On Sat, Aug 8, 2020 at 7:59 AM Amit Kapila wrote: > > > > Implement streaming mode in ReorderBuffer. > > > > There is one failure [1] due to this commit. Looking into same. > The problem seems to be due to some parallel transactions (like a

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-08-07 Thread Amit Kapila
On Sat, Aug 8, 2020 at 7:59 AM Amit Kapila wrote: > > Implement streaming mode in ReorderBuffer. > There is one failure [1] due to this commit. Looking into same. [1] - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tern&dt=2020-08-08%2004%3A26%3A04 -- With Regards, Amit Kapila.

pgsql: Implement streaming mode in ReorderBuffer.

2020-08-07 Thread Amit Kapila
Implement streaming mode in ReorderBuffer. Instead of serializing the transaction to disk after reaching the logical_decoding_work_mem limit in memory, we consume the changes we have in memory and invoke stream API methods added by commit 45fdc9738b. However, sometimes if we have incomplete toast