Re: pgsql: Move gramparse.h to src/backend/parser

2022-09-14 Thread Andres Freund
Hi, On 2022-09-15 10:52:31 +0700, John Naylor wrote: > On Thu, Sep 15, 2022 at 4:04 AM Andres Freund wrote: > > > > The most general solution I can see would be > > > > diff --git i/src/backend/common.mk w/src/backend/common.mk > > index fa96a82b1a0..61861f5c7eb 100644 > > --- i/src/backend/commo

Re: pgsql: Move gramparse.h to src/backend/parser

2022-09-14 Thread John Naylor
On Thu, Sep 15, 2022 at 4:04 AM Andres Freund wrote: > > The most general solution I can see would be > > diff --git i/src/backend/common.mk w/src/backend/common.mk > index fa96a82b1a0..61861f5c7eb 100644 > --- i/src/backend/common.mk > +++ w/src/backend/common.mk > @@ -23,6 +23,7 @@ objfiles.txt:

Re: pgsql: Move gramparse.h to src/backend/parser

2022-09-14 Thread Andres Freund
Hi, On 2022-09-14 13:57:15 -0700, Andres Freund wrote: > On 2022-09-14 15:37:06 -0400, Tom Lane wrote: > > John Naylor writes: > > > Move gramparse.h to src/backend/parser > > > > The cfbot is unhappy since this commit; some but not all tests fail with > > > > [09:33:13.793] In file included from

Re: pgsql: Move gramparse.h to src/backend/parser

2022-09-14 Thread Andres Freund
Hi, On 2022-09-14 15:37:06 -0400, Tom Lane wrote: > John Naylor writes: > > Move gramparse.h to src/backend/parser > > The cfbot is unhappy since this commit; some but not all tests fail with > > [09:33:13.793] In file included from scan.c:39: > [09:33:13.793] ./gramparse.h:29:10: fatal error:

Re: pgsql: Move gramparse.h to src/backend/parser

2022-09-14 Thread Tom Lane
John Naylor writes: > Move gramparse.h to src/backend/parser The cfbot is unhappy since this commit; some but not all tests fail with [09:33:13.793] In file included from scan.c:39: [09:33:13.793] ./gramparse.h:29:10: fatal error: 'gram.h' file not found [09:33:13.794] #include "gram.h" [09:33:1

Re: pgsql: Move gramparse.h to src/backend/parser

2022-09-13 Thread John Naylor
On Wed, Sep 14, 2022 at 11:02 AM John Naylor wrote: > > Move gramparse.h to src/backend/parser Member crake doesn't like this. I thought I tried vpath for this patch, but I'll go confirm now. -- John Naylor EDB: http://www.enterprisedb.com

pgsql: Move gramparse.h to src/backend/parser

2022-09-13 Thread John Naylor
Move gramparse.h to src/backend/parser This header is semi-private, being used only in files related to raw parsing, so move to the backend directory where those files live. This allows removal of Makefile rules that symlink gram.h to src/include/parser, since gramparse.h can now include gram.h fr