Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Aleksander Alekseev
Hi, > OK, now I get your point: you think this should go to the next major > release. But no, it's not. It's intended to eventually land into > REL_18_STABLE, REL_18_BETA2 etc. It addresses one of PG18 Open Items: > Richard Guo found the way SJE changes ChangeVarNodes() unsatisfiable, > and thi

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Alexander Korotkov
On Wed, May 7, 2025 at 12:47 PM Aleksander Alekseev wrote: > > How can this or other commits on master branch prevent creating new > > tag REL_18_BETA2 or forking REL_18_STABLE from master? Perhaps, this > > commit is not the only one on master branch after tag REL_18_BETA1. > > Right, but I see

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Aleksander Alekseev
Hi, > How can this or other commits on master branch prevent creating new > tag REL_18_BETA2 or forking REL_18_STABLE from master? Perhaps, this > commit is not the only one on master branch after tag REL_18_BETA1. Right, but I see people fixing whitespaces and documentation for PG18 in the `mas

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Alexander Korotkov
Hi, Aleksander! On Wed, May 7, 2025 at 11:59 AM Aleksander Alekseev wrote: > > > I believe this was pushed by mistake. > > > > Why it should be mistake this time? > > At least, this time I managed to wait till the end of release freeze. > > Perhaps I misunderstand something in the process. How on

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Aleksander Alekseev
Hi, > > I believe this was pushed by mistake. > > Why it should be mistake this time? > At least, this time I managed to wait till the end of release freeze. Perhaps I misunderstand something in the process. How one will tag REL_18_BETA2 or fork REL_18_STABLE considering that the `master` branch

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Alexander Korotkov
On Wed, May 7, 2025 at 11:47 AM Aleksander Alekseev wrote: > > Refactor ChangeVarNodesExtended() using the custom callback > > > > fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic > > to ChangeVarNodes_walker(). This commit provides refactoring to remove the > > SJE-rela

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Aleksander Alekseev
Alexander, > Refactor ChangeVarNodesExtended() using the custom callback > > fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic > to ChangeVarNodes_walker(). This commit provides refactoring to remove the > SJE-related logic from ChangeVarNodes_walker() but adds a custom c

pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-07 Thread Alexander Korotkov
Refactor ChangeVarNodesExtended() using the custom callback fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic to ChangeVarNodes_walker(). This commit provides refactoring to remove the SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to ChangeVarN

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-03 Thread Alexander Korotkov
On Sat, May 3, 2025 at 11:06 PM Tom Lane wrote: > > Alexander Korotkov writes: > > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > >> You are aware that we are in release freeze, no? > > > I missed that. Should I revert this commit now? > > Yes, I think so. If you feel it's critical enough t

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-03 Thread Tom Lane
Alexander Korotkov writes: > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: >> You are aware that we are in release freeze, no? > I missed that. Should I revert this commit now? Yes, I think so. If you feel it's critical enough to go in on a release weekend, you should ask pgsql-release@ for

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-03 Thread Alexander Korotkov
On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > > Alexander Korotkov writes: > > Refactor ChangeVarNodesExtended() using the custom callback > > You are aware that we are in release freeze, no? I missed that. Should I revert this commit now? -- Regards, Alexander Korotkov Supabase

Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-03 Thread Tom Lane
Alexander Korotkov writes: > Refactor ChangeVarNodesExtended() using the custom callback You are aware that we are in release freeze, no? regards, tom lane

pgsql: Refactor ChangeVarNodesExtended() using the custom callback

2025-05-03 Thread Alexander Korotkov
Refactor ChangeVarNodesExtended() using the custom callback fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic to ChangeVarNodes_walker(). This commit provides refactoring to remove the SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to ChangeVarN