Re: pgsql: Remove IS_AF_UNIX macro

2022-02-16 Thread Tom Lane
Peter Eisentraut writes: > On 15.02.22 16:41, Tom Lane wrote: >> I hadn't looked closely at this patch, but are you referring to >> this bit in ip.h? > In src/backend/utils/adt/pgstatfuncs.c there is a use of AF_UNIX that > has been there unprotected by any #ifdef since about 2008. Oh, I see it

Re: pgsql: Remove IS_AF_UNIX macro

2022-02-16 Thread Peter Eisentraut
On 15.02.22 16:41, Tom Lane wrote: Peter Eisentraut writes: Remove IS_AF_UNIX macro The AF_UNIX macro was being used unprotected by HAVE_UNIX_SOCKETS, apparently since 2008. I hadn't looked closely at this patch, but are you referring to this bit in ip.h? #ifdef HAVE_UNIX_SOCKETS #define

Re: pgsql: Remove IS_AF_UNIX macro

2022-02-15 Thread Andres Freund
Hi, On 2022-02-15 10:41:44 -0500, Tom Lane wrote: > We might as well just nuke all the HAVE_UNIX_SOCKETS conditional compilation > if we let this stand. > > (Now, maybe we should indeed do that. I don't have much > interest in the possibility that we'll worry about such > platforms in future.)

Re: pgsql: Remove IS_AF_UNIX macro

2022-02-15 Thread Tom Lane
Peter Eisentraut writes: > Remove IS_AF_UNIX macro > The AF_UNIX macro was being used unprotected by HAVE_UNIX_SOCKETS, > apparently since 2008. I hadn't looked closely at this patch, but are you referring to this bit in ip.h? #ifdef HAVE_UNIX_SOCKETS #define IS_AF_UNIX(fam) ((fam) == AF_UNIX)

pgsql: Remove IS_AF_UNIX macro

2022-02-15 Thread Peter Eisentraut
Remove IS_AF_UNIX macro The AF_UNIX macro was being used unprotected by HAVE_UNIX_SOCKETS, apparently since 2008. So the redirection through IS_AF_UNIX() is apparently no longer necessary. (More generally, all supported platforms are now HAVE_UNIX_SOCKETS, but even if there were a new platform i