Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-10 Thread Michael Paquier
On Tue, May 10, 2022 at 09:57:29AM +0900, Michael Paquier wrote: > This needs to be adjusted on all the stable branches, so I'll do that > once this week's version is tagged. Attached is an updated patch for > now. The tags have been pushed, so done now. -- Michael signature.asc Description: PG

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-09 Thread Michael Paquier
On Mon, May 09, 2022 at 10:10:27AM -0400, Andrew Dunstan wrote: > The system() call should include redirection, since we only case about > the return code. Okay, done using File::Spec::devnull. > I would just write this > > as > >     $ENV{$envname} = $envdefault if $rc == 0; > > There should

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-09 Thread Andrew Dunstan
On 2022-05-09 Mo 01:28, Michael Paquier wrote: > Hi Andrew, > > On Sat, May 07, 2022 at 09:13:48AM +0900, Michael Paquier wrote: >> Let's do that for now then as we need a middle ground for HEAD. I'll >> come up with something at the beginning of next week. > And here you go as of the attached t

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-08 Thread Michael Paquier
Hi Andrew, On Sat, May 07, 2022 at 09:13:48AM +0900, Michael Paquier wrote: > Let's do that for now then as we need a middle ground for HEAD. I'll > come up with something at the beginning of next week. And here you go as of the attached to show the idea. The CI is able to execute and detect th

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-06 Thread Michael Paquier
On Fri, May 06, 2022 at 10:12:36AM -0400, Andrew Dunstan wrote: > On 2022-05-02 Mo 03:06, Michael Paquier wrote: > vcpkg doesn't install any.exe files AFAICS, just DLLs, headers, .lib > files etc. Okay, thanks for confirming. >>> I don't think we should do that check for every time we call >>> vc

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-06 Thread Andrew Dunstan
On 2022-05-02 Mo 03:06, Michael Paquier wrote: > On Sun, May 01, 2022 at 10:18:37AM -0400, Andrew Dunstan wrote: >> IIRC we know that tar will be available on Windows. > What about gzip? Are the binaries and the libraries split into > different packages for this package manager on Windows? We'v

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-02 Thread Michael Paquier
On Sun, May 01, 2022 at 10:18:37AM -0400, Andrew Dunstan wrote: > IIRC we know that tar will be available on Windows. What about gzip? Are the binaries and the libraries split into different packages for this package manager on Windows? We've never assumed that this is possible on ./configure, b

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-01 Thread Andrew Dunstan
On 2022-05-01 Su 09:15, Michael Paquier wrote: > On Sat, Apr 30, 2022 at 04:52:54PM -0400, Andrew Dunstan wrote: >> This appears to have been misconceived, at least in the case of MSVC >> builds, as I have just discovered. It is entirely possible to have the >> lz4 libraries installed and build w

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-01 Thread Michael Paquier
On Sat, Apr 30, 2022 at 04:52:54PM -0400, Andrew Dunstan wrote: > This appears to have been misconceived, at least in the case of MSVC > builds, as I have just discovered. It is entirely possible to have the > lz4 libraries installed and build with them but not have the .exe, and > unlike the confi

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-04-30 Thread Andrew Dunstan
On 2022-02-14 Mo 23:41, Michael Paquier wrote: > Remove command checks in tests of pg_basebackup and pg_receivewal > > The TAP tests of those commands have been checking if commands of "gzip" > and "lz4" existed by launching them with an extra --version. Based on > the buildfarm, this is not req

pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-02-14 Thread Michael Paquier
Remove command checks in tests of pg_basebackup and pg_receivewal The TAP tests of those commands have been checking if commands of "gzip" and "lz4" existed by launching them with an extra --version. Based on the buildfarm, this is not required for "gzip" as the command always exists. Since 1d08