pgsql: Remove obsolete comment.

2025-02-13 Thread Thomas Munro
Remove obsolete comment. Commit 755a4c10d19d prevented StartReadBuffers() from crossing md.c segment boundaries in one operation, but a comment about that possibility remained. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9e17ac997f921c9de99125a97a0f34ae50f5c498

pgsql: Remove obsolete comment in reorderbuffer.h.

2024-10-14 Thread Masahiko Sawada
Remove obsolete comment in reorderbuffer.h. Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for allocating ReorderBufferTXN entries instead of using a caching mechanism. The txn->node is no longer used as an element of the list of preallocated ReorderBufferTXNs. Reviewed-by: Amit Kap

pgsql: Remove obsolete comment in pg_stat_statements.

2024-09-14 Thread Tom Lane
Remove obsolete comment in pg_stat_statements. Commit 76db9cb63 removed the use of multiple nesting counters, but missed one comment describing that arrangement. Back-patch to v17 where 76db9cb63 came in, just to avoid confusion. Julien Rouhaud Discussion: https://postgr.es/m/gfcwh3zjxc2vyglta

pgsql: Remove obsolete comment in pg_stat_statements.

2024-09-14 Thread Tom Lane
Remove obsolete comment in pg_stat_statements. Commit 76db9cb63 removed the use of multiple nesting counters, but missed one comment describing that arrangement. Back-patch to v17 where 76db9cb63 came in, just to avoid confusion. Julien Rouhaud Discussion: https://postgr.es/m/gfcwh3zjxc2vyglta

pgsql: Remove obsolete comment.

2024-05-07 Thread Jeff Davis
Remove obsolete comment. Per suggestion from Peter, the comment was not helpful, so remove it rather than fixing it. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/d9421b21-e759-4b74-a039-c487b469c...@eisentraut.org Branch -- master Details --- https://git.postgresql.org

pgsql: Remove obsolete comment in CopyReadLineText().

2024-04-06 Thread Tom Lane
Remove obsolete comment in CopyReadLineText(). When this bit of commentary was written, it was alluding to the fact that we looked for newlines and EOD markers in the raw (not yet encoding-converted) input data. We don't do that anymore, preferring to batch the conversion of larger chunks of inpu

pgsql: Remove obsolete comment about VACUUM retrying pruning

2024-03-28 Thread Heikki Linnakangas
Remove obsolete comment about VACUUM retrying pruning Commit 1ccc1e05ae removed the retry logic that the comment talked about. Reviewed-by: Melanie Plageman Discussion: https://www.postgresql.org/message-id/20240328015326.x5gnzsohl6j23b42@liskov Branch -- master Details --- https://gi

pgsql: Remove obsolete comment

2024-03-21 Thread Peter Eisentraut
Remove obsolete comment The idea to use a union in the definition of RangeTblEntry is clearly not being pursued. Reviewed-by: Andrew Dunstan Discussion: https://www.postgresql.org/message-id/flat/4b27fc50-8cd6-46f5-ab20-88dbaadca...@eisentraut.org Branch -- master Details --- https://

pgsql: Remove obsolete comment about OID support

2023-07-12 Thread Peter Eisentraut
Remove obsolete comment about OID support Reviewed-by: Alvaro Herrera Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e...@eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/adf333b4edb24fc9134fd76cd6c2d65f9a89c3a

pgsql: Remove obsolete comment and code from fe-auth.c.

2023-07-08 Thread Thomas Munro
Remove obsolete comment and code from fe-auth.c. We don't use getpwuid() anymore (see commit e757cdd6), so we don't need locking around pg_get_user_name(). Reviewed-by: Andres Freund Reviewed-by: Peter Eisentraut Reviewed-by: Heikki Linnakangas Discussion: https://postgr.es/m/CA%2BhUKGLtmexrp

pgsql: Remove obsolete comment

2023-06-05 Thread Peter Eisentraut
Remove obsolete comment OIDs are no longer system columns, since 578b229718. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/08235203ddefde1d0bfb6a1e8bb6ff546a2c7e8c Modified Files -- src/include/executor/tuptable.h | 1 - 1 file changed, 1 deletion(-)

pgsql: Remove obsolete comment

2022-08-26 Thread Peter Eisentraut
Remove obsolete comment The comment in basebackup.c updated by 33bd4698c11 was actually obsolete to begin with, since the symbols it was referring to haven't existed in that header file for quite some time. The header file is still needed for other reasons, though, so keep the #include, just drop

pgsql: Remove obsolete comment

2022-08-26 Thread Peter Eisentraut
Remove obsolete comment The comment in basebackup.c updated by 33bd4698c11 was actually obsolete to begin with, since the symbols it was referring to haven't existed in that header file for quite some time. The header file is still needed for other reasons, though, so keep the #include, just drop

pgsql: Remove obsolete comment

2022-04-01 Thread Peter Eisentraut
Remove obsolete comment accidentally left behind by 4cb658af70027c3544fb843d77b2e84028762747 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/db086de5abe5d87b07cddd030092b1f81f99c5ea Modified Files -- src/include/utils/rel.h | 1 - 1 file changed, 1 delet

pgsql: Remove obsolete comment

2022-04-01 Thread Peter Eisentraut
Remove obsolete comment accidentally left behind by 4cb658af70027c3544fb843d77b2e84028762747 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8f4b5b09096ae5e470c6410312c24581da319733 Modified Files -- src/include/utils/rel.h | 1 - 1 file changed,

pgsql: Remove obsolete comment

2022-04-01 Thread Peter Eisentraut
Remove obsolete comment accidentally left behind by 4cb658af70027c3544fb843d77b2e84028762747 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d480ae069e6c13dcb719b8c6aaf7a5540196a1b3 Modified Files -- src/include/utils/rel.h | 1 - 1 file changed,

pgsql: Remove obsolete comment in snapbuild.c.

2021-10-04 Thread Amit Kapila
Remove obsolete comment in snapbuild.c. Commits 955a684e04 and a975ff4980 removed the usage of running xacts information from serialized snapshots but forgot to remove the corresponding comment. Author: Masahiko Sawada Discussion: https://postgr.es/m/CAD21AoBifOr7RS=jre7ycavc646y9omchv6zkwxvjezc

pgsql: Remove obsolete comment for WaitForProcSignalBarrier().

2021-03-01 Thread Thomas Munro
Remove obsolete comment for WaitForProcSignalBarrier(). Commit 814f1d8b removed the behavior described. Reported-by: Amit Kapila Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bd69ddfcdbf650f11af4317f3f6686c012cf66d0 Modified Files -- src/backend/sto

pgsql: Remove obsolete comment atop ri_PlanCheck.

2020-11-24 Thread Amit Kapila
Remove obsolete comment atop ri_PlanCheck. Commit 5b7ba75f7f removed the unused parameter but forgot to update the nearby comments. Author: Li Japin Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/0e2f62a2-b2f1-4052-83ae-f0bec8a75...@hotmail.com Branch -- maste

pgsql: Remove obsolete comment atop ri_PlanCheck.

2020-11-24 Thread Amit Kapila
Remove obsolete comment atop ri_PlanCheck. Commit 5b7ba75f7f removed the unused parameter but forgot to update the nearby comments. Author: Li Japin Backpatch-through: 13, where it was introduced Discussion: https://postgr.es/m/0e2f62a2-b2f1-4052-83ae-f0bec8a75...@hotmail.com Branch -- REL_1

pgsql: Remove obsolete comment.

2020-02-29 Thread Tom Lane
Remove obsolete comment. Noted while studying subplan hash issue. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6afc8aefd3b95c0c4e7d07d2c99b90ce83e313de Modified Files -- src/backend/executor/execGrouping.c | 9 +++-- 1 file changed, 3 insertions(+

pgsql: Remove obsolete comment

2019-01-18 Thread Peter Eisentraut
Remove obsolete comment Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f04ad77a300ad77cfe1b84e42eff90fd29cb4c4d Modified Files -- src/test/regress/expected/foreign_key.out | 1 - src/test/regress/sql/foreign_key.sql | 1 - 2 files changed, 2 deletion

pgsql: Remove obsolete comment

2018-09-25 Thread Alvaro Herrera
Remove obsolete comment The documented shortcoming was actually fixed in 4c728f3829 so the comment is not true anymore. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5913b9bbf351b421141b300e37752e9ab8d85163 Modified Files -- src/backend/executor/execP

pgsql: Remove obsolete comment

2018-09-25 Thread Alvaro Herrera
Remove obsolete comment The documented shortcoming was actually fixed in 4c728f3829 so the comment is not true anymore. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/21c8f9c28981f0dc81fbf0d26b85ec119511f35c Modified Files -- src/backend/executo

pgsql: Remove obsolete comment

2018-09-25 Thread Alvaro Herrera
Remove obsolete comment The documented shortcoming was actually fixed in 4c728f3829 so the comment is not true anymore. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2886a8f7045411c8a1607cf3b01f3856cb475f9e Modified Files -- src/backend/executo

pgsql: Remove obsolete comment

2018-08-13 Thread Peter Eisentraut
Remove obsolete comment The sequence name is no longer stored in the sequence relation, since 1753b1b027035029c2a2a1649065762fafbf63f3. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4c9611e576e8b70abe14a616d776670339f956c5 Modified Files -- src

pgsql: Remove obsolete comment

2018-08-13 Thread Peter Eisentraut
Remove obsolete comment The sequence name is no longer stored in the sequence relation, since 1753b1b027035029c2a2a1649065762fafbf63f3. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6c206de559d40641dc0357fdae2003bfc7b015ad Modified Files -- src

pgsql: Remove obsolete comment

2018-08-13 Thread Peter Eisentraut
Remove obsolete comment The sequence name is no longer stored in the sequence relation, since 1753b1b027035029c2a2a1649065762fafbf63f3. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3ebdd21b794b49fde2010ff3d39071e02d27b404 Modified Files -- src/backen

pgsql: Remove obsolete comment block in nbtsort.c.

2018-06-26 Thread Peter Geoghegan
Remove obsolete comment block in nbtsort.c. Building a new nbtree index through incremental insertions would always be slower than our actual approach of sorting using tuplesort, assembling leaf pages from tuplesort output, and writing and WAL-logging whole pages. Remove a comment block from the

pgsql: Remove obsolete comment.

2017-12-12 Thread Robert Haas
Remove obsolete comment. Commit 8b304b8b72b0a60f1968d39f01cf817c8df863ec removed replacement selection, but left behind this comment text. The optimization to which the comment refers is not relevant without replacement selection, because if we had so few tuples as to require only one tape, we wo