Re: pgsql: Remove over-optimistic Assert.

2023-02-02 Thread Tom Lane
Richard Guo writes: > On Thu, Feb 2, 2023 at 8:40 AM Tom Lane wrote: >> In commit 2489d76c4, I'd thought it'd be safe to assert that a >> PlaceHolderVar appearing in a scan-level expression has empty >> nullingrels. However this is not so, as when we determine that a >> join relation is certainl

Re: pgsql: Remove over-optimistic Assert.

2023-02-02 Thread Richard Guo
On Thu, Feb 2, 2023 at 8:40 AM Tom Lane wrote: > Remove over-optimistic Assert. > > In commit 2489d76c4, I'd thought it'd be safe to assert that a > PlaceHolderVar appearing in a scan-level expression has empty > nullingrels. However this is not so, as when we determine that a > join relation is

pgsql: Remove over-optimistic Assert.

2023-01-31 Thread Tom Lane
Remove over-optimistic Assert. In commit 2489d76c4, I'd thought it'd be safe to assert that a PlaceHolderVar appearing in a scan-level expression has empty nullingrels. However this is not so, as when we determine that a join relation is certainly empty we'll put its targetlist into a Result-with