Re: pgsql: Remove pg_class.relhaspkey

2018-03-15 Thread Tom Lane
Alvaro Herrera writes: > Well, maybe we should dictate policy that it must be possible to > pg_upgrade this database too; then we'll just have to work so that it > always works. I have fixed the current problem and I'm open to the idea > of keeping it working. Name of the matview now seems a bit

Re: pgsql: Remove pg_class.relhaspkey

2018-03-15 Thread Alvaro Herrera
Andrew Dunstan wrote: > As I mentioned upthread, it's not supposed to be, but was being due to > a typo that I have fixed. You should see this error cleared on the > dashboard in a few minutes. > > However, in general the module tries to do a maximal test. That > includes almost all the contrib d

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Andrew Dunstan
On Thu, Mar 15, 2018 at 9:41 AM, Alvaro Herrera wrote: > Tom Lane wrote: >> Andrew Dunstan writes: >> > Basing an MV on pg_class could always be difficult for pg_upgrade. Maybe >> > that's not a brilliant thing to do in a test (or maybe the test should drop >> > the MV after it's done). >> >> OH.

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Alvaro Herrera
Tom Lane wrote: > Andrew Dunstan writes: > > Basing an MV on pg_class could always be difficult for pg_upgrade. Maybe > > that's not a brilliant thing to do in a test (or maybe the test should drop > > the MV after it's done). > > OH. Is that what it's doing? The cause of the failure is immedia

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Tom Lane
Andrew Dunstan writes: > Basing an MV on pg_class could always be difficult for pg_upgrade. Maybe > that's not a brilliant thing to do in a test (or maybe the test should drop > the MV after it's done). OH. Is that what it's doing? The cause of the failure is immediately obvious then. pg_class

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Tom Lane
Stephen Frost writes: > I've not quite tracked it down, but I would caution against blaming this > commit- when doing some parallel regression test runs, I was seeing > failures also, but they've not been consistent and I was trying to get > something else done so didn't focus on them, so they may

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Andrew Dunstan
On Thu, Mar 15, 2018 at 7:43 AM, Andres Freund wrote: > Hi, > > On 2018-03-14 19:35:40 +, Peter Eisentraut wrote: > > Remove pg_class.relhaspkey > > > > It is not used for anything internally, and it cannot be relied on for > > external uses, so it can just be removed. To correct recommended

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Andres Freund
On 2018-03-14 18:09:07 -0400, Stephen Frost wrote: > Greetings, > > * Andres Freund (and...@anarazel.de) wrote: > > On 2018-03-14 19:35:40 +, Peter Eisentraut wrote: > > > Remove pg_class.relhaspkey > > > > > > It is not used for anything internally, and it cannot be relied on for > > > exter

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2018-03-14 19:35:40 +, Peter Eisentraut wrote: > > Remove pg_class.relhaspkey > > > > It is not used for anything internally, and it cannot be relied on for > > external uses, so it can just be removed. To correct recommended way to

Re: pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Andres Freund
Hi, On 2018-03-14 19:35:40 +, Peter Eisentraut wrote: > Remove pg_class.relhaspkey > > It is not used for anything internally, and it cannot be relied on for > external uses, so it can just be removed. To correct recommended way to > check for a primary key is in pg_index. > > Discussion:

pgsql: Remove pg_class.relhaspkey

2018-03-14 Thread Peter Eisentraut
Remove pg_class.relhaspkey It is not used for anything internally, and it cannot be relied on for external uses, so it can just be removed. To correct recommended way to check for a primary key is in pg_index. Discussion: https://www.postgresql.org/message-id/flat/b1a24c6c-6913-f89c-674e-0704f0