Re: pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Jeff Davis
On Thu, 2020-06-11 at 13:41 -0700, Peter Geoghegan wrote: > On Thu, Jun 11, 2020 at 1:05 PM Jeff Davis > wrote: > > Rework HashAgg GUCs. > > This commit broke the doc build: Fixed, thank you. It broke the REL_13_STABLE branch, not master, so I fixed it only in 13. Regards, Jeff Davis

Re: pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Peter Geoghegan
On Thu, Jun 11, 2020 at 1:05 PM Jeff Davis wrote: > Rework HashAgg GUCs. This commit broke the doc build: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2020-06-11%2020%3A17%3A29 Thanks -- Peter Geoghegan

pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Jeff Davis
Rework HashAgg GUCs. Eliminate enable_groupingsets_hash_disk, which was primarily useful for testing grouping sets that use HashAgg and spill. Instead, hack the table stats to convince the planner to choose hashed aggregation for grouping sets that will spill to disk. Suggested by Melanie Plageman

pgsql: Rework HashAgg GUCs.

2020-06-11 Thread Jeff Davis
Rework HashAgg GUCs. Eliminate enable_groupingsets_hash_disk, which was primarily useful for testing grouping sets that use HashAgg and spill. Instead, hack the table stats to convince the planner to choose hashed aggregation for grouping sets that will spill to disk. Suggested by Melanie Plageman