Re: pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Tom Lane
Jeff Davis writes: > On Thu, 2020-02-27 at 14:56 -0500, Tom Lane wrote: >> Surely this patch is a few bricks shy of a load. Don't you need >> copyfuncs/readfuncs/outfuncs support, for starters? > Sorry, I will fix it. > I was looking at whether changes to copyfuncs (etc.) should also cause > a

Re: pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Jeff Davis
On Thu, 2020-02-27 at 14:56 -0500, Tom Lane wrote: > Jeff Davis writes: > > Save calculated transitionSpace in Agg node. > > Surely this patch is a few bricks shy of a load. Don't you need > copyfuncs/readfuncs/outfuncs support, for starters? Sorry, I will fix it. I was looking at whether chan

Re: pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Tom Lane
Jeff Davis writes: > Save calculated transitionSpace in Agg node. Surely this patch is a few bricks shy of a load. Don't you need copyfuncs/readfuncs/outfuncs support, for starters? regards, tom lane

pgsql: Save calculated transitionSpace in Agg node.

2020-02-27 Thread Jeff Davis
Save calculated transitionSpace in Agg node. This will be useful in the upcoming Hash Aggregation work to improve estimates for hash table sizing. Discussion: https://postgr.es/m/37091115219dd522fd9ed67333ee8ed1b7e09443.camel%40j-davis.com Branch -- master Details --- https://git.postg