Re: pgsql: Skip temp tables from basebackup.

2018-03-27 Thread Teodor Sigaev
Thanks for everyone, pushed. Let us follow the pgbuildfarm David Steele wrote: On 3/27/18 10:24 AM, Teodor Sigaev wrote: Hm, seems, Windows doesn't like this patch https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-27 sorry for wrong URL https://buildfarm.postgresql

Re: pgsql: Skip temp tables from basebackup.

2018-03-27 Thread David Steele
On 3/27/18 10:24 AM, Teodor Sigaev wrote: >> Hm, seems, Windows doesn't like this patch >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-27 >> > > sorry for wrong URL > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-27%2013%3A30%3A24 Lo

Re: pgsql: Skip temp tables from basebackup.

2018-03-27 Thread Andrew Gierth
> "Teodor" == Teodor Sigaev writes: Teodor> Hm, seems, Windows doesn't like this patch You added two tests to the SKIP: block without updating the number of tests that would be skipped, so the final count of tests comes out wrong. skip "symlinks not supported on Windows", 15 if ($windo

Re: pgsql: Skip temp tables from basebackup.

2018-03-27 Thread Tom Lane
David Steele writes: > Will do. Probably a path problem, which hopefully I can fix with the new > function Andrew wrote. Looks to me more like a failure-to-count-the-number-of-tests problem. There's no test reported as "not ok". regards, tom lane

Re: pgsql: Skip temp tables from basebackup.

2018-03-27 Thread David Steele
On 3/27/18 10:17 AM, Teodor Sigaev wrote: > Hm, seems, Windows doesn't like this patch > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-27 Will do. Probably a path problem, which hopefully I can fix with the new function Andrew wrote. -- -David da...@pgmasters.net

Re: pgsql: Skip temp tables from basebackup.

2018-03-27 Thread Teodor Sigaev
Hm, seems, Windows doesn't like this patch https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-27 sorry for wrong URL https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-27%2013%3A30%3A24 -- Teodor Sigaev E-mai

Re: pgsql: Skip temp tables from basebackup.

2018-03-27 Thread Teodor Sigaev
Hm, seems, Windows doesn't like this patch https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-03-27 David, could you have a look? Teodor Sigaev wrote: Skip temp tables from basebackup. Do not store temp tables in basebackup, they will not be visible anyway, so, there are

pgsql: Skip temp tables from basebackup.

2018-03-27 Thread Teodor Sigaev
Skip temp tables from basebackup. Do not store temp tables in basebackup, they will not be visible anyway, so, there are not reasons to store them. Author: David Steel Reviewed by: me Discussion: https://www.postgresql.org/message-id/flat/5ea4d26a-a453-c1b7-eff9-5a3ef8f8a...@pgmasters.net Branc