Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions

2023-08-18 Thread Tom Lane
John Naylor writes: > On Fri, Aug 18, 2023 at 5:26 PM Thomas Munro wrote: >> I don't know what's going on on that machine but those two failures >> seem different, and there are also now some failures in release >> branches that don't have your commit, so I'd wait long for more >> evidence... >

Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions

2023-08-18 Thread John Naylor
On Fri, Aug 18, 2023 at 5:26 PM Thomas Munro wrote: > > > > Hammerkop is getting OOM errors with this change. Most grand totals in the memory context stats show between 1 and 3 MB, and "tuplesort main" only shows small-ish requests, so not sure what's going on. > > > > That remains the only new fa

Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions

2023-08-18 Thread Thomas Munro
On Fri, Aug 18, 2023 at 12:48 AM John Naylor wrote: > On Thu, Aug 17, 2023 at 11:41 AM John Naylor > wrote: > > On Wed, Aug 16, 2023 at 5:17 PM John Naylor > > wrote: > > > > > > Split out tiebreaker comparisons from comparetup_* functions > > > > Hammerkop is getting OOM errors with this chan

Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions

2023-08-17 Thread John Naylor
On Thu, Aug 17, 2023 at 11:41 AM John Naylor wrote: > > > On Wed, Aug 16, 2023 at 5:17 PM John Naylor wrote: > > > > Split out tiebreaker comparisons from comparetup_* functions > > Hammerkop is getting OOM errors with this change. Most grand totals in the memory context stats show between 1 and

Re: pgsql: Split out tiebreaker comparisons from comparetup_* functions

2023-08-16 Thread John Naylor
On Wed, Aug 16, 2023 at 5:17 PM John Naylor wrote: > > Split out tiebreaker comparisons from comparetup_* functions Hammerkop is getting OOM errors with this change. Most grand totals in the memory context stats show between 1 and 3 MB, and "tuplesort main" only shows small-ish requests, so not s

pgsql: Split out tiebreaker comparisons from comparetup_* functions

2023-08-16 Thread John Naylor
Split out tiebreaker comparisons from comparetup_* functions Previously, if a specialized comparator found equal datum1 keys, the "comparetup" function would repeat the comparison on the datum before proceeding with the unabbreviated first key and/or additional sort keys. Move comparing additiona