Re: pgsql: Update high level vacuumlazy.c comments.

2021-12-01 Thread Robert Haas
On Tue, Nov 30, 2021 at 3:45 PM Peter Geoghegan wrote: > On Tue, Nov 30, 2021 at 12:20 PM Robert Haas wrote: > > +1. And that shouldn't happen often. > > Why shouldn't it happen often? > > I accept that I ought to have included a discussion link in this > instance. But I don't see how that's rela

Re: pgsql: Update high level vacuumlazy.c comments.

2021-11-30 Thread Peter Geoghegan
On Tue, Nov 30, 2021 at 12:20 PM Robert Haas wrote: > +1. And that shouldn't happen often. Why shouldn't it happen often? I accept that I ought to have included a discussion link in this instance. But I don't see how that's related to how often I commit things where including a discussion link i

Re: pgsql: Update high level vacuumlazy.c comments.

2021-11-30 Thread Robert Haas
On Tue, Nov 30, 2021 at 9:41 AM Alvaro Herrera wrote: > I think the only reason not to include a discussion link in the commit > message is that the patch is so trivial that there *is* no related post > in the mailing list. +1. And that shouldn't happen often. -- Robert Haas EDB: http://www.ent

Re: pgsql: Update high level vacuumlazy.c comments.

2021-11-30 Thread Alvaro Herrera
On 2021-Nov-29, Peter Geoghegan wrote: > This was a piece of the patch I posted here, which was discussed in > general terms: > > https://postgr.es/m/cah2-wzktgbg4si6dedmq3q6soxsdqni6mtmb8cmmtmvhsxd...@mail.gmail.com > > I found it useful to spin off the parts that reworked the high level > comm

Re: pgsql: Update high level vacuumlazy.c comments.

2021-11-29 Thread Peter Geoghegan
On Mon, Nov 29, 2021 at 6:58 AM Robert Haas wrote: > I don't know whether this was discussed and you forgot to include a > Discussion link, or whether it wasn't discussed on list, but typically > both things should happen. This was a piece of the patch I posted here, which was discussed in genera

Re: pgsql: Update high level vacuumlazy.c comments.

2021-11-29 Thread Robert Haas
On Sat, Nov 27, 2021 at 5:31 PM Peter Geoghegan wrote: > Update high level vacuumlazy.c comments. > > Update vacuumlazy.c file header comments (as well as comments above the > lazy_scan_heap function) that were largely written before the > introduction of the HOT optimization, when lazy_scan_heap

pgsql: Update high level vacuumlazy.c comments.

2021-11-27 Thread Peter Geoghegan
Update high level vacuumlazy.c comments. Update vacuumlazy.c file header comments (as well as comments above the lazy_scan_heap function) that were largely written before the introduction of the HOT optimization, when lazy_scan_heap did far less, and didn't actually prune during its initial heap p