Hi,
On 2025-03-18 11:03:36 -0400, Tom Lane wrote:
> Andres Freund writes:
> > aio: Add core asynchronous I/O infrastructure
>
> Some of the buildfarm is mildly unhappy with this.
> So far I see
>
> ayu | 2025-03-18 13:08:04 | aio_callback.c:83:12: warning:
> comparison of constant 1
Hi Andres,
> aio: Add core asynchronous I/O infrastructure
>
> [...]
I noticed that aio.c references README.md:
```
* aio.c
*AIO - Core Logic
*
* For documentation about how AIO works on a higher level, including a
* schematic example, see README.md.
```
However the file seems to be mi
Hi,
On 2025-03-31 19:23:57 +0300, Aleksander Alekseev wrote:
> Hi Andres,
>
> > aio: Add core asynchronous I/O infrastructure
> >
> > [...]
>
> I noticed that aio.c references README.md:
>
> ```
> * aio.c
> *AIO - Core Logic
> *
> * For documentation about how AIO works on a higher leve
Andres Freund writes:
> On 2025-03-18 11:26:15 -0400, Tom Lane wrote:
>> Well, if we don't want to fix it I can just adjust my warning-scraping
>> script to ignore these. Let's wait a bit and see if any newer
>> compilers warn similarly before deciding.
> FWIW, adding a few casts does silence th
Hi,
On 2025-03-18 11:26:15 -0400, Tom Lane wrote:
> Andres Freund writes:
> > I wonder if we should instead either ask those buildfarm animals to be
> > disabled or have the warning manually disabled. I don't think it's a good
> > investment on our part to work towards warning cleanliness on clan
Andres Freund writes:
> I wonder if we should instead either ask those buildfarm animals to be
> disabled or have the warning manually disabled. I don't think it's a good
> investment on our part to work towards warning cleanliness on clang 4 and 5,
> on distros from 2017 and and 2018 respectively
Andres Freund writes:
> aio: Add core asynchronous I/O infrastructure
Some of the buildfarm is mildly unhappy with this.
So far I see
ayu | 2025-03-18 13:08:04 | aio_callback.c:83:12: warning:
comparison of constant 1 with expression of type 'PgAioHandleCallbackID' (aka
'enum PgAioH
aio: Add core asynchronous I/O infrastructure
The main motivations to use AIO in PostgreSQL are:
a) Reduce the time spent waiting for IO by issuing IO sufficiently early.
In a few places we have approximated this using posix_fadvise() based
prefetching, but that is fairly limited (no compl
