Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-15 Thread Andres Freund
Hi, On 2022-09-15 16:48:04 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2022-09-13 22:45:46 -0400, Tom Lane wrote: > >> A three-line patch doesn't seem like an unreasonable thing to carry, > >> at least till these systems go out of support. We've jumped through > >> much higher hoops

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-15 Thread Tom Lane
Andres Freund writes: > On 2022-09-13 22:45:46 -0400, Tom Lane wrote: >> A three-line patch doesn't seem like an unreasonable thing to carry, >> at least till these systems go out of support. We've jumped through >> much higher hoops in the past to support niche platforms. > xlc 12.1 *is* out

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-15 Thread Andres Freund
Hi, On 2022-09-13 22:45:46 -0400, Tom Lane wrote: > Andres Freund writes: > > So we could work around the xlc 12.1 issue with something like the attached > > patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will > > have to wait a while to see more > > Shouldn't that be

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Tom Lane
Andres Freund writes: > So we could work around the xlc 12.1 issue with something like the attached > patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will > have to wait a while to see more Shouldn't that be more like + if test

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Andres Freund
Hi, On 2022-09-13 11:25:30 -0700, Andres Freund wrote: > On 2022-09-11 11:19:25 -0700, Andres Freund wrote: > > We could also try to fall back to using -Wl,b,expall for extension modules. > > expall doesn't work, because of our use of identifiers in reserved namespaces, > e.g. _PG_init: > >

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Andres Freund
Hi, On 2022-09-11 11:19:25 -0700, Andres Freund wrote: > We could also try to fall back to using -Wl,b,expall for extension modules. expall doesn't work, because of our use of identifiers in reserved namespaces, e.g. _PG_init: expall Exports all global symbols, except

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Andres Freund
On 2022-09-13 00:15:55 -0700, Andres Freund wrote: > On 2022-09-12 23:39:04 -0700, Noah Misch wrote: > > On Mon, Sep 12, 2022 at 11:11:23PM -0700, Andres Freund wrote: > > > > > > -qvisibility option specifies visibility attributes for entities. > > > > > > Entity > > > > > > visibility

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Andres Freund
Hi, On 2022-09-13 00:02:53 -0700, Andres Freund wrote: > On 2022-09-12 23:11:23 -0700, Andres Freund wrote: > > I'll check it out tomorrow. I configured perl on the other AIX gcc compile > > farm machine building 64bit with both gcc and xlc, IIRC. I can't check rn, > > they seem to be down? > >

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Andres Freund
Hi, On 2022-09-12 23:39:04 -0700, Noah Misch wrote: > On Mon, Sep 12, 2022 at 11:11:23PM -0700, Andres Freund wrote: > > On 2022-09-12 20:38:45 -0700, Noah Misch wrote: > > > On Sun, Sep 11, 2022 at 11:19:25AM -0700, Andres Freund wrote: > > > Both runs had the latest commits discussed above.

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Andres Freund
Hi, On 2022-09-12 23:11:23 -0700, Andres Freund wrote: > I'll check it out tomorrow. I configured perl on the other AIX gcc compile > farm machine building 64bit with both gcc and xlc, IIRC. I can't check rn, > they seem to be down? Seems to just have been a temporary connectivity issue. After

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Noah Misch
On Mon, Sep 12, 2022 at 11:11:23PM -0700, Andres Freund wrote: > On 2022-09-12 20:38:45 -0700, Noah Misch wrote: > > On Sun, Sep 11, 2022 at 11:19:25AM -0700, Andres Freund wrote: > > > On 2022-09-10 01:19:44 -0700, Andres Freund wrote: > > > > On 2022-09-09 22:57:36 -0700, Andres Freund wrote: >

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-13 Thread Andres Freund
Hi, On 2022-09-12 20:38:45 -0700, Noah Misch wrote: > On Sun, Sep 11, 2022 at 11:19:25AM -0700, Andres Freund wrote: > > On 2022-09-10 01:19:44 -0700, Andres Freund wrote: > > > On 2022-09-09 22:57:36 -0700, Andres Freund wrote: > > > > On 2022-09-10 01:32:52 -0400, Tom Lane wrote: > > > > >

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-12 Thread Noah Misch
On Sun, Sep 11, 2022 at 11:19:25AM -0700, Andres Freund wrote: > On 2022-09-10 01:19:44 -0700, Andres Freund wrote: > > On 2022-09-09 22:57:36 -0700, Andres Freund wrote: > > > On 2022-09-10 01:32:52 -0400, Tom Lane wrote: > > > > Andres Freund writes: > > > > > It seem worth applying the

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-11 Thread Andres Freund
Hi, On 2022-09-10 01:19:44 -0700, Andres Freund wrote: > On 2022-09-09 22:57:36 -0700, Andres Freund wrote: > > On 2022-09-10 01:32:52 -0400, Tom Lane wrote: > > > Andres Freund writes: > > > > It seem worth applying the -qvisibility patch and seeing whether that > > > > fixes > > > > the

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-10 Thread Andres Freund
Hi, On 2022-09-09 22:57:36 -0700, Andres Freund wrote: > On 2022-09-10 01:32:52 -0400, Tom Lane wrote: > > Andres Freund writes: > > > It seem worth applying the -qvisibility patch and seeing whether that > > > fixes > > > the buildfarm? > > > > Worth a try. > > Done now. Seems to have done

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-09 Thread Andres Freund
Hi, On 2022-09-10 01:32:52 -0400, Tom Lane wrote: > Andres Freund writes: > > It seem worth applying the -qvisibility patch and seeing whether that fixes > > the buildfarm? > > Worth a try. Done now. Looks like we also could get away with -Wl,-bexpall or such, but of course selective

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-09 Thread Tom Lane
Andres Freund writes: > It seem worth applying the -qvisibility patch and seeing whether that fixes > the buildfarm? Worth a try. > I guess alternatively we could revert the mkldexport patch, > apply the -qvisibility patch and then apply the mkldexport thing again > afterwards? Seems pretty

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-09 Thread Andres Freund
Hi, On 2022-09-09 21:37:49 -0700, Andres Freund wrote: > On 2022-09-09 21:16:38 -0700, Andres Freund wrote: > > On September 9, 2022 9:14:26 PM PDT, Tom Lane wrote: > > >Andres Freund writes: > > >> aix: No need to use mkldexport when we want to export all symbols > > > > > >hmm, early returns

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-09 Thread Andres Freund
Hi, On 2022-09-09 21:16:38 -0700, Andres Freund wrote: > On September 9, 2022 9:14:26 PM PDT, Tom Lane wrote: > >Andres Freund writes: > >> aix: No need to use mkldexport when we want to export all symbols > > > >hmm, early returns not good: > > >

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-09 Thread Andres Freund
Hi, On September 9, 2022 9:14:26 PM PDT, Tom Lane wrote: >Andres Freund writes: >> aix: No need to use mkldexport when we want to export all symbols > >hmm, early returns not good: > >https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly=2022-09-10%2003%3A31%3A29 > >The backend

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-09 Thread Tom Lane
Andres Freund writes: > aix: No need to use mkldexport when we want to export all symbols hmm, early returns not good: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hoverfly=2022-09-10%2003%3A31%3A29 The backend seems to build OK, but our first try to make a .so falls over:

pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-09 Thread Andres Freund
aix: No need to use mkldexport when we want to export all symbols When building a shared library with exports.txt there's no need to build an intermediary static library, we can just pass -Wl,-bE:... when generating the .so. When building a shared library without exports.txt, there's no need to