Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-02-01 Thread Tom Lane
Andres Freund writes: > On 2022-01-31 15:08:30 -0500, Tom Lane wrote: >> Done now. > Thanks! Just for the archives' sake --- seems this broke pademelon [1]: cc -Ae -g +O0 -Wp,-H16384 +Z -I. -I. -I../../../src/include -D_XOPEN_SOURCE_EXTENDED -I/usr/local/libxml2-2.6.23/include/libxml2 -I/us

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-31 Thread Andres Freund
On 2022-01-31 15:08:30 -0500, Tom Lane wrote: > Done now. Thanks!

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-31 Thread Tom Lane
Andres Freund writes: > On 2022-01-30 21:01:07 -0500, Tom Lane wrote: >> I think we oughta backport. We didn't do so at the time because >> we thought it was mostly cosmetic/future-proofing, but evidently >> the future is now. >> I can look into that tomorrow or so. > Cool. I can either do a rev

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-31 Thread Kyotaro Horiguchi
At Sun, 30 Jan 2022 17:35:48 -0800, Andres Freund wrote in > Hi, > > On 2022-01-31 00:44:39 +, Andres Freund wrote: > > plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. > > > > For older versions we need our own copy of perl's setlocale(), because it > > was > > not ex

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
Hi, On 2022-01-30 21:01:07 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2022-01-30 17:35:48 -0800, Andres Freund wrote: > >> I see this broke on everywhere but master. Looking. > > > Ugh. It's that we didn't backport pport.h. > > Ooops. I've pushed the quick fix of just using PERL_VER

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Tom Lane
Andres Freund writes: > On 2022-01-30 17:35:48 -0800, Andres Freund wrote: >> I see this broke on everywhere but master. Looking. > Ugh. It's that we didn't backport pport.h. Ooops. > Unless somebody comes up with a better idea quickly I'm going use a plain > PERL_VERSION check in the backbranc

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
Hi, On 2022-01-30 17:35:48 -0800, Andres Freund wrote: > I see this broke on everywhere but master. Looking. Ugh. It's that we didn't backport pport.h. commit 05798c9f7f08908bdd06c82d934da67535b72005 Author: Tom Lane Date: 2021-10-07 13:59:43 -0400 plperl: update ppport.h to Perl 5.34.0.

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
Hi, On 2022-01-31 00:44:39 +, Andres Freund wrote: > plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. > > For older versions we need our own copy of perl's setlocale(), because it was > not exposed (why we need the setlocale in the first place is explained in > plperl_ini

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used