Re: pgsql: Set libpq sslcompression to off by default

2018-03-20 Thread Daniel Gustafsson
> On 20 Mar 2018, at 05:15, Tom Lane wrote: > > Peter Eisentraut writes: >> On 3/17/18 15:12, Daniel Gustafsson wrote: >>> On 17 Mar 2018, at 17:47, Tom Lane wrote: Buildfarm reports that SSL_clear_options isn't available everywhere. > >>> Per some reading of the documentation and various

pgsql: Fix CommandCounterIncrement in partition-related DDL

2018-03-20 Thread Alvaro Herrera
Fix CommandCounterIncrement in partition-related DDL It makes sense to do the CCIs in the places that do catalog updates, rather than before the places that error out because the former ones fail to do it. In particular, it looks like StorePartitionBound() and IndexSetParentIndex() ought to make

Re: pgsql: Fix CommandCounterIncrement in partition-related DDL

2018-03-20 Thread Alvaro Herrera
Alvaro Herrera wrote: > Fix CommandCounterIncrement in partition-related DDL Hmm, Prion seems unhappy about this. Looking -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql: Defer creation of partially-grouped relation until it's needed.

2018-03-20 Thread Robert Haas
Defer creation of partially-grouped relation until it's needed. This avoids unnecessarily creating a RelOptInfo for which we have no actual need. This idea is from Ashutosh Bapat, who wrote a very different patch to accomplish a similar goal. It will be more important if and when we get partitio

pgsql: Determine grouping strategies in create_grouping_paths.

2018-03-20 Thread Robert Haas
Determine grouping strategies in create_grouping_paths. Partition-wise aggregate will call create_ordinary_grouping_paths multiple times and we don't want to redo this work every time; have the caller do it instead and pass the details down. Patch by me, reviewed by Ashutosh Bapat. Discussion:

pgsql: Doc: typo fix, "PG_" should be "TG_" here.

2018-03-20 Thread Tom Lane
Doc: typo fix, "PG_" should be "TG_" here. Too much PG on the brain in commit 769159fd3, evidently. Noted by [email protected]. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org

pgsql: Doc: typo fix, "PG_" should be "TG_" here.

2018-03-20 Thread Tom Lane
Doc: typo fix, "PG_" should be "TG_" here. Too much PG on the brain in commit 769159fd3, evidently. Noted by [email protected]. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgre

pgsql: Doc: typo fix, "PG_" should be "TG_" here.

2018-03-20 Thread Tom Lane
Doc: typo fix, "PG_" should be "TG_" here. Too much PG on the brain in commit 769159fd3, evidently. Noted by [email protected]. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://git.postgre

pgsql: Don't pass the grouping target around unnecessarily.

2018-03-20 Thread Robert Haas
Don't pass the grouping target around unnecessarily. Since commit 4f15e5d09de276fb77326be5567dd9796008ca2e made grouped_rel set reltarget, a variety of other functions can just get it from grouped_rel instead of having to pass it around explicitly. Simplify accordingly. Patch by me, reviewed by

pgsql: Make configure check for a couple more Perl modules for --enable

2018-03-20 Thread Tom Lane
Make configure check for a couple more Perl modules for --enable-tap-tests. Red Hat's notion of a basic Perl installation doesn't include Test::More or Time::HiRes, and reportedly some Debian installs also omit Time::HiRes. Check for those during configure to spare the user the pain of digging thr

pgsql: Add PGAC_PROG_VARCC_VARFLAGS_OPT autoconf macro.

2018-03-20 Thread Andres Freund
Add PGAC_PROG_VARCC_VARFLAGS_OPT autoconf macro. The new macro allows to test flags for different compilers and to store them in different CFLAG like variables. The existing PGAC_PROG_CC_CFLAGS_OPT and PGAC_PROG_CC_VAR_OPT are changed to be just wrappers around the new function. This'll be used

pgsql: Attempt to fix build with unusual OpenSSL versions

2018-03-20 Thread Peter Eisentraut
Attempt to fix build with unusual OpenSSL versions Since e3bdb2d92600ed45bd46aaf48309a436a9628218, libpq failed to build on some platforms because they did not have SSL_clear_options(). Although mainline OpenSSL introduced SSL_clear_options() after SSL_OP_NO_COMPRESSION, so the code should have b

Re: pgsql: Set libpq sslcompression to off by default

2018-03-20 Thread Peter Eisentraut
On 3/20/18 04:03, Daniel Gustafsson wrote: > If we test for SSL_clear_options(), and use the sk_SSL_COMP_zero() where not > available, we should be able to keep backwards compatibility with older > OpenSSL > revisions even if the distros have patched them AFAICT. Unless you’re already > working o

pgsql: Add C++ support to configure.

2018-03-20 Thread Andres Freund
Add C++ support to configure. This is an optional dependency. It'll be used for the upcoming LLVM based just in time compilation support, which needs to wrap a few LLVM C++ APIs so they're accessible from C.. For now test for C++ compilers unconditionally, without failing if not present, to ensur

pgsql: Add configure infrastructure (--with-llvm) to enable LLVM suppor

2018-03-20 Thread Andres Freund
Add configure infrastructure (--with-llvm) to enable LLVM support. LLVM will be used for *optional* Just-in-time compilation support. This commit just adds the configure infrastructure that detects LLVM. No documentation has been added for the --with-llvm flag, that'll be added after the actual s

Re: pgsql: Set libpq sslcompression to off by default

2018-03-20 Thread Daniel Gustafsson
> On 20 Mar 2018, at 22:00, Peter Eisentraut > wrote: > > On 3/20/18 04:03, Daniel Gustafsson wrote: >> If we test for SSL_clear_options(), and use the sk_SSL_COMP_zero() where not >> available, we should be able to keep backwards compatibility with older >> OpenSSL >> revisions even if the dis

pgsql: Handle EEOP_FUNCEXPR_[STRICT_]FUSAGE out of line.

2018-03-20 Thread Andres Freund
Handle EEOP_FUNCEXPR_[STRICT_]FUSAGE out of line. This isn't a very common op, and it doesn't seem worth duplicating for JIT. Author: Andres Freund Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4cb839e6d4593e63439879b0c2abea14f426 Modified Files