pgsql: Documentation improvement for pg_trgm

2018-06-13 Thread Alexander Korotkov
Documentation improvement for pg_trgm Documentation of word_similarity() and strict_word_similarity() functions contains some vague wordings which could confuse users. This patch makes those wordings more clear. word_similarity() was introduced in PostgreSQL 9.6, and corresponding part of docume

pgsql: Documentation improvement for pg_trgm

2018-06-13 Thread Alexander Korotkov
Documentation improvement for pg_trgm Documentation of word_similarity() and strict_word_similarity() functions contains some vague wordings which could confuse users. This patch makes those wordings more clear. word_similarity() was introduced in PostgreSQL 9.6, and corresponding part of docume

pgsql: Documentation improvement for pg_trgm

2018-06-13 Thread Alexander Korotkov
Documentation improvement for pg_trgm Documentation of word_similarity() and strict_word_similarity() functions contains some vague wordings which could confuse users. This patch makes those wordings more clear. word_similarity() was introduced in PostgreSQL 9.6, and corresponding part of docume

pgsql: Fix up run-time partition pruning's use of relcache's partition

2018-06-13 Thread Tom Lane
Fix up run-time partition pruning's use of relcache's partition data. The previous coding saved pointers into the partitioned table's relcache entry, but then closed the relcache entry, causing those pointers to nominally become dangling. Actual trouble would be seen in the field only if a relcac

pgsql: Fix some ill-chosen names for globally-visible partition support

2018-06-13 Thread Tom Lane
Fix some ill-chosen names for globally-visible partition support functions. "compute_hash_value" is particularly gratuitously generic, but IMO all of these ought to have names clearly related to partitioning. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/19832753f

pgsql: Code review for match_clause_to_partition_key().

2018-06-13 Thread Tom Lane
Code review for match_clause_to_partition_key(). Fix inconsistent decisions about NOMATCH vs UNSUPPORTED result codes. If we're going to cater for partkeys that have the same expression and different collations, surely we should also support partkeys with the same expression and different opclasse