Re: pgsql: Add support for nearest-neighbor (KNN) searches to SP-GiST

2018-09-19 Thread Alexander Korotkov
On Wed, Sep 19, 2018 at 1:57 AM Alexander Korotkov wrote: > KNN > support is provided for three SP-GIST opclasses: quad_point_ops, kd_point_ops > and poly_ops (catversion is bumped). While bumping catversion I was wondering what is timezone of our catversion? Quick search over archives didn't gi

Re: pgsql: Add support for nearest-neighbor (KNN) searches to SP-GiST

2018-09-19 Thread Tom Lane
Alexander Korotkov writes: > While bumping catversion I was wondering what is timezone of our > catversion? Quick search over archives didn't give me an answer. There's no particular convention. I think it's fine to use your own timezone. Just be sure you never make catversion go backwards.

Re: pgsql: Add support for nearest-neighbor (KNN) searches to SP-GiST

2018-09-19 Thread Alexander Korotkov
On Wed, Sep 19, 2018 at 5:35 PM Tom Lane wrote: > Alexander Korotkov writes: > > While bumping catversion I was wondering what is timezone of our > > catversion? Quick search over archives didn't give me an answer. > > There's no particular convention. I think it's fine to use your > own timezo

pgsql: Don't ignore locktable-full failures in StandbyAcquireAccessExcl

2018-09-19 Thread Tom Lane
Don't ignore locktable-full failures in StandbyAcquireAccessExclusiveLock. Commit 37c54863c removed the code in StandbyAcquireAccessExclusiveLock that checked the return value of LockAcquireExtended. That created a bug, because it's still passing reportMemoryError = false to LockAcquireExtended,

pgsql: Don't ignore locktable-full failures in StandbyAcquireAccessExcl

2018-09-19 Thread Tom Lane
Don't ignore locktable-full failures in StandbyAcquireAccessExclusiveLock. Commit 37c54863c removed the code in StandbyAcquireAccessExclusiveLock that checked the return value of LockAcquireExtended. That created a bug, because it's still passing reportMemoryError = false to LockAcquireExtended,

pgsql: Don't ignore locktable-full failures in StandbyAcquireAccessExcl

2018-09-19 Thread Tom Lane
Don't ignore locktable-full failures in StandbyAcquireAccessExclusiveLock. Commit 37c54863c removed the code in StandbyAcquireAccessExclusiveLock that checked the return value of LockAcquireExtended. That created a bug, because it's still passing reportMemoryError = false to LockAcquireExtended,

pgsql: Don't ignore locktable-full failures in StandbyAcquireAccessExcl

2018-09-19 Thread Tom Lane
Don't ignore locktable-full failures in StandbyAcquireAccessExclusiveLock. Commit 37c54863c removed the code in StandbyAcquireAccessExclusiveLock that checked the return value of LockAcquireExtended. That created a bug, because it's still passing reportMemoryError = false to LockAcquireExtended,

pgsql: Tag refs/tags/REL_11_BETA4 was created

2018-09-19 Thread pgsql
Tag refs/tags/REL_11_BETA4 was created.

pgsql: Fix minor error message style guide violation.

2018-09-19 Thread Tom Lane
Fix minor error message style guide violation. No periods at the ends of primary error messages, please. Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0d38e4ebb7a136a

pgsql: Fix minor error message style guide violation.

2018-09-19 Thread Tom Lane
Fix minor error message style guide violation. No periods at the ends of primary error messages, please. Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/64496164

pgsql: Enforce translation mode for Windows frontends to text with open

2018-09-19 Thread Michael Paquier
Enforce translation mode for Windows frontends to text with open/fopen Allowing frontends to use concurrent-safe open() and fopen() via 0ba06e0 has the side-effect of switching the default translation mode from text to binary, so the switch can cause breakages for frontend tools when the caller of

pgsql: Defer restoration of libraries in parallel workers.

2018-09-19 Thread Thomas Munro
Defer restoration of libraries in parallel workers. Several users of extensions complained of crashes in parallel workers that turned out to be due to syscache access from their _PG_init() functions. Reorder the initialization of parallel workers so that libraries are restored after the caches ar

pgsql: Defer restoration of libraries in parallel workers.

2018-09-19 Thread Thomas Munro
Defer restoration of libraries in parallel workers. Several users of extensions complained of crashes in parallel workers that turned out to be due to syscache access from their _PG_init() functions. Reorder the initialization of parallel workers so that libraries are restored after the caches ar

pgsql: Defer restoration of libraries in parallel workers.

2018-09-19 Thread Thomas Munro
Defer restoration of libraries in parallel workers. Several users of extensions complained of crashes in parallel workers that turned out to be due to syscache access from their _PG_init() functions. Reorder the initialization of parallel workers so that libraries are restored after the caches ar

pgsql: Defer restoration of libraries in parallel workers.

2018-09-19 Thread Thomas Munro
Defer restoration of libraries in parallel workers. Several users of extensions complained of crashes in parallel workers that turned out to be due to syscache access from their _PG_init() functions. Reorder the initialization of parallel workers so that libraries are restored after the caches ar

pgsql: Fix segment_bins corruption in dsa.c.

2018-09-19 Thread Thomas Munro
Fix segment_bins corruption in dsa.c. If a segment has been freed by dsa.c because it is entirely empty, other backends must make sure to unmap it before following links to new segments that might happen to have the same index number, or they could finish up looking at a defunct segment and then c

pgsql: Fix segment_bins corruption in dsa.c.

2018-09-19 Thread Thomas Munro
Fix segment_bins corruption in dsa.c. If a segment has been freed by dsa.c because it is entirely empty, other backends must make sure to unmap it before following links to new segments that might happen to have the same index number, or they could finish up looking at a defunct segment and then c

pgsql: Fix segment_bins corruption in dsa.c.

2018-09-19 Thread Thomas Munro
Fix segment_bins corruption in dsa.c. If a segment has been freed by dsa.c because it is entirely empty, other backends must make sure to unmap it before following links to new segments that might happen to have the same index number, or they could finish up looking at a defunct segment and then c