pgsql: Remove extra word from create sub docs

2018-11-03 Thread Stephen Frost
Remove extra word from create sub docs Improve the documentation in the CREATE SUBSCRIPTION command a bit by removing an extraneous word and spelling out 'information'. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0e88ba1fe1e02086e718982a86c94c3c366c9d62

pgsql: Remove extra word from create sub docs

2018-11-03 Thread Stephen Frost
Remove extra word from create sub docs Improve the documentation in the CREATE SUBSCRIPTION command a bit by removing an extraneous word and spelling out 'information'. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ceadcbe8ffe50f7fb9e1fa5aed652a33aab908a5 Modifie

pgsql: Remove extra word from create sub docs

2018-11-03 Thread Stephen Frost
Remove extra word from create sub docs Improve the documentation in the CREATE SUBSCRIPTION command a bit by removing an extraneous word and spelling out 'information'. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cf2245159172836db29d8f0bc7d7164fd33714b1

pgsql: Fix tablespace handling for partitioned indexes

2018-11-03 Thread Alvaro Herrera
Fix tablespace handling for partitioned indexes When creating partitioned indexes, the tablespace was not being saved for the parent index. This meant that subsequently created partitions would not use the right tablespace for their indexes. ALTER INDEX SET TABLESPACE and ALTER INDEX ALL IN TABLE

pgsql: Fix tablespace handling for partitioned indexes

2018-11-03 Thread Alvaro Herrera
Fix tablespace handling for partitioned indexes When creating partitioned indexes, the tablespace was not being saved for the parent index. This meant that subsequently created partitions would not use the right tablespace for their indexes. ALTER INDEX SET TABLESPACE and ALTER INDEX ALL IN TABLE

pgsql: Make ts_locale.c's character-type functions cope with UTF-16.

2018-11-03 Thread Tom Lane
Make ts_locale.c's character-type functions cope with UTF-16. On Windows, in UTF8 database encoding, what char2wchar() produces is UTF16 not UTF32, ie, characters above U+ will be represented by surrogate pairs. t_isdigit() and siblings did not account for this and failed to provide a large e

pgsql: Make ts_locale.c's character-type functions cope with UTF-16.

2018-11-03 Thread Tom Lane
Make ts_locale.c's character-type functions cope with UTF-16. On Windows, in UTF8 database encoding, what char2wchar() produces is UTF16 not UTF32, ie, characters above U+ will be represented by surrogate pairs. t_isdigit() and siblings did not account for this and failed to provide a large e

pgsql: Make ts_locale.c's character-type functions cope with UTF-16.

2018-11-03 Thread Tom Lane
Make ts_locale.c's character-type functions cope with UTF-16. On Windows, in UTF8 database encoding, what char2wchar() produces is UTF16 not UTF32, ie, characters above U+ will be represented by surrogate pairs. t_isdigit() and siblings did not account for this and failed to provide a large e

pgsql: Make ts_locale.c's character-type functions cope with UTF-16.

2018-11-03 Thread Tom Lane
Make ts_locale.c's character-type functions cope with UTF-16. On Windows, in UTF8 database encoding, what char2wchar() produces is UTF16 not UTF32, ie, characters above U+ will be represented by surrogate pairs. t_isdigit() and siblings did not account for this and failed to provide a large e

pgsql: Make ts_locale.c's character-type functions cope with UTF-16.

2018-11-03 Thread Tom Lane
Make ts_locale.c's character-type functions cope with UTF-16. On Windows, in UTF8 database encoding, what char2wchar() produces is UTF16 not UTF32, ie, characters above U+ will be represented by surrogate pairs. t_isdigit() and siblings did not account for this and failed to provide a large e

pgsql: Make ts_locale.c's character-type functions cope with UTF-16.

2018-11-03 Thread Tom Lane
Make ts_locale.c's character-type functions cope with UTF-16. On Windows, in UTF8 database encoding, what char2wchar() produces is UTF16 not UTF32, ie, characters above U+ will be represented by surrogate pairs. t_isdigit() and siblings did not account for this and failed to provide a large e

pgsql: Make ts_locale.c's character-type functions cope with UTF-16.

2018-11-03 Thread Tom Lane
Make ts_locale.c's character-type functions cope with UTF-16. On Windows, in UTF8 database encoding, what char2wchar() produces is UTF16 not UTF32, ie, characters above U+ will be represented by surrogate pairs. t_isdigit() and siblings did not account for this and failed to provide a large e

pgsql: Fix STRICT check for strict aggregates with NULL ORDER BY column

2018-11-03 Thread Andres Freund
Fix STRICT check for strict aggregates with NULL ORDER BY columns. I (Andres) broke this unintentionally in 69c3936a14, by checking strictness for all input expressions computed for an aggregate, rather than just the input for the aggregate transition function. Reported-By: Ondřej Bouda Bisected-

pgsql: Fix STRICT check for strict aggregates with NULL ORDER BY column

2018-11-03 Thread Andres Freund
Fix STRICT check for strict aggregates with NULL ORDER BY columns. I (Andres) broke this unintentionally in 69c3936a14, by checking strictness for all input expressions computed for an aggregate, rather than just the input for the aggregate transition function. Reported-By: Ondřej Bouda Bisected-

pgsql: Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when n

2018-11-03 Thread Andres Freund
Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when nargs == 0. This only became a problem with 4c640f4f38, which didn't synchronize the value agg_strict_input_check.nargs is set to, with the guard condition for emitting the operation. Besides such instructions being unnecessary overhe

pgsql: Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when n

2018-11-03 Thread Andres Freund
Prevent generating EEOP_AGG_STRICT_INPUT_CHECK operations when nargs == 0. This only became a problem with 4c640f4f38, which didn't synchronize the value agg_strict_input_check.nargs is set to, with the guard condition for emitting the operation. Besides such instructions being unnecessary overhe