Re: pgsql: Remove function names from error messages

2018-12-21 Thread Alvaro Herrera
On 2018-Dec-20, Michael Paquier wrote: > On Wed, Dec 19, 2018 at 05:53:48PM +, Alvaro Herrera wrote: > > Remove function names from error messages > > > > They are not necessary, and having them there gives useless work for > > translators. > > I am spotting a couple of extra ones for functi

Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()

2018-12-21 Thread Alvaro Herrera
Hmmm, I'm fairly sure you should have bumped XLOG_PAGE_MAGIC for this change. Otherwise, what is going to happen to an unpatched standby (of released versions) that receives the new WAL record from a patched primary? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Develo

Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()

2018-12-21 Thread Tom Lane
Alvaro Herrera writes: > Hmmm, I'm fairly sure you should have bumped XLOG_PAGE_MAGIC for this > change. Otherwise, what is going to happen to an unpatched standby (of > released versions) that receives the new WAL record from a patched > primary? We can't change XLOG_PAGE_MAGIC in released bran

Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()

2018-12-21 Thread Tom Lane
Alvaro Herrera writes: >> Hmmm, I'm fairly sure you should have bumped XLOG_PAGE_MAGIC for this >> change. Otherwise, what is going to happen to an unpatched standby (of >> released versions) that receives the new WAL record from a patched >> primary? Oh, and if the answer to your question is no

Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()

2018-12-21 Thread Alvaro Herrera
On 2018-Dec-21, Tom Lane wrote: > Alvaro Herrera writes: > > Hmmm, I'm fairly sure you should have bumped XLOG_PAGE_MAGIC for this > > change. Otherwise, what is going to happen to an unpatched standby (of > > released versions) that receives the new WAL record from a patched > > primary? > > W

Re: pgsql: Remove function names from error messages

2018-12-21 Thread Michael Paquier
On Fri, Dec 21, 2018 at 11:05:37AM -0300, Alvaro Herrera wrote: > Yeah, I grepped for other uses and found format() being mentioned too, > but there didn't seem to be any repetition in the messages other than > the ones I patched, so I didn't bother. Thanks for following through > with these ones

Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()

2018-12-21 Thread Alexander Korotkov
On Fri, Dec 21, 2018 at 7:09 PM Tom Lane wrote: > Alvaro Herrera writes: > >> Hmmm, I'm fairly sure you should have bumped XLOG_PAGE_MAGIC for this > >> change. Otherwise, what is going to happen to an unpatched standby (of > >> released versions) that receives the new WAL record from a patched

pgsql: Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

2018-12-21 Thread Peter Eisentraut
Fix ancient compiler warnings and typos in !HAVE_SYMLINK code This has never been correct since this code was introduced. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f4eabaf3e0f84d5eb3ebdeeff0a71cb8db4b1ff6 Modified Files -- src/bin/initdb/initdb.c

pgsql: Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

2018-12-21 Thread Peter Eisentraut
Fix ancient compiler warnings and typos in !HAVE_SYMLINK code This has never been correct since this code was introduced. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8717736670867b2e9c4e1ad841d5d0ea9e3c2965 Modified Files -- src/bin/initdb/in

pgsql: Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

2018-12-21 Thread Peter Eisentraut
Fix ancient compiler warnings and typos in !HAVE_SYMLINK code This has never been correct since this code was introduced. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ffcd98c7fcfb2ed4ef9069591c06d3748669941c Modified Files -- src/bin/initdb/in

pgsql: Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

2018-12-21 Thread Peter Eisentraut
Fix ancient compiler warnings and typos in !HAVE_SYMLINK code This has never been correct since this code was introduced. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/669d9eae8531c5d84bc2f6d8f8c9b93d50345403 Modified Files -- src/bin/initdb/in

pgsql: Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

2018-12-21 Thread Peter Eisentraut
Fix ancient compiler warnings and typos in !HAVE_SYMLINK code This has never been correct since this code was introduced. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/018923ccc1a68eeac852edeac2ba3bc91dcbd494 Modified Files -- src/bin/initdb/in

pgsql: Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

2018-12-21 Thread Peter Eisentraut
Fix ancient compiler warnings and typos in !HAVE_SYMLINK code This has never been correct since this code was introduced. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b7b0314b80e90130b27e9f5ee4e45778e4cccf09 Modified Files -- src/bin/initdb/in

pgsql: Add WRITE_*_ARRAY macros

2018-12-21 Thread Peter Eisentraut
Add WRITE_*_ARRAY macros Add WRITE_ATTRNUMBER_ARRAY, WRITE_OID_ARRAY, WRITE_INT_ARRAY, WRITE_BOOL_ARRAY macros to outfuncs.c, mirroring the existing READ_*_ARRAY macros in readfuncs.c. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/8f2ebc67-e75f-9478-f5a5-bbbf090b1

pgsql: Add some const decorations

2018-12-21 Thread Peter Eisentraut
Add some const decorations These mainly help understanding the function signatures better. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/323eaf98250e2de9afb2d9f86fa841beaeb575b7 Modified Files -- src/backend/executor/execExpr.c | 4 ++-- src/backe