pgsql: pg_dump: allow multiple rows per insert

2019-03-07 Thread Alvaro Herrera
pg_dump: allow multiple rows per insert This is useful to speed up loading data in a different database engine. Authors: Surafel Temesgen and David Rowley. Lightly edited by Álvaro. Reviewed-by: Fabien Coelho Discussion: https://postgr.es/m/calay4q9kumsdnrbzvrjvsrf2+bh20ymsvzqokvwpemodd-x...@ma

pgsql: Add missing

2019-03-07 Thread Alvaro Herrera
Add missing Per buildfarm Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cb706ec4b60b3dede957ffdd70451b017eddffb0 Modified Files -- src/bin/pg_dump/pg_dump.c | 1 + 1 file changed, 1 insertion(+)

pgsql: Fix the BY {REF,VALUE} clause of XMLEXISTS/XMLTABLE

2019-03-07 Thread Alvaro Herrera
Fix the BY {REF,VALUE} clause of XMLEXISTS/XMLTABLE This clause is used to indicate the passing mode of a XML document, but we were doing it wrong: we accepted BY REF and ignored it, and rejected BY VALUE as a syntax error. The reality, however, is that documents are always passed BY VALUE, so re

pgsql: Fix broken markup

2019-03-07 Thread Alvaro Herrera
Fix broken markup Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ec51727f6eed38f302a10cdb0066f4484b0b5902 Modified Files -- doc/src/sgml/func.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Allow ATTACH PARTITION with only ShareUpdateExclusiveLock.

2019-03-07 Thread Robert Haas
Allow ATTACH PARTITION with only ShareUpdateExclusiveLock. We still require AccessExclusiveLock on the partition itself, because otherwise an insert that violates the newly-imposed partition constraint could be in progress at the same time that we're changing that constraint; only the lock level o

pgsql: Fix handling of targetlist SRFs when scan/join relation is known

2019-03-07 Thread Tom Lane
Fix handling of targetlist SRFs when scan/join relation is known empty. When we introduced separate ProjectSetPath nodes for application of set-returning functions in v10, we inadvertently broke some cases where we're supposed to recognize that the result of a subquery is known to be empty (contai

pgsql: Fix handling of targetlist SRFs when scan/join relation is known

2019-03-07 Thread Tom Lane
Fix handling of targetlist SRFs when scan/join relation is known empty. When we introduced separate ProjectSetPath nodes for application of set-returning functions in v10, we inadvertently broke some cases where we're supposed to recognize that the result of a subquery is known to be empty (contai

pgsql: Fix handling of targetlist SRFs when scan/join relation is known

2019-03-07 Thread Tom Lane
Fix handling of targetlist SRFs when scan/join relation is known empty. When we introduced separate ProjectSetPath nodes for application of set-returning functions in v10, we inadvertently broke some cases where we're supposed to recognize that the result of a subquery is known to be empty (contai

pgsql: Fix minor deficiencies in XMLTABLE, xpath(), xmlexists()

2019-03-07 Thread Alvaro Herrera
Fix minor deficiencies in XMLTABLE, xpath(), xmlexists() Correctly process nodes of more types than previously. In some cases, nodes were being ignored (nothing was output); in other cases, trying to return them resulted in errors about unrecognized nodes. In yet other cases, necessary escaping

pgsql: Fix compatibility of pg_basebackup -R with 11 and older versions

2019-03-07 Thread Michael Paquier
Fix compatibility of pg_basebackup -R with 11 and older versions When 2dedf4d9 has integrated recovery.conf into postgresql.conf, it also changed pg_basebackup -R in the way recovery configuration is generated. However this implementation forgot the fact that pg_basebackup needs to keep compatibi

pgsql: Fix function signatures of pageinspect in documentation

2019-03-07 Thread Michael Paquier
Fix function signatures of pageinspect in documentation tuple_data_split() lacked the type of the first argument, and heap_page_item_attrs() has reversed the first and second argument, with the bytea argument using an incorrect name. Author: Laurenz Albe Discussion: https://postgr.es/m/8f9ab7b16

pgsql: Fix function signatures of pageinspect in documentation

2019-03-07 Thread Michael Paquier
Fix function signatures of pageinspect in documentation tuple_data_split() lacked the type of the first argument, and heap_page_item_attrs() has reversed the first and second argument, with the bytea argument using an incorrect name. Author: Laurenz Albe Discussion: https://postgr.es/m/8f9ab7b16

pgsql: Fix function signatures of pageinspect in documentation

2019-03-07 Thread Michael Paquier
Fix function signatures of pageinspect in documentation tuple_data_split() lacked the type of the first argument, and heap_page_item_attrs() has reversed the first and second argument, with the bytea argument using an incorrect name. Author: Laurenz Albe Discussion: https://postgr.es/m/8f9ab7b16

pgsql: Fix function signatures of pageinspect in documentation

2019-03-07 Thread Michael Paquier
Fix function signatures of pageinspect in documentation tuple_data_split() lacked the type of the first argument, and heap_page_item_attrs() has reversed the first and second argument, with the bytea argument using an incorrect name. Author: Laurenz Albe Discussion: https://postgr.es/m/8f9ab7b16