pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

2019-05-12 Thread Noah Misch
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages. The function had been interpreting SQL_ASCII messages as UTF8, throwing an error when they were invalid UTF8. The new behavior is consistent with pg_do_encoding_conversion(). This affects LOG_DESTINATION_STDERR and LOG_DESTINATION_EVENTLOG,

pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

2019-05-12 Thread Noah Misch
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages. The function had been interpreting SQL_ASCII messages as UTF8, throwing an error when they were invalid UTF8. The new behavior is consistent with pg_do_encoding_conversion(). This affects LOG_DESTINATION_STDERR and LOG_DESTINATION_EVENTLOG,

pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

2019-05-12 Thread Noah Misch
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages. The function had been interpreting SQL_ASCII messages as UTF8, throwing an error when they were invalid UTF8. The new behavior is consistent with pg_do_encoding_conversion(). This affects LOG_DESTINATION_STDERR and LOG_DESTINATION_EVENTLOG,

pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

2019-05-12 Thread Noah Misch
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages. The function had been interpreting SQL_ASCII messages as UTF8, throwing an error when they were invalid UTF8. The new behavior is consistent with pg_do_encoding_conversion(). This affects LOG_DESTINATION_STDERR and LOG_DESTINATION_EVENTLOG,

pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

2019-05-12 Thread Noah Misch
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages. The function had been interpreting SQL_ASCII messages as UTF8, throwing an error when they were invalid UTF8. The new behavior is consistent with pg_do_encoding_conversion(). This affects LOG_DESTINATION_STDERR and LOG_DESTINATION_EVENTLOG,

pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

2019-05-12 Thread Noah Misch
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages. The function had been interpreting SQL_ASCII messages as UTF8, throwing an error when they were invalid UTF8. The new behavior is consistent with pg_do_encoding_conversion(). This affects LOG_DESTINATION_STDERR and LOG_DESTINATION_EVENTLOG,

pgsql: Fix misoptimization of "{1, 1}" quantifiers in regular expression

2019-05-12 Thread Tom Lane
Fix misoptimization of "{1,1}" quantifiers in regular expressions. A bounded quantifier with m = n = 1 might be thought a no-op. But according to our documentation (which traces back to Henry Spencer's original man page) it still imposes greediness, or non-greediness in the case of the non-greedy

pgsql: Fix misoptimization of "{1, 1}" quantifiers in regular expression

2019-05-12 Thread Tom Lane
Fix misoptimization of "{1,1}" quantifiers in regular expressions. A bounded quantifier with m = n = 1 might be thought a no-op. But according to our documentation (which traces back to Henry Spencer's original man page) it still imposes greediness, or non-greediness in the case of the non-greedy

pgsql: Fix misoptimization of "{1, 1}" quantifiers in regular expression

2019-05-12 Thread Tom Lane
Fix misoptimization of "{1,1}" quantifiers in regular expressions. A bounded quantifier with m = n = 1 might be thought a no-op. But according to our documentation (which traces back to Henry Spencer's original man page) it still imposes greediness, or non-greediness in the case of the non-greedy

pgsql: Fix misoptimization of "{1, 1}" quantifiers in regular expression

2019-05-12 Thread Tom Lane
Fix misoptimization of "{1,1}" quantifiers in regular expressions. A bounded quantifier with m = n = 1 might be thought a no-op. But according to our documentation (which traces back to Henry Spencer's original man page) it still imposes greediness, or non-greediness in the case of the non-greedy

pgsql: Fix misoptimization of "{1, 1}" quantifiers in regular expression

2019-05-12 Thread Tom Lane
Fix misoptimization of "{1,1}" quantifiers in regular expressions. A bounded quantifier with m = n = 1 might be thought a no-op. But according to our documentation (which traces back to Henry Spencer's original man page) it still imposes greediness, or non-greediness in the case of the non-greedy

pgsql: Fix misoptimization of "{1, 1}" quantifiers in regular expression

2019-05-12 Thread Tom Lane
Fix misoptimization of "{1,1}" quantifiers in regular expressions. A bounded quantifier with m = n = 1 might be thought a no-op. But according to our documentation (which traces back to Henry Spencer's original man page) it still imposes greediness, or non-greediness in the case of the non-greedy

pgsql: Fix incorrect return value in JSON equality function for scalars

2019-05-12 Thread Michael Paquier
Fix incorrect return value in JSON equality function for scalars equalsJsonbScalarValue() uses a boolean as return type, however for one code path -1 gets returned, which is confusing. The origin of the confusion is visibly that this code got copy-pasted from compareJsonbScalarValue() since it ha

pgsql: docs: fix typo in mention of MSVC

2019-05-12 Thread Bruce Momjian
docs: fix typo in mention of MSVC Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fefb6a75386b72a40f697523953eafc7cb1c7a5b Modified Files -- doc/src/sgml/release-12.sgml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

pgsql: doc: adjust PG 12 release note sections

2019-05-12 Thread Bruce Momjian
doc: adjust PG 12 release note sections Tighten section designations. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a6927996be59ac329d65d41cf058d0b1b0978eeb Modified Files -- doc/src/sgml/release-12.sgml | 67 +++--

pgsql: doc: PG 12 release notes: normalize attribution names

2019-05-12 Thread Bruce Momjian
doc: PG 12 release notes: normalize attribution names Reported-by: David Rowley Discussion: https://postgr.es/m/cakjs1f-ktehmq2zjq1l1niuj9kb8wpa-be-ahgifsso6qas...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f86b0c3c465319b80d71db7d7a9de636950