pgsql: libpq: ccache -> credential cache

2019-09-06 Thread Peter Eisentraut
libpq: ccache -> credential cache The term "ccache" is overloaded. Let's be more clear, in case someone other than a Kerberos wizard has to read this code. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5599f40d259a275d3202b10aa6ffb9a36fd8a940 Modified Files

pgsql: libpq: ccache -> credential cache

2019-09-06 Thread Peter Eisentraut
libpq: ccache -> credential cache The term "ccache" is overloaded. Let's be more clear, in case someone other than a Kerberos wizard has to read this code. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d57a931a85dff67fb7447da5f252bb9a9ecbb6d9 Modified Fil

Re: pgsql: Fix compiler warning

2019-09-06 Thread Peter Eisentraut
On 2019-09-05 16:15, Tom Lane wrote: > Peter Eisentraut writes: >> The tree currently does not compile without warnings on Windows (for >> me), so it doesn't seem worth fixing warnings piece by piece in the >> backbranches. > > Hm, I see no warnings on e.g. dory. What are you seeing, and with >

Re: pgsql: Doc: remove some long-obsolete information from installation.sgm

2019-09-06 Thread Peter Eisentraut
On 2019-09-01 23:34, Tom Lane wrote: > Peter Eisentraut writes: >>> Doc: remove some long-obsolete information from installation.sgml. > >> - It is a fully native build and uses no additional software like >> - MinGW. A ready-made installer is available on the main >> - PostgreSQL web site. >> +

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

pgsql: When performing a base backup, check for read errors.

2019-09-06 Thread Robert Haas
When performing a base backup, check for read errors. The old code didn't differentiate between a read error and a concurrent truncation. fread reports both of these by returning 0; you have to use feof() or ferror() to distinguish between them, which this code did not do. It might be a better id

Re: pgsql: Doc: remove some long-obsolete information from installation.sgm

2019-09-06 Thread Tom Lane
Peter Eisentraut writes: > On 2019-09-01 23:34, Tom Lane wrote: >> So did the old wording, it seemed to me. I'm happy to remove the sentence >> altogether if there's no reason to be pushing people away from MinGW. >> Should we also rethink the sentence I added at the top of the chapter, >> pointi

Re: pgsql: Doc: remove some long-obsolete information from installation.sgm

2019-09-06 Thread Tom Lane
Peter Eisentraut writes: > Yeah, I suggest this: > - Also, this chapter does not describe the preferred way to install > - PostgreSQL on Microsoft > - Windows (for that, see > - ). Also, I don't especially agree with removing that entirely: people should not have to read to near the end of t

Re: pgsql: Doc: remove some long-obsolete information from installation.sgm

2019-09-06 Thread Peter Eisentraut
On 2019-09-06 15:28, Tom Lane wrote: > Peter Eisentraut writes: >> On 2019-09-01 23:34, Tom Lane wrote: >>> So did the old wording, it seemed to me. I'm happy to remove the sentence >>> altogether if there's no reason to be pushing people away from MinGW. >>> Should we also rethink the sentence I

Re: pgsql: Doc: remove some long-obsolete information from installation.sgm

2019-09-06 Thread Peter Eisentraut
On 2019-09-06 15:37, Tom Lane wrote: > Peter Eisentraut writes: >> Yeah, I suggest this: > >> - Also, this chapter does not describe the preferred way to install >> - PostgreSQL on Microsoft >> - Windows (for that, see >> - ). > > Also, I don't especially agree with removing that entirely: p

pgsql: Create an API for inserting and deleting rows in TOAST tables.

2019-09-06 Thread Robert Haas
Create an API for inserting and deleting rows in TOAST tables. This moves much of the non-heap-specific logic from toast_delete and toast_insert_or_update into a helper functions accessible via a new header, toast_helper.h. Using the functions in this module, a table AM can implement creation and

Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-06 Thread Andrew Dunstan
On 9/5/19 1:32 PM, Tom Lane wrote: > Use data directory inode number, not port, to select SysV resource keys. > > This approach provides a much tighter binding between a data directory > and the associated SysV shared memory block (and SysV or named-POSIX > semaphores, if we're using those). Key

pgsql: Doc: tweak installation doc edits made by commit 76c2af926.

2019-09-06 Thread Tom Lane
Doc: tweak installation doc edits made by commit 76c2af926. We don't consider that building with MinGW is deprecated, so adjust some places that gave that impression. Per discussion with Peter Eisentraut. Discussion: https://postgr.es/m/[email protected] Branc

Re: pgsql: Doc: remove some long-obsolete information from installation.sgm

2019-09-06 Thread Tom Lane
Peter Eisentraut writes: > On 2019-09-06 15:37, Tom Lane wrote: >> Also, I don't especially agree with removing that entirely: people should >> not have to read to near the end of the chapter to discover that they >> should have been reading some other chapter. How about something like >> "If you

Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-06 Thread Tom Lane
Andrew Dunstan writes: > On 9/5/19 1:32 PM, Tom Lane wrote: >> Use data directory inode number, not port, to select SysV resource keys. > This has caused the 017_shm.pl tests to be skipped on jacana and > bowerbird, and to fail completely on my msys2 test system where the Perl > has the relevant

pgsql: Doc: tweak installation doc edits made by commit 76c2af926.

2019-09-06 Thread Tom Lane
Doc: tweak installation doc edits made by commit 76c2af926. We don't consider that building with MinGW is deprecated, so adjust some places that gave that impression. Per discussion with Peter Eisentraut. Discussion: https://postgr.es/m/[email protected] Branc

Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-06 Thread Andrew Dunstan
On 9/6/19 11:35 AM, Tom Lane wrote: > Andrew Dunstan writes: >> On 9/5/19 1:32 PM, Tom Lane wrote: >>> Use data directory inode number, not port, to select SysV resource keys. >> This has caused the 017_shm.pl tests to be skipped on jacana and >> bowerbird, and to fail completely on my msys2 tes

Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-06 Thread Tom Lane
Andrew Dunstan writes: > Given your stated intention, I think the simplest way to get it is just > this, without worrying about what the perl modules might do: > -if ($@) > +if ($@ || $windows_os) WFM, do you want to push that? regards, tom lane

pgsql: Update v12 release notes through today, and add major-enhancemen

2019-09-06 Thread Tom Lane
Update v12 release notes through today, and add major-enhancements list. I still want to review the rest of the notes, but this seems like the minimum work required to prepare for beta4. Major-enhancements text, and a couple of other fixes, from Jonathan Katz (with minor copy-editing by me). Bra

pgsql: Always skip recovery SysV shared memory tests on Windows

2019-09-06 Thread Andrew Dunstan
Always skip recovery SysV shared memory tests on Windows The test for SysV support currently involves looking for the perl modules IPC::SharedMem and IPC::SysV. However, the perl on msys2 has these modules but the tests fail. Therefore, force skipping the tests on Windows platforms unconditionally

Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-06 Thread Andrew Dunstan
On 9/6/19 2:42 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Given your stated intention, I think the simplest way to get it is just >> this, without worrying about what the perl modules might do: >> -if ($@) >> +if ($@ || $windows_os) > WFM, do you want to push that? > >

pgsql: doc: Fix awkward markup

2019-09-06 Thread Peter Eisentraut
doc: Fix awkward markup Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0bea801c8176d14b7e22bc160cb96e6cf6650d61 Modified Files -- doc/src/sgml/ref/pg_dumpall.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: doc: Fix awkward markup

2019-09-06 Thread Peter Eisentraut
doc: Fix awkward markup Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/021da890bcc129a9a1a4d996304cf437553f0937 Modified Files -- doc/src/sgml/ref/pg_dumpall.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: doc: Fix awkward markup

2019-09-06 Thread Peter Eisentraut
doc: Fix awkward markup Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7babff18dc26506d4a05f75283ae621d3b8a1950 Modified Files -- doc/src/sgml/ref/pg_dumpall.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: doc: Fix awkward markup

2019-09-06 Thread Peter Eisentraut
doc: Fix awkward markup Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7db45167ccf502f92ee6bf5ce8a2b8f0b2441128 Modified Files -- doc/src/sgml/ref/pg_dumpall.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: doc: Fix awkward markup

2019-09-06 Thread Peter Eisentraut
doc: Fix awkward markup Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ce35a265a438813cd337307b6997a58ac87bf9c9 Modified Files -- doc/src/sgml/ref/pg_dumpall.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: doc: Postgres -> PostgreSQL

2019-09-06 Thread Peter Eisentraut
doc: Postgres -> PostgreSQL Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c57dbc19896cb5a15e53099765c64517afdbab14 Modified Files -- doc/src/sgml/bki.sgml | 2 +- doc/src/sgml/installation.sgml | 2 +- 2 files changed, 2 insertions(+), 2 deletio

pgsql: doc: Postgres -> PostgreSQL

2019-09-06 Thread Peter Eisentraut
doc: Postgres -> PostgreSQL Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/69116b743af01bd0ab87b5dfc7395029002e23a1 Modified Files -- doc/src/sgml/bki.sgml | 2 +- doc/src/sgml/installation.sgml | 2 +- 2 files changed, 2 insertions(+), 2

pgsql: doc: Fix awkward markup

2019-09-06 Thread Peter Eisentraut
doc: Fix awkward markup Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3f68d138747734fff094861419c7cc6824c54db6 Modified Files -- doc/src/sgml/ref/pg_dumpall.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: doc: Fix awkward markup

2019-09-06 Thread Peter Eisentraut
doc: Fix awkward markup Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/603a53431fd1d272f331c609f62264831fd679c1 Modified Files -- doc/src/sgml/ref/pg_dumpall.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgsql: Message style fixes

2019-09-06 Thread Peter Eisentraut
Message style fixes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c5bc7050aff1d1bba6532377fe37b351581661a8 Modified Files -- src/bin/psql/command.c | 2 +- src/bin/psql/help.c | 2 +- src/i

pgsql: Message style fixes

2019-09-06 Thread Peter Eisentraut
Message style fixes Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2552c78c18a1cb11d0f49a3af0660a477f81839d Modified Files -- src/bin/psql/command.c | 2 +- src/bin/psql/help.c | 2 +