pgsql: Improve new AND CHAIN tests

2019-09-09 Thread Peter Eisentraut
Improve new AND CHAIN tests Tweak the tests so that we're not just testing the default setting of transaction_read_only. Reported-by: fn ln Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/89b160c32045dd85cc6f9ae6248e34a72931ac67 Modified Files -- src/

pgsql: Improve new AND CHAIN tests

2019-09-09 Thread Peter Eisentraut
Improve new AND CHAIN tests Tweak the tests so that we're not just testing the default setting of transaction_read_only. Reported-by: fn ln Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ef48a0573bf0fc5c7e23f077788a055aad9f5e9e Modified Files

pgsql: Translation updates

2019-09-09 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 2808de890d4be52a0a82fb3bd84ea7998c6f5101 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/55a808c1a899380bff3340ed8d896d06f0b19f9b Modified Files --

pgsql: Fix handling of non-key columns get_index_column_opclass()

2019-09-09 Thread Alexander Korotkov
Fix handling of non-key columns get_index_column_opclass() f2e40380 introduces support of non-key attributes in GiST indexes. Then if get_index_column_opclass() is asked by gistproperty() to get an opclass of non-key column, it returns garbage past oidvector value. This commit fixes that by maki

pgsql: Fix handling of non-key columns get_index_column_opclass()

2019-09-09 Thread Alexander Korotkov
Fix handling of non-key columns get_index_column_opclass() f2e40380 introduces support of non-key attributes in GiST indexes. Then if get_index_column_opclass() is asked by gistproperty() to get an opclass of non-key column, it returns garbage past oidvector value. This commit fixes that by maki

pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Andres Freund
Reorder EPQ work, to fix rowmark related bugs and improve efficiency. In ad0bda5d24ea I changed the EvalPlanQual machinery to store substitution tuples in slot, instead of using plain HeapTuples. The main motivation for that was that using HeapTuples will be inefficient for future tableams. But i

pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Andres Freund
Reorder EPQ work, to fix rowmark related bugs and improve efficiency. In ad0bda5d24ea I changed the EvalPlanQual machinery to store substitution tuples in slot, instead of using plain HeapTuples. The main motivation for that was that using HeapTuples will be inefficient for future tableams. But i

pgsql: Always skip recovery SysV shared memory tests on Windows

2019-09-09 Thread Andrew Dunstan
Always skip recovery SysV shared memory tests on Windows These tests were disabled on git master in commit 8e5ce1c3f8. This does the same thing on the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details ---

pgsql: Always skip recovery SysV shared memory tests on Windows

2019-09-09 Thread Andrew Dunstan
Always skip recovery SysV shared memory tests on Windows These tests were disabled on git master in commit 8e5ce1c3f8. This does the same thing on the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details ---

pgsql: Always skip recovery SysV shared memory tests on Windows

2019-09-09 Thread Andrew Dunstan
Always skip recovery SysV shared memory tests on Windows These tests were disabled on git master in commit 8e5ce1c3f8. This does the same thing on the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details ---

pgsql: Always skip recovery SysV shared memory tests on Windows

2019-09-09 Thread Andrew Dunstan
Always skip recovery SysV shared memory tests on Windows These tests were disabled on git master in commit 8e5ce1c3f8. This does the same thing on the back branches. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details ---

pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path

2019-09-09 Thread Andrew Dunstan
Prevent msys2 conversion of "cmd /c" switch to a file path Modern versions of msys2 have changed the treatment of "cmd /c" so that the runtime will try to convert the switch to a native file path. This patch adds a setting to inhibit that behaviour. Discussion: https://postgr.es/m/3227042f-cfcc-

pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path

2019-09-09 Thread Andrew Dunstan
Prevent msys2 conversion of "cmd /c" switch to a file path Modern versions of msys2 have changed the treatment of "cmd /c" so that the runtime will try to convert the switch to a native file path. This patch adds a setting to inhibit that behaviour. Discussion: https://postgr.es/m/3227042f-cfcc-

pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path

2019-09-09 Thread Andrew Dunstan
Prevent msys2 conversion of "cmd /c" switch to a file path Modern versions of msys2 have changed the treatment of "cmd /c" so that the runtime will try to convert the switch to a native file path. This patch adds a setting to inhibit that behaviour. Discussion: https://postgr.es/m/3227042f-cfcc-

pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path

2019-09-09 Thread Andrew Dunstan
Prevent msys2 conversion of "cmd /c" switch to a file path Modern versions of msys2 have changed the treatment of "cmd /c" so that the runtime will try to convert the switch to a native file path. This patch adds a setting to inhibit that behaviour. Discussion: https://postgr.es/m/3227042f-cfcc-

pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path

2019-09-09 Thread Andrew Dunstan
Prevent msys2 conversion of "cmd /c" switch to a file path Modern versions of msys2 have changed the treatment of "cmd /c" so that the runtime will try to convert the switch to a native file path. This patch adds a setting to inhibit that behaviour. Discussion: https://postgr.es/m/3227042f-cfcc-

pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path

2019-09-09 Thread Andrew Dunstan
Prevent msys2 conversion of "cmd /c" switch to a file path Modern versions of msys2 have changed the treatment of "cmd /c" so that the runtime will try to convert the switch to a native file path. This patch adds a setting to inhibit that behaviour. Discussion: https://postgr.es/m/3227042f-cfcc-

pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path

2019-09-09 Thread Andrew Dunstan
Prevent msys2 conversion of "cmd /c" switch to a file path Modern versions of msys2 have changed the treatment of "cmd /c" so that the runtime will try to convert the switch to a native file path. This patch adds a setting to inhibit that behaviour. Discussion: https://postgr.es/m/3227042f-cfcc-

pgsql: Be more careful about port selection in src/test/ldap/.

2019-09-09 Thread Tom Lane
Be more careful about port selection in src/test/ldap/. Don't just assume that the next port is free; it might not be, or if we're really unlucky it might even be out of the TCP range. Do it honestly with two get_free_port() calls instead. This is surely a pretty low-probability problem, but I th

pgsql: Be more careful about port selection in src/test/ldap/.

2019-09-09 Thread Tom Lane
Be more careful about port selection in src/test/ldap/. Don't just assume that the next port is free; it might not be, or if we're really unlucky it might even be out of the TCP range. Do it honestly with two get_free_port() calls instead. This is surely a pretty low-probability problem, but I th

pgsql: Be more careful about port selection in src/test/ldap/.

2019-09-09 Thread Tom Lane
Be more careful about port selection in src/test/ldap/. Don't just assume that the next port is free; it might not be, or if we're really unlucky it might even be out of the TCP range. Do it honestly with two get_free_port() calls instead. This is surely a pretty low-probability problem, but I th

pgsql: Add _bt_binsrch() scantid assertion to nbtree.

2019-09-09 Thread Peter Geoghegan
Add _bt_binsrch() scantid assertion to nbtree. Assert that _bt_binsrch() binary searches with scantid set in insertion scankey cannot be performed on leaf pages. Leaf-level binary searches where scantid is set must use _bt_binsrch_insert() instead. _bt_binsrch_insert() is likely to have addition

pgsql: Stamp 12beta4.

2019-09-09 Thread Tom Lane
Stamp 12beta4. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/84bb33c4804ea26b3f23df875701731bd01d3f0a Modified Files -- configure | 18 +- configure.in | 2 +- src/include/pg_config.h.win32 |

Re: pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Thomas Munro
On Tue, Sep 10, 2019 at 12:32 AM Andres Freund wrote: > Reorder EPQ work, to fix rowmark related bugs and improve efficiency. Did this cause the following failure in eval-plan-qual on REL_12_STABLE? https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2019-09-09%2019%3A08%3A41

Re: pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Andres Freund
Hi, On September 9, 2019 10:51:26 PM GMT+01:00, Thomas Munro wrote: >On Tue, Sep 10, 2019 at 12:32 AM Andres Freund >wrote: >> Reorder EPQ work, to fix rowmark related bugs and improve efficiency. > >Did this cause the following failure in eval-plan-qual on >REL_12_STABLE? > >https://buildfarm.

Re: pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Tom Lane
Andres Freund writes: > On September 9, 2019 10:51:26 PM GMT+01:00, Thomas Munro > wrote: >> On Tue, Sep 10, 2019 at 12:32 AM Andres Freund >> Did this cause the following failure in eval-plan-qual on >> REL_12_STABLE? >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=201

Re: pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Andres Freund
Hi, On September 9, 2019 11:01:28 PM GMT+01:00, Tom Lane wrote: >Andres Freund writes: >> On September 9, 2019 10:51:26 PM GMT+01:00, Thomas Munro > wrote: >>> On Tue, Sep 10, 2019 at 12:32 AM Andres Freund >>> Did this cause the following failure in eval-plan-qual on >>> REL_12_STABLE? >>> >ht

Re: pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Tom Lane
Andres Freund writes: > On September 9, 2019 11:01:28 PM GMT+01:00, Tom Lane > wrote: >> I think the first question is why is only prairiedog showing this. > We only saw the similar failure on master on a very small number of machines > as well. Given The somewhat unusual way packets have to g

Re: pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Alvaro Herrera
On 2019-Sep-09, Tom Lane wrote: > As for that, now that we realize that this applies to more than > just NOTICEs, I think we should back-patch the code change in > 30717637c at least to v11, maybe all the way. I don't see any > WARNINGs in the isolation expected files before v11, but it > hardly

Re: pgsql: Reorder EPQ work, to fix rowmark related bugs and improve effici

2019-09-09 Thread Tom Lane
Alvaro Herrera writes: > On 2019-Sep-09, Tom Lane wrote: >> It appears to me that this is indeed a case of notice-reporting >> timing problems in isolationtester, since these WARNING messages >> are handled the same way as notices. I want to try to reproduce >> manually on prairiedog to confirm t

pgsql: Fix isolationtester race condition for notices sent before block

2019-09-09 Thread Tom Lane
Fix isolationtester race condition for notices sent before blocking. If a test sends a notice just before blocking, it's possible on slow machines for isolationtester to detect the blocked state before it's consumed the notice. (For this to happen, the notice would have to arrive after isolationt