pgsql: doc: Add timeline as valid recovery target in standby.signal doc

2019-09-27 Thread Peter Eisentraut
doc: Add timeline as valid recovery target in standby.signal documentation The documentation states that no target settings will be used when standby.signal is present, but this is not quite the case since recovery_target_timeline is a valid recovery target for a standby. Update the documentation

pgsql: doc: Add timeline as valid recovery target in standby.signal doc

2019-09-27 Thread Peter Eisentraut
doc: Add timeline as valid recovery target in standby.signal documentation The documentation states that no target settings will be used when standby.signal is present, but this is not quite the case since recovery_target_timeline is a valid recovery target for a standby. Update the documentation

pgsql: Doc: clean up markup for jsonb_set and related functions.

2019-09-27 Thread Tom Lane
Doc: clean up markup for jsonb_set and related functions. The markup for optional parameters was neither correct nor consistent. In passing, fix a spelling mistake. Per report from Alex Macy. Some of these mistakes are old, so back-patch as appropriate. Discussion: https://postgr.es/m/15695352

pgsql: Doc: clean up markup for jsonb_set and related functions.

2019-09-27 Thread Tom Lane
Doc: clean up markup for jsonb_set and related functions. The markup for optional parameters was neither correct nor consistent. In passing, fix a spelling mistake. Per report from Alex Macy. Some of these mistakes are old, so back-patch as appropriate. Discussion: https://postgr.es/m/15695352

pgsql: Doc: clean up markup for jsonb_set and related functions.

2019-09-27 Thread Tom Lane
Doc: clean up markup for jsonb_set and related functions. The markup for optional parameters was neither correct nor consistent. In passing, fix a spelling mistake. Per report from Alex Macy. Some of these mistakes are old, so back-patch as appropriate. Discussion: https://postgr.es/m/15695352

pgsql: Doc: clean up markup for jsonb_set and related functions.

2019-09-27 Thread Tom Lane
Doc: clean up markup for jsonb_set and related functions. The markup for optional parameters was neither correct nor consistent. In passing, fix a spelling mistake. Per report from Alex Macy. Some of these mistakes are old, so back-patch as appropriate. Discussion: https://postgr.es/m/15695352

pgsql: Doc: clean up markup for jsonb_set and related functions.

2019-09-27 Thread Tom Lane
Doc: clean up markup for jsonb_set and related functions. The markup for optional parameters was neither correct nor consistent. In passing, fix a spelling mistake. Per report from Alex Macy. Some of these mistakes are old, so back-patch as appropriate. Discussion: https://postgr.es/m/15695352

pgsql: Doc: clean up markup for jsonb_set and related functions.

2019-09-27 Thread Tom Lane
Doc: clean up markup for jsonb_set and related functions. The markup for optional parameters was neither correct nor consistent. In passing, fix a spelling mistake. Per report from Alex Macy. Some of these mistakes are old, so back-patch as appropriate. Discussion: https://postgr.es/m/15695352

pgsql: ANALYZE a_star and its children to avoid plan instability in tes

2019-09-27 Thread Tom Lane
ANALYZE a_star and its children to avoid plan instability in tests. We've noted certain EXPLAIN queries on these tables occasionally showing unexpected plan choices. This seems to happen because VACUUM sometimes fails to update relpages/reltuples for one of these single-page tables, due to bgwrit

pgsql: Finish reverting "Insert temporary debugging output in regressio

2019-09-27 Thread Tom Lane
Finish reverting "Insert temporary debugging output in regression tests." This removes the last of the temporary debugging queries added to the regression tests by commit f03a9ca43. We've pretty much convinced ourselves that the plan instability we were seeing is due to VACUUM sometimes failing t

pgsql: ANALYZE a_star and its children to avoid plan instability in tes

2019-09-27 Thread Tom Lane
ANALYZE a_star and its children to avoid plan instability in tests. We've noted certain EXPLAIN queries on these tables occasionally showing unexpected plan choices. This seems to happen because VACUUM sometimes fails to update relpages/reltuples for one of these single-page tables, due to bgwrit

Re: pgsql: Implement jsonpath .datetime() method

2019-09-27 Thread Nikita Glukhov
On Thu, Sep 26, 2019 at 2:57 AM Tom Lane wrote: Alexander Korotkov writes: > On Thu, Sep 26, 2019 at 2:12 AM Tom Lane wrote: >> The proximate problem seems to be that compareItems() is insufficiently >> careful to ensure that both values are non-null before passing them >> off to datatype-sp

pgsql: Fix implicit-fallthrough compiler warning introduced in 6dda292d

2019-09-27 Thread Andres Freund
Fix implicit-fallthrough compiler warning introduced in 6dda292d4df82. For some reason at least gcc-9 warns about the fallthrough, even though it otherwise recognizes that elog(ERROR, ...) doesn't return. Author: Andres Freund Branch -- master Details --- https://git.postgresql.org/pg/c

pgsql: Have pg_rewind run crash recovery before rewinding

2019-09-27 Thread Alvaro Herrera
Have pg_rewind run crash recovery before rewinding If we don't do this, the rewind fails if the server wasn't cleanly shut down, which seems unhelpful serving no purpose. Also provide a new option --no-ensure-shutdown to suppress this behavior, for alleged advanced usage that prefers to avoid the

pgsql: Silence -Wmaybe-uninitialized compiler warnings in dbcommands.c.

2019-09-27 Thread Andres Freund
Silence -Wmaybe-uninitialized compiler warnings in dbcommands.c. When compiling postgres using gcc -O3, there are false-positive warnings about the now initialized variables. Silence them. Author: Peter Eisentraut, Andres Freund Discussion: https://postgr.es/m/15fb2350-b8b8-e188-278f-0b34fdee5..

Re: [COMMITTERS] pgsql: Establish conventions about global object names used in regressi

2019-09-27 Thread Andres Freund
Hi, On 2019-09-21 23:45:34 -0700, Peter Geoghegan wrote: > On Sat, Sep 21, 2019 at 11:36 PM Tom Lane wrote: > > Hm. So ... how come the buildfarm hasn't been red for the last three > > years? We need to figure out what you're doing that's different. > > I'll try to debug the problem soon. > >

pgsql: Make pg_regress.c unset PGDATABASE during make installcheck.

2019-09-27 Thread Tom Lane
Make pg_regress.c unset PGDATABASE during make installcheck. For the most part, we leave libpq-controlling environment variables alone during "make installcheck", reasoning that connecting to the server the user expects us to connect to may depend on those variables. But that argument doesn't appl

Re: pgsql: Test pg_atomic_fetch_add_ with variable addend and 16-bit edge c

2019-09-27 Thread Noah Misch
On Sun, Sep 15, 2019 at 09:47:52PM -0700, Andres Freund wrote: > On 2019-09-15 15:14:50 -0700, Noah Misch wrote: > > --- a/src/test/regress/regress.c > > +++ b/src/test/regress/regress.c > > @@ -670,6 +670,16 @@ test_atomic_flag(void) > > pg_atomic_clear_flag(&flag); > > } > > > > +#define E

pgsql: Remove code relevant to OpenSSL 0.9.6 in be/fe-secure-openssl.c

2019-09-27 Thread Michael Paquier
Remove code relevant to OpenSSL 0.9.6 in be/fe-secure-openssl.c HEAD supports OpenSSL 0.9.8 and newer versions, and this code likely got forgotten as its surrounding comments mention an incorrect version number. Author: Michael Paquier Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m