pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

2019-11-08 Thread Etsuro Fujita
postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remo

pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

2019-11-08 Thread Etsuro Fujita
postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remo

pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

2019-11-08 Thread Etsuro Fujita
postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remo

pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

2019-11-08 Thread Etsuro Fujita
postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remo

pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

2019-11-08 Thread Etsuro Fujita
postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remo

pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

2019-11-08 Thread Etsuro Fujita
postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remo

pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

2019-11-08 Thread Etsuro Fujita
postgres_fdw: Fix error message for PREPARE TRANSACTION. Currently, postgres_fdw does not support preparing a remote transaction for two-phase commit even in the case where the remote transaction is read-only, but the old error message appeared to imply that that was not supported only if the remo

pgsql: Fix gratuitous error message variation

2019-11-08 Thread Peter Eisentraut
Fix gratuitous error message variation Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b34946f9a1d2743a485117cc069432d82907e265 Modified Files -- src/backend/replication/logical/origin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix gratuitous error message variation

2019-11-08 Thread Peter Eisentraut
Fix gratuitous error message variation Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4cc66a2a4afca89208317928ec0c8721a999bb7d Modified Files -- src/backend/replication/logical/origin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix gratuitous error message variation

2019-11-08 Thread Peter Eisentraut
Fix gratuitous error message variation Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/64b62b7b9b8566a0b92986ce26de84101820b556 Modified Files -- src/backend/replication/logical/origin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix gratuitous error message variation

2019-11-08 Thread Peter Eisentraut
Fix gratuitous error message variation Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a9c3cda2816ffef76a6f49cc7ba14233e8d9cad1 Modified Files -- src/backend/replication/logical/origin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix gratuitous error message variation

2019-11-08 Thread Peter Eisentraut
Fix gratuitous error message variation Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3dcffb381c81c9c8f8254100feacac256b9e75a6 Modified Files -- src/backend/replication/logical/origin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix gratuitous error message variation

2019-11-08 Thread Peter Eisentraut
Fix gratuitous error message variation Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c125bc8995dfdf905ba146550a14867a17982425 Modified Files -- src/backend/replication/logical/origin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Add backtrace support for error reporting

2019-11-08 Thread Alvaro Herrera
Add backtrace support for error reporting Add some support for automatically showing backtraces in certain error situations in the server. Backtraces are shown on assertion failure; also, a new setting backtrace_functions can be set to a list of C function names, and all ereport()s and elog()s fr

pgsql: Pass ItemPointer not HeapTuple to IndexBuildCallback.

2019-11-08 Thread Andres Freund
Pass ItemPointer not HeapTuple to IndexBuildCallback. Not all AMs use HeapTuples internally, making it inconvenient to pass a HeapTuple. As the index callbacks really only need the TID, not the full tuple, modify callback to only take ItemPointer. Author: Ashwin Agrawal Reviewed-By: Andres Freund

Re: pgsql: Add backtrace support for error reporting

2019-11-08 Thread Amit Langote
On Sat, Nov 9, 2019 at 3:52 Alvaro Herrera wrote: > Add backtrace support for error reporting Yay, thanks! - Amit

pgsql: First-draft release notes for 12.1.

2019-11-08 Thread Tom Lane
First-draft release notes for 12.1. As usual, the release notes for other branches will be made by cutting these down, but put them up for community review first. Note that a fair percentage of the entries apply only to prior branches because their issue was already fixed in 12.0. I'll remove th

Re: pgsql: Fix gratuitous error message variation

2019-11-08 Thread Tom Lane
Peter Eisentraut writes: > Fix gratuitous error message variation Hm, as long as you're touching that ... OIDs should be formatted with %u not %d. regards, tom lane

pgsql: Add tests for COPY in PL/pgSQL

2019-11-08 Thread Michael Paquier
Add tests for COPY in PL/pgSQL This stresses the error handling of COPY inside SPI which does not support the operation using stdin or stdout, and these scenarios were not tested up to now. Author: Mark Dilger Discussion: https://postgr.es/m/[email protected] Branch

pgsql: Fix new COPY test of PL/pgSQL with VPATH builds

2019-11-08 Thread Michael Paquier
Fix new COPY test of PL/pgSQL with VPATH builds The buildfarm has turned red after 1858b10 because VPATH builds need to use "@abs_srcdir@" and not "@abs_builddir@" for paths coming directly from the source tree. The input file of the new test got that right, but not the output file. Per complain