pgsql: Improve tab-completion for ALTER MATERIALIZED VIEW.

2019-11-21 Thread Fujii Masao
Improve tab-completion for ALTER MATERIALIZED VIEW. Author: Takao Fujii Reviewed-by: Fujii Masao Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/61a956d9cca3f72acb279c9c00f1d9cd47bbc934

pgsql: Allow ALTER VIEW command to rename the column in the view.

2019-11-21 Thread Fujii Masao
Allow ALTER VIEW command to rename the column in the view. ALTER TABLE RENAME COLUMN command always can be used to rename the column in the view, but it's reasonable to add that syntax to ALTER VIEW too. Author: Fujii Masao Reviewed-by: Ibrar Ahmed, Yu Kimura Discussion: https://postgr.es/m/cahg

pgsql: Make DROP DATABASE command generate less WAL records.

2019-11-21 Thread Fujii Masao
Make DROP DATABASE command generate less WAL records. Previously DROP DATABASE generated as many XLOG_DBASE_DROP WAL records as the number of tablespaces that the database to drop uses. This caused the scans of shared_buffers as many times as the number of the tablespaces during recovery because W

Re: pgsql: Make DROP DATABASE command generate less WAL records.

2019-11-21 Thread Michael Paquier
On Thu, Nov 21, 2019 at 12:11:58PM +, Fujii Masao wrote: > Make DROP DATABASE command generate less WAL records. > > Previously DROP DATABASE generated as many XLOG_DBASE_DROP WAL records > as the number of tablespaces that the database to drop uses. This caused > the scans of shared_buffers a

Re: pgsql: Make DROP DATABASE command generate less WAL records.

2019-11-21 Thread Fujii Masao
On Thu, Nov 21, 2019 at 9:17 PM Michael Paquier wrote: > > On Thu, Nov 21, 2019 at 12:11:58PM +, Fujii Masao wrote: > > Make DROP DATABASE command generate less WAL records. > > > > Previously DROP DATABASE generated as many XLOG_DBASE_DROP WAL records > > as the number of tablespaces that the

pgsql: Bump WAL version.

2019-11-21 Thread Fujii Masao
Bump WAL version. Oversight in commit e6d8069522. Since that commit changed the format of XLOG_DBASE_DROP WAL record, XLOG_PAGE_MAGIC needs to be bumped. Spotted by Michael Paquier Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/43a54a3bccd7dc6be798475214d561f3e93b

pgsql: Remove configure --disable-float4-byval

2019-11-21 Thread Peter Eisentraut
Remove configure --disable-float4-byval This build option was only useful to maintain compatibility for version-0 functions, but those are no longer supported, so this option can be removed. float4 is now always pass-by-value; the pass-by-reference code path is completely removed. Discussion: h

pgsql: Defend against self-referential views in relation_is_updatable()

2019-11-21 Thread Tom Lane
Defend against self-referential views in relation_is_updatable(). While a self-referential view doesn't actually work, it's possible to create one, and it turns out that this breaks some of the information_schema views. Those views call relation_is_updatable(), which neglected to consider the haz

pgsql: Defend against self-referential views in relation_is_updatable()

2019-11-21 Thread Tom Lane
Defend against self-referential views in relation_is_updatable(). While a self-referential view doesn't actually work, it's possible to create one, and it turns out that this breaks some of the information_schema views. Those views call relation_is_updatable(), which neglected to consider the haz

pgsql: Defend against self-referential views in relation_is_updatable()

2019-11-21 Thread Tom Lane
Defend against self-referential views in relation_is_updatable(). While a self-referential view doesn't actually work, it's possible to create one, and it turns out that this breaks some of the information_schema views. Those views call relation_is_updatable(), which neglected to consider the haz

pgsql: Defend against self-referential views in relation_is_updatable()

2019-11-21 Thread Tom Lane
Defend against self-referential views in relation_is_updatable(). While a self-referential view doesn't actually work, it's possible to create one, and it turns out that this breaks some of the information_schema views. Those views call relation_is_updatable(), which neglected to consider the haz

pgsql: Defend against self-referential views in relation_is_updatable()

2019-11-21 Thread Tom Lane
Defend against self-referential views in relation_is_updatable(). While a self-referential view doesn't actually work, it's possible to create one, and it turns out that this breaks some of the information_schema views. Those views call relation_is_updatable(), which neglected to consider the haz

pgsql: Defend against self-referential views in relation_is_updatable()

2019-11-21 Thread Tom Lane
Defend against self-referential views in relation_is_updatable(). While a self-referential view doesn't actually work, it's possible to create one, and it turns out that this breaks some of the information_schema views. Those views call relation_is_updatable(), which neglected to consider the haz

pgsql: Defend against self-referential views in relation_is_updatable()

2019-11-21 Thread Tom Lane
Defend against self-referential views in relation_is_updatable(). While a self-referential view doesn't actually work, it's possible to create one, and it turns out that this breaks some of the information_schema views. Those views call relation_is_updatable(), which neglected to consider the haz