pgsql: Store the deletion horizon XID for a deleted GIN page on the rig

2020-02-09 Thread Tom Lane
Store the deletion horizon XID for a deleted GIN page on the right page. Commit b10714080 moved the GinPageSetDeleteXid() call to a spot where the "page" variable was pointing to the wrong page, causing the XID to be inserted on a page that's not being deleted, thus allowing later GinPageIsRecycla

pgsql: Store the deletion horizon XID for a deleted GIN page on the rig

2020-02-09 Thread Tom Lane
Store the deletion horizon XID for a deleted GIN page on the right page. Commit b10714080 moved the GinPageSetDeleteXid() call to a spot where the "page" variable was pointing to the wrong page, causing the XID to be inserted on a page that's not being deleted, thus allowing later GinPageIsRecycla

pgsql: Store the deletion horizon XID for a deleted GIN page on the rig

2020-02-09 Thread Tom Lane
Store the deletion horizon XID for a deleted GIN page on the right page. Commit b10714080 moved the GinPageSetDeleteXid() call to a spot where the "page" variable was pointing to the wrong page, causing the XID to be inserted on a page that's not being deleted, thus allowing later GinPageIsRecycla

Re: pgsql: Fix page modification outside of critical section in GIN

2020-02-09 Thread Tom Lane
I wrote: > Alexander Korotkov writes: >> Fix page modification outside of critical section in GIN > I happened to notice, while reviewing stuff for the release notes, > that this patch does not do what the commit message says. The > previous code modified the pd_prune_xid of the "dBuffer" page,

pgsql: Revert "docs: change "default role" wording to "predefined role"

2020-02-09 Thread Tom Lane
Revert "docs: change "default role" wording to "predefined role"" This reverts commit 90d553dd96106ab278550e85d95a5663d77d7db7. Per discussion, we can't change the section title without some web-site work, so revert this change temporarily. Discussion: https://postgr.es/m/157742545062.1149.1105

pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.

2020-02-09 Thread Tom Lane
Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0522d6f8f0d08b17f55b1e93e4a67e5f82e6bdaf Modified Files -- doc/src/sgml/release-12.sgml | 42 +++--- 1

pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.

2020-02-09 Thread Tom Lane
Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/02836497c91b215266422b99809055267c263e57 Modified Files -- doc/src/sgml/release-9.6.sgml | 705 ++

pgsql: Revert "docs: change "default role" wording to "predefined role"

2020-02-09 Thread Tom Lane
Revert "docs: change "default role" wording to "predefined role"" This reverts commit 0e936a2148472e6c364aee8c3e298dc16dc4240a. Per discussion, we can't change the section title without some web-site work, so revert this change temporarily. Discussion: https://postgr.es/m/157742545062.1149.1105

pgsql: Revert "docs: change "default role" wording to "predefined role"

2020-02-09 Thread Tom Lane
Revert "docs: change "default role" wording to "predefined role"" This reverts commit 29af9c542f6cdc9a6456b175fdcdfe7a28b77d6c. Per discussion, we can't change the section title without some web-site work, so revert this change temporarily. Discussion: https://postgr.es/m/157742545062.1149.1105

pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.

2020-02-09 Thread Tom Lane
Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3c5036dba8f145b42edb28cfa49d7fe0d612aad1 Modified Files -- doc/src/sgml/release-11.sgml | 1152 ++

pgsql: Revert "docs: change "default role" wording to "predefined role"

2020-02-09 Thread Tom Lane
Revert "docs: change "default role" wording to "predefined role"" This reverts commit 920c6add70c803ae1dcaab9358330320a60de470. Per discussion, we can't change the section title without some web-site work, so revert this change temporarily. Discussion: https://postgr.es/m/157742545062.1149.1105

pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.

2020-02-09 Thread Tom Lane
Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8be0a55d392cc2701d1ffacc45d56a757cb03df0 Modified Files -- doc/src/sgml/release-9.5.sgml | 643 ++

pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.

2020-02-09 Thread Tom Lane
Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/65106a10f9c5bc9e4622b3616cdf31f74aa58cc2 Modified Files -- doc/src/sgml/release-10.sgml | 955 +++

pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.

2020-02-09 Thread Tom Lane
Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dbae284f317f2fa5c9add9141d5c8f2d8b5140df Modified Files -- doc/src/sgml/release-9.4.sgml | 632 ++

pgsql: Revert "docs: change "default role" wording to "predefined role"

2020-02-09 Thread Tom Lane
Revert "docs: change "default role" wording to "predefined role"" This reverts commit 749f702d13de750b0adaf0aedbcc3c01f078c0c2. Per discussion, we can't change the section title without some web-site work, so revert this change temporarily. Discussion: https://postgr.es/m/157742545062.1149.1105

pgsql: psql: Fix %w length in PROMPT2 when PROMPT1 contains a newline.

2020-02-09 Thread Thomas Munro
psql: Fix %w length in PROMPT2 when PROMPT1 contains a newline. The width of the invisible PROMPT2 must take into account, in order for user input to be aligned with the first line, that PROMPT1 can contain newlines. Author: Maxence Ahlouche Reviewed-by: Tom Lane Discussion: https://postgr.es/m/

pgsql: pg_upgrade: Fix quoting of some arguments in pg_ctl command

2020-02-09 Thread Michael Paquier
pg_upgrade: Fix quoting of some arguments in pg_ctl command The previous coding forgot to apply shell quoting to the socket directory and the data folder, leading to failures when running pg_upgrade. This refactors the code generating the pg_ctl command starting clusters to use a more correct she

pgsql: pg_upgrade: Fix quoting of some arguments in pg_ctl command

2020-02-09 Thread Michael Paquier
pg_upgrade: Fix quoting of some arguments in pg_ctl command The previous coding forgot to apply shell quoting to the socket directory and the data folder, leading to failures when running pg_upgrade. This refactors the code generating the pg_ctl command starting clusters to use a more correct she

pgsql: pg_upgrade: Fix quoting of some arguments in pg_ctl command

2020-02-09 Thread Michael Paquier
pg_upgrade: Fix quoting of some arguments in pg_ctl command The previous coding forgot to apply shell quoting to the socket directory and the data folder, leading to failures when running pg_upgrade. This refactors the code generating the pg_ctl command starting clusters to use a more correct she

pgsql: pg_upgrade: Fix quoting of some arguments in pg_ctl command

2020-02-09 Thread Michael Paquier
pg_upgrade: Fix quoting of some arguments in pg_ctl command The previous coding forgot to apply shell quoting to the socket directory and the data folder, leading to failures when running pg_upgrade. This refactors the code generating the pg_ctl command starting clusters to use a more correct she

pgsql: pg_upgrade: Fix quoting of some arguments in pg_ctl command

2020-02-09 Thread Michael Paquier
pg_upgrade: Fix quoting of some arguments in pg_ctl command The previous coding forgot to apply shell quoting to the socket directory and the data folder, leading to failures when running pg_upgrade. This refactors the code generating the pg_ctl command starting clusters to use a more correct she

pgsql: pg_upgrade: Fix quoting of some arguments in pg_ctl command

2020-02-09 Thread Michael Paquier
pg_upgrade: Fix quoting of some arguments in pg_ctl command The previous coding forgot to apply shell quoting to the socket directory and the data folder, leading to failures when running pg_upgrade. This refactors the code generating the pg_ctl command starting clusters to use a more correct she

pgsql: doc: Spell checking

2020-02-09 Thread Amit Kapila
doc: Spell checking Reported-by: Justin Pryzby Author: Justin Pryzby Backpatch-through: 9.6 Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c55863539c8cd6adf61b0f1287562a49f10bbbef Modified

pgsql: doc: Spell checking

2020-02-09 Thread Amit Kapila
doc: Spell checking Reported-by: Justin Pryzby Author: Justin Pryzby Backpatch-through: 9.6 Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/812bfe89a2798b96fd60c24b4c2bfed436f3e29e Modified

pgsql: doc: Spell checking

2020-02-09 Thread Amit Kapila
doc: Spell checking Reported-by: Justin Pryzby Author: Justin Pryzby Backpatch-through: 9.6 Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a6a8616dad9faa824401a3c420775a8f400df432 Modified

pgsql: doc: Spell checking

2020-02-09 Thread Amit Kapila
doc: Spell checking Reported-by: Justin Pryzby Author: Justin Pryzby Backpatch-through: 9.6 Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/77a00b809a03fbc80957815bbd9092aa9a7748e3 Modified Files

pgsql: doc: Spell checking

2020-02-09 Thread Amit Kapila
doc: Spell checking Reported-by: Justin Pryzby Author: Justin Pryzby Backpatch-through: 9.6 Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c91ecccf52d4f2e1acdc9ba62531bcae0d716abe Modified

pgsql: Fix typos.

2020-02-09 Thread Amit Kapila
Fix typos. Reported-by: Justin Pryzby Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3dfba9fdf52121e777e83f27120a755f408927ed Modified Files -- doc/src/sgml/sour

pgsql: Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl comm

2020-02-09 Thread Michael Paquier
Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl command" This reverts commit d1c0b61. The patch has some downsides that require more attention, as discussed with Noah Misch. Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/

pgsql: Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl comm

2020-02-09 Thread Michael Paquier
Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl command" This reverts commit d1c0b61. The patch has some downsides that require more attention, as discussed with Noah Misch. Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/

pgsql: Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl comm

2020-02-09 Thread Michael Paquier
Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl command" This reverts commit d1c0b61. The patch has some downsides that require more attention, as discussed with Noah Misch. Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/

pgsql: Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl comm

2020-02-09 Thread Michael Paquier
Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl command" This reverts commit d1c0b61. The patch has some downsides that require more attention, as discussed with Noah Misch. Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/

pgsql: Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl comm

2020-02-09 Thread Michael Paquier
Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl command" This reverts commit d1c0b61. The patch has some downsides that require more attention, as discussed with Noah Misch. Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/

pgsql: Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl comm

2020-02-09 Thread Michael Paquier
Revert "pg_upgrade: Fix quoting of some arguments in pg_ctl command" This reverts commit d1c0b61. The patch has some downsides that require more attention, as discussed with Noah Misch. Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4e81886