pgsql: Revert 0f5ca02f53

2020-04-08 Thread Alexander Korotkov
Revert 0f5ca02f53 0f5ca02f53 introduces 3 new keywords. It appears to be too much for relatively small feature. Given now we past feature freeze, it's already late for discussion of the new syntax. So, revert. Discussion: https://postgr.es/m/28209.1586294824%40sss.pgh.pa.us Branch -- mast

Re: pgsql: Implement waiting for given lsn at transaction start

2020-04-08 Thread Alexander Korotkov
On Wed, Apr 8, 2020 at 5:18 AM Michael Paquier wrote: > On Wed, Apr 08, 2020 at 06:07:23AM +0530, Amit Kapila wrote: > > I think we have two options now (a) Provide feedback on the thread for > > syntax and see what best we can do in that regard (b) Revert and try > > it for PG14. I think general

pgsql: Allow publishing partition changes via ancestors

2020-04-08 Thread Peter Eisentraut
Allow publishing partition changes via ancestors To control whether partition changes are replicated using their own identity and schema or an ancestor's, add a new parameter that can be set per publication named 'publish_via_partition_root'. This allows replicating a partitioned table into a dif

pgsql: Rationalize GetWalRcv{Write,Flush}RecPtr().

2020-04-08 Thread Thomas Munro
Rationalize GetWalRcv{Write,Flush}RecPtr(). GetWalRcvWriteRecPtr() previously reported the latest *flushed* location. Adopt the conventional terminology used elsewhere in the tree by renaming it to GetWalRcvFlushRecPtr(), and likewise for some related variables that used the term "received". Add

pgsql: Fix pg_dump/pg_restore to restore event trigger comments later.

2020-04-08 Thread Tom Lane
Fix pg_dump/pg_restore to restore event trigger comments later. Repair an oversight in commit 8728b2c70: if we're postponing restore of event triggers to the end, we must also postpone restoring any comments on them, since of course we cannot create the comments first. (This opens yet another oppo

pgsql: Fix pg_dump/pg_restore to restore event trigger comments later.

2020-04-08 Thread Tom Lane
Fix pg_dump/pg_restore to restore event trigger comments later. Repair an oversight in commit 8728b2c70: if we're postponing restore of event triggers to the end, we must also postpone restoring any comments on them, since of course we cannot create the comments first. (This opens yet another oppo

pgsql: Fix pg_dump/pg_restore to restore event trigger comments later.

2020-04-08 Thread Tom Lane
Fix pg_dump/pg_restore to restore event trigger comments later. Repair an oversight in commit 8728b2c70: if we're postponing restore of event triggers to the end, we must also postpone restoring any comments on them, since of course we cannot create the comments first. (This opens yet another oppo

pgsql: Fix pg_dump/pg_restore to restore event trigger comments later.

2020-04-08 Thread Tom Lane
Fix pg_dump/pg_restore to restore event trigger comments later. Repair an oversight in commit 8728b2c70: if we're postponing restore of event triggers to the end, we must also postpone restoring any comments on them, since of course we cannot create the comments first. (This opens yet another oppo

pgsql: Fix pg_dump/pg_restore to restore event trigger comments later.

2020-04-08 Thread Tom Lane
Fix pg_dump/pg_restore to restore event trigger comments later. Repair an oversight in commit 8728b2c70: if we're postponing restore of event triggers to the end, we must also postpone restoring any comments on them, since of course we cannot create the comments first. (This opens yet another oppo

pgsql: Fix pg_dump/pg_restore to restore event trigger comments later.

2020-04-08 Thread Tom Lane
Fix pg_dump/pg_restore to restore event trigger comments later. Repair an oversight in commit 8728b2c70: if we're postponing restore of event triggers to the end, we must also postpone restoring any comments on them, since of course we cannot create the comments first. (This opens yet another oppo

pgsql: Stabilize incremental_sort tests

2020-04-08 Thread Tomas Vondra
Stabilize incremental_sort tests The test never did ANALYZE on the test table, so the plans depended on various defaults (e.g. number of groups being 200). This worked most of the time, but with CLOBBER_CACHE_ALWAYS the autoanalyze often managed to build accurate stats, changing the plan. Fixed

pgsql: createuser: Change a fprintf to pg_log_error

2020-04-08 Thread Peter Eisentraut
createuser: Change a fprintf to pg_log_error Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f45b8e51b6838ab820df13983c194f737be48778 Modified Files -- src/bin/scripts/createuser.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

pgsql: createuser: Change a fprintf to pg_log_error

2020-04-08 Thread Peter Eisentraut
createuser: Change a fprintf to pg_log_error Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/41b4b2a7cffc3f437aa19751f2055a2918429d33 Modified Files -- src/bin/scripts/createuser.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

pgsql: Msys2 tweaks for pg_validatebackup corruption test

2020-04-08 Thread Andrew Dunstan
Msys2 tweaks for pg_validatebackup corruption test 1. Tell Msys2 not to mangle the tablespace map parameter 2. If rmdir doesn't work, fall back to trying unlink on the entry in pg_tblspc. Discussion: https://postgr.es/m/[email protected] Branch -- maste

Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test

2020-04-08 Thread Kyotaro Horiguchi
At Wed, 08 Apr 2020 14:44:52 +0900 (JST), Kyotaro Horiguchi wrote in > At Wed, 08 Apr 2020 03:33:04 +, Alvaro Herrera > wrote in > > Remove testing for precise LSN/reserved bytes in new TAP test > > > > Trying to ensure that a slot's restart_lsn or amount of reserved bytes > > exactly ma

pgsql: Allow parallel create index to accumulate buffer usage stats.

2020-04-08 Thread Amit Kapila
Allow parallel create index to accumulate buffer usage stats. Currently, we don't account for buffer usage incurred by parallel workers for parallel create index.  This commit allows each worker to record the buffer usage stats and leader backend to accumulate that stats at the end of the operatio

pgsql: Allow parallel create index to accumulate buffer usage stats.

2020-04-08 Thread Amit Kapila
Allow parallel create index to accumulate buffer usage stats. Currently, we don't account for buffer usage incurred by parallel workers for parallel create index.  This commit allows each worker to record the buffer usage stats and leader backend to accumulate that stats at the end of the operatio

pgsql: Allow parallel create index to accumulate buffer usage stats.

2020-04-08 Thread Amit Kapila
Allow parallel create index to accumulate buffer usage stats. Currently, we don't account for buffer usage incurred by parallel workers for parallel create index.  This commit allows each worker to record the buffer usage stats and leader backend to accumulate that stats at the end of the operatio

Re: pgsql: Implement waiting for given lsn at transaction start

2020-04-08 Thread Michael Paquier
On Wed, Apr 08, 2020 at 11:45:35AM +0300, Alexander Korotkov wrote: > In my original idea, we can assume simplified syntax to be agreed. > And other issues could be easily resolved if arise. But it appears we > have serious complains to even simplified syntax. For sure, we > shouldn't discuss it