pgsql: Improve error messages after LoadLibrary()

2020-04-13 Thread Peter Eisentraut
Improve error messages after LoadLibrary() Move the file name to a format parameter to ease translatability. Add error code where missing. Make the wording consistent. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0c620a5803afbb667da7ac4bcc91b245a214a80c Modifi

pgsql: Cosmetic fixups for WAL usage work.

2020-04-13 Thread Amit Kapila
Cosmetic fixups for WAL usage work. Reported-by: Justin Pryzby and Euler Taveira Author: Justin Pryzby and Julien Rouhaud Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAB-hujrP8ZfUkvL5OYETipQwA=e3n7oqHFU=4zlxws_cza3...@mail.gmail.com Branch -- master Details --- https://git.

pgsql: Rename pg_validatebackup to pg_verifybackup some more.

2020-04-13 Thread Robert Haas
Rename pg_validatebackup to pg_verifybackup some more. The previous commit missed an instance. Noriyoshi Shinoda Discussion: http://postgr.es/m/tu4pr8401mb115291ae850ba7cf1aeb2f0bee...@tu4pr8401mb1152.namprd84.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg

pgsql: Print policy name in perlcritic messages

2020-04-13 Thread Andrew Dunstan
Print policy name in perlcritic messages This makes it easier to do a web search for details of the policy that's been violated, as well as displaying the name that might be needed for a policy override. Various perlcritic settings changes are being discussed, but this one should be uncontroversi

pgsql: Use perl warnings pragma consistently

2020-04-13 Thread Andrew Dunstan
Use perl warnings pragma consistently We've had a mixture of the warnings pragma, the -w switch on the shebang line, and no warnings at all. This patch removes the -w swicth and add the warnings pragma to all perl sources missing it. It raises the severity of the TestingAndDebugging::RequireUseWar

pgsql: Use perl's $/ more idiomatically

2020-04-13 Thread Andrew Dunstan
Use perl's $/ more idiomatically This replaces a few occurrences of ugly code with a more clean and idiomatic usage. The problem was highlighted by perlcritic, but we're not enforcing the policy that led to the discovery. Discussion: https://postgr.es/m/[email protected] B

Re: pgsql: Use perl warnings pragma consistently

2020-04-13 Thread Tom Lane
Andrew Dunstan writes: > Use perl warnings pragma consistently This seems to have broken something or other, as I now get a bunch of warnings while building the docs: ... Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat

Re: pgsql: Use perl warnings pragma consistently

2020-04-13 Thread Alvaro Herrera
On 2020-Apr-13, Tom Lane wrote: > Andrew Dunstan writes: > > Use perl warnings pragma consistently > > This seems to have broken something or other, as I now get a bunch of > warnings while building the docs: > > ... > Use of uninitialized value within %feature_packages in concatenation (.) or

Re: pgsql: Use perl warnings pragma consistently

2020-04-13 Thread Andrew Dunstan
On 4/13/20 5:49 PM, Alvaro Herrera wrote: > On 2020-Apr-13, Tom Lane wrote: > >> Andrew Dunstan writes: >>> Use perl warnings pragma consistently >> This seems to have broken something or other, as I now get a bunch of >> warnings while building the docs: >> >> ... >> Use of uninitialized value

pgsql: Harmonize nbtree page split point code.

2020-04-13 Thread Peter Geoghegan
Harmonize nbtree page split point code. An nbtree split point can be thought of as a point between two adjoining tuples from an imaginary version of the page being split that includes the incoming/new item (in addition to the items that really are on the page). These adjoining tuples are called t

pgsql: Silence Perl warning

2020-04-13 Thread Alvaro Herrera
Silence Perl warning Now that warnings are enabled across the board, this code that tries to print an undef variable emits one. Silently printing the empty string achieves the previous behavior. Author: Álvaro Herrera Reviewed-by: Andrew Dunstan Discussion: https://postgr.es/m/e1jo1vt-0008qk..

pgsql: Add a wait_for_catchup() before immediate stop of a test master.

2020-04-13 Thread Noah Misch
Add a wait_for_catchup() before immediate stop of a test master. Per buildfarm member hoverfly, a slow walsender could make the test fail. Back-patch to v10, where the test was introduced. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Deta

pgsql: Add a wait_for_catchup() before immediate stop of a test master.

2020-04-13 Thread Noah Misch
Add a wait_for_catchup() before immediate stop of a test master. Per buildfarm member hoverfly, a slow walsender could make the test fail. Back-patch to v10, where the test was introduced. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Deta

pgsql: Add a wait_for_catchup() before immediate stop of a test master.

2020-04-13 Thread Noah Misch
Add a wait_for_catchup() before immediate stop of a test master. Per buildfarm member hoverfly, a slow walsender could make the test fail. Back-patch to v10, where the test was introduced. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Deta

pgsql: Add a wait_for_catchup() before immediate stop of a test master.

2020-04-13 Thread Noah Misch
Add a wait_for_catchup() before immediate stop of a test master. Per buildfarm member hoverfly, a slow walsender could make the test fail. Back-patch to v10, where the test was introduced. Discussion: https://postgr.es/m/[email protected] Branch -- master Details ---

pgsql: Make _bt_insertonpg() more like _bt_split().

2020-04-13 Thread Peter Geoghegan
Make _bt_insertonpg() more like _bt_split(). It seems like a good idea for nbtree's retail insert code to be absolutely consistent with nbtree's page split code for anything that naturally requires equivalent handling. Anything that concerns inserting newitem (which is handled as part of the page

pgsql: Comments and doc fixes for commit 40d964ec99.

2020-04-13 Thread Amit Kapila
Comments and doc fixes for commit 40d964ec99. Reported-by: Justin Pryzby Author: Justin Pryzby, with few changes by me Reviewed-by: Amit Kapila and Sawada Masahiko Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/

pgsql: Add defensive "split_only_page" nbtree assertion.

2020-04-13 Thread Peter Geoghegan
Add defensive "split_only_page" nbtree assertion. Clearly it's not okay for nbtree to split a page that is the only page on its level, and then find that it has to split the parent one level up in turn. There is simply no code to handle the split_only_page case in the _bt_insertonpg() "newitem wo

pgsql: Repair last commit's new wait_for_catchup() call.

2020-04-13 Thread Noah Misch
Repair last commit's new wait_for_catchup() call. The function had a different API in v10. Per buildfarm. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aca51181baf9ec3ddcac6707bf6a6a5014f7543b Modified Files -- src/test/recovery/t/010_logical_

pgsql: Fix collection of typos and grammar mistakes in the tree, volume

2020-04-13 Thread Michael Paquier
Fix collection of typos and grammar mistakes in the tree, volume 2 This fixes some comments and documentation new as of Postgres 13, and is a follow-up of the work done in dd0f37e. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Det