pgsql: Remove dead forceSync parameter of XactLogCommitRecord().

2020-06-20 Thread Noah Misch
Remove dead forceSync parameter of XactLogCommitRecord(). The function has been reading global variable forceSyncCommit, mirroring the intent of the caller that passed forceSync=forceSyncCommit. The other caller, RecordTransactionCommitPrepared(), passed false. Since COMMIT PREPARED can't share

pgsql: Add documentation for opclass options

2020-06-20 Thread Alexander Korotkov
Add documentation for opclass options 911e7020770 added opclass options and adjusted documentation for each particular affected opclass. However, documentation for extendability was not adjusted. This commit adjusts documentation for interfaces of index AMs and opclasses. Discussion: https://p

git.postgresql.org ok?

2020-06-20 Thread Erik Rijkers
Hello, The mails that I get today from pgsql-committers contain links (as usual) to git.postgresql.org but these links don't seem to give valid pages: I get what looks like a gitweb page but with '404 - Unknown commit object ' example: https://git.postgresql.org/pg/commitdiff/15cb2bd27009f7

pgsql: Fix masking of SP-GiST pages during xlog consistency check

2020-06-20 Thread Alexander Korotkov
Fix masking of SP-GiST pages during xlog consistency check spg_mask() didn't take into account that pd_lower equal to SizeOfPageHeaderData is still valid value. This commit fixes that. Backpatch to 11, where spg_mask() pg_lower check was introduced. Reported-by: Michael Paquier Discussion: http

pgsql: Fix masking of SP-GiST pages during xlog consistency check

2020-06-20 Thread Alexander Korotkov
Fix masking of SP-GiST pages during xlog consistency check spg_mask() didn't take into account that pd_lower equal to SizeOfPageHeaderData is still valid value. This commit fixes that. Backpatch to 11, where spg_mask() pg_lower check was introduced. Reported-by: Michael Paquier Discussion: http

Re: git.postgresql.org ok?

2020-06-20 Thread Alexander Korotkov
On Sat, Jun 20, 2020 at 3:32 PM Erik Rijkers wrote: > The mails that I get today from pgsql-committers contain links (as > usual) to git.postgresql.org > but these links don't seem to give valid pages: I get what looks like a > gitweb page but with '404 - Unknown commit object ' > > example: > ht

pgsql: Fix masking of SP-GiST pages during xlog consistency check

2020-06-20 Thread Alexander Korotkov
Fix masking of SP-GiST pages during xlog consistency check spg_mask() didn't take into account that pd_lower equal to SizeOfPageHeaderData is still valid value. This commit fixes that. Backpatch to 11, where spg_mask() pg_lower check was introduced. Reported-by: Michael Paquier Discussion: http

Re: pgsql: Add documentation for opclass options

2020-06-20 Thread Tom Lane
Alexander Korotkov writes: > Add documentation for opclass options Surely this should have been put into v13 as well? regards, tom lane

Re: git.postgresql.org ok?

2020-06-20 Thread Amit Kapila
On Sat, Jun 20, 2020 at 6:02 PM Erik Rijkers wrote: > > > I don't know exactly where things are going wrong - could even be local > here but I don't think so.. do others see the same thing? > Yes, I am also facing the same problem. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterpri

Re: git.postgresql.org ok?

2020-06-20 Thread Stefan Kaltenbrunner
On 6/20/20 4:46 PM, Alexander Korotkov wrote: > On Sat, Jun 20, 2020 at 3:32 PM Erik Rijkers wrote: >> The mails that I get today from pgsql-committers contain links (as >> usual) to git.postgresql.org >> but these links don't seem to give valid pages: I get what looks like a >> gitweb page but w

Re: pgsql: Add documentation for opclass options

2020-06-20 Thread Alexander Korotkov
On Sat, Jun 20, 2020 at 5:53 PM Tom Lane wrote: > Alexander Korotkov writes: > > Add documentation for opclass options > > Surely this should have been put into v13 as well? Oh, I just forgot the fact we've branched v13 already. Thank you for noticing! -- Regards, Alexander Korotkov

Re: git.postgresql.org ok?

2020-06-20 Thread Erik Rijkers
On 2020-06-20 17:08, Stefan Kaltenbrunner wrote: the root issue should be fixed as of a few minutes ago but it might take a bit until everything is synced up again. Thanks!

pgsql: Add documentation for opclass options

2020-06-20 Thread Alexander Korotkov
Add documentation for opclass options 911e7020770 added opclass options and adjusted documentation for each particular affected opclass. However, documentation for extendability was not adjusted. This commit adjusts documentation for interfaces of index AMs and opclasses. Discussion: https://p

pgsql: Fix masking of SP-GiST pages during xlog consistency check

2020-06-20 Thread Alexander Korotkov
Fix masking of SP-GiST pages during xlog consistency check spg_mask() didn't take into account that pd_lower equal to SizeOfPageHeaderData is still valid value. This commit fixes that. Backpatch to 11, where spg_mask() pg_lower check was introduced. Reported-by: Michael Paquier Discussion: http

Re: git.postgresql.org ok?

2020-06-20 Thread Alexander Korotkov
On Sat, Jun 20, 2020 at 6:08 PM Stefan Kaltenbrunner wrote: > On 6/20/20 4:46 PM, Alexander Korotkov wrote: > > On Sat, Jun 20, 2020 at 3:32 PM Erik Rijkers wrote: > >> The mails that I get today from pgsql-committers contain links (as > >> usual) to git.postgresql.org > >> but these links don't

pgsql: Minor corrections to docs related to opclass options

2020-06-20 Thread Alexander Korotkov
Minor corrections to docs related to opclass options Reported-by: Peter Geoghegan Discussion: https://postgr.es/m/CAH2-WzmwhYbxuoL0WjTLaiCxW3gj6qadeNpBhWAo_KZsE5-FGw%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3be015c9fc02316f1f1579301391fb5c67

pgsql: Minor corrections to docs related to opclass options

2020-06-20 Thread Alexander Korotkov
Minor corrections to docs related to opclass options Reported-by: Peter Geoghegan Discussion: https://postgr.es/m/CAH2-WzmwhYbxuoL0WjTLaiCxW3gj6qadeNpBhWAo_KZsE5-FGw%40mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b56d91ebd2bef20f9adbcc61c12

pgsql: Doc: Tweak description of B-Tree duplicate tuples.

2020-06-20 Thread Peter Geoghegan
Doc: Tweak description of B-Tree duplicate tuples. Defining duplicates as "close by" to each other was unclear. Simplify the definition. Backpatch: 13-, where deduplication was introduced (by commit 0d861bbb) Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/48c6959

pgsql: Doc: Tweak description of B-Tree duplicate tuples.

2020-06-20 Thread Peter Geoghegan
Doc: Tweak description of B-Tree duplicate tuples. Defining duplicates as "close by" to each other was unclear. Simplify the definition. Backpatch: 13-, where deduplication was introduced (by commit 0d861bbb) Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/

pgsql: Language fixes for docs related to opclass options

2020-06-20 Thread Alexander Korotkov
Language fixes for docs related to opclass options Discussion: https://postgr.es/m/20200620232145.GB17995%40telsasoft.com Author: Justin Pryzby Backpatch-through: 13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/14903f238ec999802df5c539010c6be32d72f8cd Modified F

pgsql: Language fixes for docs related to opclass options

2020-06-20 Thread Alexander Korotkov
Language fixes for docs related to opclass options Discussion: https://postgr.es/m/20200620232145.GB17995%40telsasoft.com Author: Justin Pryzby Backpatch-through: 13 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/70004a2a0c52e05f4aa67541fb165715a3981204 Mod