Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

2020-06-25 Thread David Steele
On 6/24/20 6:27 PM, Tom Lane wrote: David Steele writes: ... So apparently it is possible. To get them working as soon as possible I recommended that they run: alter role postgres set max_parallel_workers_per_gather = 0; And that solved their problem. 9.6 is getting on in years so I'm not sure

Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

2020-06-25 Thread Magnus Hagander
On Thu, Jun 25, 2020 at 2:11 PM David Steele wrote: > On 6/24/20 6:27 PM, Tom Lane wrote: > > David Steele writes: > >> ... So apparently it is possible. To get them working as soon as > possible I > >> recommended that they run: > >> alter role postgres set max_parallel_workers_per_gather = 0;

Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

2020-06-25 Thread David Steele
On 6/25/20 8:43 AM, Magnus Hagander wrote: On Thu, Jun 25, 2020 at 2:11 PM David Steele > wrote: On 6/24/20 6:27 PM, Tom Lane wrote: > > I was able to force it like this: > > regression=# set force_parallel_mode TO 'on'; > SET Ah, yes,

Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

2020-06-25 Thread Magnus Hagander
On Thu, Jun 25, 2020 at 4:56 PM David Steele wrote: > On 6/25/20 8:43 AM, Magnus Hagander wrote: > > On Thu, Jun 25, 2020 at 2:11 PM David Steele > > wrote: > > On 6/24/20 6:27 PM, Tom Lane wrote: > > > > > > I was able to force it like this: > > >

Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

2020-06-25 Thread Tom Lane
David Steele writes: > I'm looking at this as more than a fix for 9.6. I can't see any reason > for the backup control session to run queries in parallel and possibly > use more resources, so parallelism is disabled for all versions that > support it. Post-9.6, these functions are correctly ma

Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.

2020-06-25 Thread David Steele
On 6/25/20 11:02 AM, Magnus Hagander wrote: On Thu, Jun 25, 2020 at 4:56 PM David Steele > wrote: So we added that to session initialization in pgBackRest: https://github.com/pgbackrest/pgbackrest/commit/ea04ec7b3f4c6cf25c1b827c25c6a3c5896159a8 Personally I

pgsql: Doc: correct nitpicky mistakes in array_position/array_positions

2020-06-25 Thread Tom Lane
Doc: correct nitpicky mistakes in array_position/array_positions examples. Daniel Gustafsson and Erik Rijkers, per report from nick@cleaton Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.post

pgsql: Doc: correct nitpicky mistakes in array_position/array_positions

2020-06-25 Thread Tom Lane
Doc: correct nitpicky mistakes in array_position/array_positions examples. Daniel Gustafsson and Erik Rijkers, per report from nick@cleaton Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.

pgsql: Fix misuse of table_index_fetch_tuple_check().

2020-06-25 Thread Peter Geoghegan
Fix misuse of table_index_fetch_tuple_check(). Commit 0d861bbb, which added deduplication to nbtree, had _bt_check_unique() pass a TID to table_index_fetch_tuple_check() that isn't safe to mutate. table_index_fetch_tuple_check()'s tid argument is modified when the TID in question is not the lates

pgsql: Fix misuse of table_index_fetch_tuple_check().

2020-06-25 Thread Peter Geoghegan
Fix misuse of table_index_fetch_tuple_check(). Commit 0d861bbb, which added deduplication to nbtree, had _bt_check_unique() pass a TID to table_index_fetch_tuple_check() that isn't safe to mutate. table_index_fetch_tuple_check()'s tid argument is modified when the TID in question is not the lates

pgsql: docs: clarify that CREATE DATABASE does not copy db permissions

2020-06-25 Thread Bruce Momjian
docs: clarify that CREATE DATABASE does not copy db permissions That is, those database permissions set by GRANT. Diagnosed-by: Joseph Nahmias Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.pos

pgsql: docs: clarify that CREATE DATABASE does not copy db permissions

2020-06-25 Thread Bruce Momjian
docs: clarify that CREATE DATABASE does not copy db permissions That is, those database permissions set by GRANT. Diagnosed-by: Joseph Nahmias Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.pos

pgsql: docs: clarify that CREATE DATABASE does not copy db permissions

2020-06-25 Thread Bruce Momjian
docs: clarify that CREATE DATABASE does not copy db permissions That is, those database permissions set by GRANT. Diagnosed-by: Joseph Nahmias Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.pos

pgsql: docs: clarify that CREATE DATABASE does not copy db permissions

2020-06-25 Thread Bruce Momjian
docs: clarify that CREATE DATABASE does not copy db permissions That is, those database permissions set by GRANT. Diagnosed-by: Joseph Nahmias Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.pos

pgsql: docs: clarify that CREATE DATABASE does not copy db permissions

2020-06-25 Thread Bruce Momjian
docs: clarify that CREATE DATABASE does not copy db permissions That is, those database permissions set by GRANT. Diagnosed-by: Joseph Nahmias Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql

pgsql: docs: clarify that CREATE DATABASE does not copy db permissions

2020-06-25 Thread Bruce Momjian
docs: clarify that CREATE DATABASE does not copy db permissions That is, those database permissions set by GRANT. Diagnosed-by: Joseph Nahmias Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.pos

pgsql: docs: clarify that CREATE DATABASE does not copy db permissions

2020-06-25 Thread Bruce Momjian
docs: clarify that CREATE DATABASE does not copy db permissions That is, those database permissions set by GRANT. Diagnosed-by: Joseph Nahmias Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.pos

pgsql: doc: mention trigger helper functions in CREATE TRIGGER docs

2020-06-25 Thread Bruce Momjian
doc: mention trigger helper functions in CREATE TRIGGER docs Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc: mention trigger helper functions in CREATE TRIGGER docs

2020-06-25 Thread Bruce Momjian
doc: mention trigger helper functions in CREATE TRIGGER docs Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc: mention trigger helper functions in CREATE TRIGGER docs

2020-06-25 Thread Bruce Momjian
doc: mention trigger helper functions in CREATE TRIGGER docs Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc: mention trigger helper functions in CREATE TRIGGER docs

2020-06-25 Thread Bruce Momjian
doc: mention trigger helper functions in CREATE TRIGGER docs Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: doc: mention trigger helper functions in CREATE TRIGGER docs

2020-06-25 Thread Bruce Momjian
doc: mention trigger helper functions in CREATE TRIGGER docs Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc: mention trigger helper functions in CREATE TRIGGER docs

2020-06-25 Thread Bruce Momjian
doc: mention trigger helper functions in CREATE TRIGGER docs Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/com

pgsql: doc: mention trigger helper functions in CREATE TRIGGER docs

2020-06-25 Thread Bruce Momjian
doc: mention trigger helper functions in CREATE TRIGGER docs Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/com