pgsql: Doc: sync lobj.sgml's copy of testlo.c with the latter file.

2020-09-24 Thread Tom Lane
Doc: sync lobj.sgml's copy of testlo.c with the latter file. Zhijie Hou Discussion: https://postgr.es/m/ce2cd951fe9b448a9cda99dc1a871fb9@G08CNEXMBPEKD05.g08.fujitsu.local Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fc5f107a8c08f55cc8b810d6f212dd723a07fe9a Mod

Re: pgsql: Improve the error message for an inappropriate column definition

2020-09-24 Thread Bruce Momjian
On Tue, Sep 22, 2020 at 02:49:22PM +, Tom Lane wrote: > Improve the error message for an inappropriate column definition list. > > The existing message about "a column definition list is only allowed for > functions returning "record"" could be given in some cases where it was > fairly confusi

pgsql: Expose oldSnapshotControl definition via new header.

2020-09-24 Thread Robert Haas
Expose oldSnapshotControl definition via new header. This makes it possible for code outside snapmgr.c to examine the contents of this data structure. This commit does not add any code which actually does so; a subsequent commit will make that change. Patch by me, reviewed by Thomas Munro, Dilip

pgsql: Add new 'old_snapshot' contrib module.

2020-09-24 Thread Robert Haas
Add new 'old_snapshot' contrib module. You can use this to view the contents of the time to XID mapping which the server maintains when old_snapshot_threshold != -1. Being able to view that information may be interesting for users, and it's definitely useful for figuring out whether the mapping is

Re: pgsql: Improve the error message for an inappropriate column definition

2020-09-24 Thread Tom Lane
Bruce Momjian writes: > On Tue, Sep 22, 2020 at 02:49:22PM +, Tom Lane wrote: >> Improve the error message for an inappropriate column definition list. > Uh, did you not want to backpatch this? No. It's not a bug fix, and it'd add work for translators. regards, tom

pgsql: Standardize the printf format for st_size

2020-09-24 Thread Peter Eisentraut
Standardize the printf format for st_size Existing code used various inconsistent ways to printf struct stat's st_size member. The type of that is off_t, which is in most cases a signed 64-bit integer, so use the long long int format for it. Branch -- master Details --- https://git.post

pgsql: Fix two bugs in MaintainOldSnapshotTimeMapping.

2020-09-24 Thread Robert Haas
Fix two bugs in MaintainOldSnapshotTimeMapping. The previous coding was confused about whether head_timestamp was intended to represent the timestamp for the newest bucket in the mapping or the oldest timestamp for the oldest bucket in the mapping. Decide that it's intended to be the oldest one, a

Re: pgsql: Improve the error message for an inappropriate column definition

2020-09-24 Thread Bruce Momjian
On Thu, Sep 24, 2020 at 02:58:49PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Tue, Sep 22, 2020 at 02:49:22PM +, Tom Lane wrote: > >> Improve the error message for an inappropriate column definition list. > > > Uh, did you not want to backpatch this? > > No. It's not a bug fix, a

pgsql: Fix handling of -d "connection string" in pg_dump/pg_restore.

2020-09-24 Thread Tom Lane
Fix handling of -d "connection string" in pg_dump/pg_restore. Parallel pg_dump failed if its -d parameter was a connection string containing any essential information other than host, port, or username. The same was true for pg_restore with --create. The reason is that these scenarios failed to p

pgsql: Fix handling of -d "connection string" in pg_dump/pg_restore.

2020-09-24 Thread Tom Lane
Fix handling of -d "connection string" in pg_dump/pg_restore. Parallel pg_dump failed if its -d parameter was a connection string containing any essential information other than host, port, or username. The same was true for pg_restore with --create. The reason is that these scenarios failed to p

pgsql: Fix handling of -d "connection string" in pg_dump/pg_restore.

2020-09-24 Thread Tom Lane
Fix handling of -d "connection string" in pg_dump/pg_restore. Parallel pg_dump failed if its -d parameter was a connection string containing any essential information other than host, port, or username. The same was true for pg_restore with --create. The reason is that these scenarios failed to p

pgsql: Fix handling of -d "connection string" in pg_dump/pg_restore.

2020-09-24 Thread Tom Lane
Fix handling of -d "connection string" in pg_dump/pg_restore. Parallel pg_dump failed if its -d parameter was a connection string containing any essential information other than host, port, or username. The same was true for pg_restore with --create. The reason is that these scenarios failed to p

pgsql: Fix handling of -d "connection string" in pg_dump/pg_restore.

2020-09-24 Thread Tom Lane
Fix handling of -d "connection string" in pg_dump/pg_restore. Parallel pg_dump failed if its -d parameter was a connection string containing any essential information other than host, port, or username. The same was true for pg_restore with --create. The reason is that these scenarios failed to p

pgsql: Fix handling of -d "connection string" in pg_dump/pg_restore.

2020-09-24 Thread Tom Lane
Fix handling of -d "connection string" in pg_dump/pg_restore. Parallel pg_dump failed if its -d parameter was a connection string containing any essential information other than host, port, or username. The same was true for pg_restore with --create. The reason is that these scenarios failed to p

pgsql: Fix handling of -d "connection string" in pg_dump/pg_restore.

2020-09-24 Thread Tom Lane
Fix handling of -d "connection string" in pg_dump/pg_restore. Parallel pg_dump failed if its -d parameter was a connection string containing any essential information other than host, port, or username. The same was true for pg_restore with --create. The reason is that these scenarios failed to p

pgsql: Remove custom memory allocation layer in pgcrypto

2020-09-24 Thread Michael Paquier
Remove custom memory allocation layer in pgcrypto PX_OWN_ALLOC was intended as a way to disable the use of palloc(), and over the time new palloc() or equivalent calls have been added like in 32984d8, making this extra layer losing its original purpose. This simplifies on the way some code paths