pgsql: Replace run-time error check with assertion

2021-05-27 Thread Peter Eisentraut
Replace run-time error check with assertion The error message was checking that the structures returned from the parser matched expectations. That's something we usually use assertions for, not a full user-facing error message. So replace that with an assertion (hidden inside lfirst_node()). Re

pgsql: Fix MSVC scripts when building with GSSAPI/Kerberos

2021-05-27 Thread Michael Paquier
Fix MSVC scripts when building with GSSAPI/Kerberos The deliverables of upstream Kerberos on Windows are installed with paths that do not match our MSVC scripts. First, the include folder was named "inc/" in our scripts, but the upstream MSIs use "include/". Second, the build would fail with 64-b

pgsql: Fix MSVC scripts when building with GSSAPI/Kerberos

2021-05-27 Thread Michael Paquier
Fix MSVC scripts when building with GSSAPI/Kerberos The deliverables of upstream Kerberos on Windows are installed with paths that do not match our MSVC scripts. First, the include folder was named "inc/" in our scripts, but the upstream MSIs use "include/". Second, the build would fail with 64-b

pgsql: Fix MSVC scripts when building with GSSAPI/Kerberos

2021-05-27 Thread Michael Paquier
Fix MSVC scripts when building with GSSAPI/Kerberos The deliverables of upstream Kerberos on Windows are installed with paths that do not match our MSVC scripts. First, the include folder was named "inc/" in our scripts, but the upstream MSIs use "include/". Second, the build would fail with 64-b

pgsql: Fix MSVC scripts when building with GSSAPI/Kerberos

2021-05-27 Thread Michael Paquier
Fix MSVC scripts when building with GSSAPI/Kerberos The deliverables of upstream Kerberos on Windows are installed with paths that do not match our MSVC scripts. First, the include folder was named "inc/" in our scripts, but the upstream MSIs use "include/". Second, the build would fail with 64-b

pgsql: Fix MSVC scripts when building with GSSAPI/Kerberos

2021-05-27 Thread Michael Paquier
Fix MSVC scripts when building with GSSAPI/Kerberos The deliverables of upstream Kerberos on Windows are installed with paths that do not match our MSVC scripts. First, the include folder was named "inc/" in our scripts, but the upstream MSIs use "include/". Second, the build would fail with 64-b

pgsql: Fix MSVC scripts when building with GSSAPI/Kerberos

2021-05-27 Thread Michael Paquier
Fix MSVC scripts when building with GSSAPI/Kerberos The deliverables of upstream Kerberos on Windows are installed with paths that do not match our MSVC scripts. First, the include folder was named "inc/" in our scripts, but the upstream MSIs use "include/". Second, the build would fail with 64-b

pgsql: Add NO_INSTALL option to pgxs

2021-05-27 Thread Peter Eisentraut
Add NO_INSTALL option to pgxs Apply in libpq_pipeline test makefile, so that the test file is not installed into tmp_install. Reviewed-by: Alvaro Herrera Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/cb9d16a6-760f-cd44-28d6-b091d5fb6ca7%40enterprisedb.com Branch

Re: pgsql: Add NO_INSTALL option to pgxs

2021-05-27 Thread Tom Lane
Peter Eisentraut writes: > Add NO_INSTALL option to pgxs hm, buildfarm seems less than pleased ... regards, tom lane

Re: pgsql: Add NO_INSTALL option to pgxs

2021-05-27 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> Add NO_INSTALL option to pgxs > hm, buildfarm seems less than pleased ... I see the pattern now: it's the VPATH members that are broken. regards, tom lane

pgsql: Fix vpath build in libpq_pipeline test

2021-05-27 Thread Peter Eisentraut
Fix vpath build in libpq_pipeline test The path needs to be set to refer to the build directory, not the current directory, because that's actually the source directory at that point. fix for 6abc8c2596dbfcb24f9b4d954a1465b8015118c3 Branch -- master Details --- https://git.postgresql.or

pgsql: Rethink definition of pg_attribute.attcompression.

2021-05-27 Thread Tom Lane
Rethink definition of pg_attribute.attcompression. Redefine '\0' (InvalidCompressionMethod) as meaning "if we need to compress, use the current setting of default_toast_compression". This allows '\0' to be a suitable default choice regardless of datatype, greatly simplifying code paths that initia

pgsql: Reduce the range of OIDs reserved for genbki.pl.

2021-05-27 Thread Tom Lane
Reduce the range of OIDs reserved for genbki.pl. Commit ab596105b increased FirstBootstrapObjectId from 12000 to 13000, but we've had some push-back about that. It's worrisome to reduce the daylight between there and FirstNormalObjectId, because the number of OIDs consumed during initdb for colla

pgsql: Fix VACUUM VERBOSE's LP_DEAD item pages output.

2021-05-27 Thread Peter Geoghegan
Fix VACUUM VERBOSE's LP_DEAD item pages output. Oversight in commit 5100010e. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9afdea982420f9672b88e5c17d1ee8eec64105fc Modified Files -- src/backend/access/heap/vacuumlazy.c | 2 +- 1 file changed, 1 insert