pgsql: Add test case for obsoleting slot with active walsender, take 2

2021-06-23 Thread Alvaro Herrera
Add test case for obsoleting slot with active walsender, take 2 The code to signal a running walsender when its reserved WAL size grows too large is completely uncovered before this commit; this adds coverage for that case. This test involves sending SIGSTOP to walsender and walreceiver, then adv

pgsql: Improve display of query results in isolation tests.

2021-06-23 Thread Tom Lane
Improve display of query results in isolation tests. Previously, isolationtester displayed SQL query results using some ad-hoc code that clearly hadn't had much effort expended on it. Field values longer than 14 characters weren't separated from the next field, and usually caused misalignment of t

pgsql: Improve display of query results in isolation tests.

2021-06-23 Thread Tom Lane
Improve display of query results in isolation tests. Previously, isolationtester displayed SQL query results using some ad-hoc code that clearly hadn't had much effort expended on it. Field values longer than 14 characters weren't separated from the next field, and usually caused misalignment of t

pgsql: Improve display of query results in isolation tests.

2021-06-23 Thread Tom Lane
Improve display of query results in isolation tests. Previously, isolationtester displayed SQL query results using some ad-hoc code that clearly hadn't had much effort expended on it. Field values longer than 14 characters weren't separated from the next field, and usually caused misalignment of t

pgsql: Improve display of query results in isolation tests.

2021-06-23 Thread Tom Lane
Improve display of query results in isolation tests. Previously, isolationtester displayed SQL query results using some ad-hoc code that clearly hadn't had much effort expended on it. Field values longer than 14 characters weren't separated from the next field, and usually caused misalignment of t

pgsql: Improve display of query results in isolation tests.

2021-06-23 Thread Tom Lane
Improve display of query results in isolation tests. Previously, isolationtester displayed SQL query results using some ad-hoc code that clearly hadn't had much effort expended on it. Field values longer than 14 characters weren't separated from the next field, and usually caused misalignment of t

pgsql: Improve display of query results in isolation tests.

2021-06-23 Thread Tom Lane
Improve display of query results in isolation tests. Previously, isolationtester displayed SQL query results using some ad-hoc code that clearly hadn't had much effort expended on it. Field values longer than 14 characters weren't separated from the next field, and usually caused misalignment of t

pgsql: Don't assume GSSAPI result strings are null-terminated.

2021-06-23 Thread Tom Lane
Don't assume GSSAPI result strings are null-terminated. Our uses of gss_display_status() and gss_display_name() assumed that the gss_buffer_desc strings returned by those functions are null-terminated. It appears that they generally are, given the lack of field complaints up to now. However, the

pgsql: Don't assume GSSAPI result strings are null-terminated.

2021-06-23 Thread Tom Lane
Don't assume GSSAPI result strings are null-terminated. Our uses of gss_display_status() and gss_display_name() assumed that the gss_buffer_desc strings returned by those functions are null-terminated. It appears that they generally are, given the lack of field complaints up to now. However, the

pgsql: Don't assume GSSAPI result strings are null-terminated.

2021-06-23 Thread Tom Lane
Don't assume GSSAPI result strings are null-terminated. Our uses of gss_display_status() and gss_display_name() assumed that the gss_buffer_desc strings returned by those functions are null-terminated. It appears that they generally are, given the lack of field complaints up to now. However, the

pgsql: Don't assume GSSAPI result strings are null-terminated.

2021-06-23 Thread Tom Lane
Don't assume GSSAPI result strings are null-terminated. Our uses of gss_display_status() and gss_display_name() assumed that the gss_buffer_desc strings returned by those functions are null-terminated. It appears that they generally are, given the lack of field complaints up to now. However, the

pgsql: Don't assume GSSAPI result strings are null-terminated.

2021-06-23 Thread Tom Lane
Don't assume GSSAPI result strings are null-terminated. Our uses of gss_display_status() and gss_display_name() assumed that the gss_buffer_desc strings returned by those functions are null-terminated. It appears that they generally are, given the lack of field complaints up to now. However, the

pgsql: Don't assume GSSAPI result strings are null-terminated.

2021-06-23 Thread Tom Lane
Don't assume GSSAPI result strings are null-terminated. Our uses of gss_display_status() and gss_display_name() assumed that the gss_buffer_desc strings returned by those functions are null-terminated. It appears that they generally are, given the lack of field complaints up to now. However, the

pgsql: Doc: fix confusion about LEAKPROOF in syntax summaries.

2021-06-23 Thread Tom Lane
Doc: fix confusion about LEAKPROOF in syntax summaries. The syntax summaries for CREATE FUNCTION and allied commands made it look like LEAKPROOF is an alternative to IMMUTABLE/STABLE/VOLATILE, when of course it is an orthogonal option. Improve that. Per gripe from aazamrafeeque0. Thanks to Davi

pgsql: Doc: fix confusion about LEAKPROOF in syntax summaries.

2021-06-23 Thread Tom Lane
Doc: fix confusion about LEAKPROOF in syntax summaries. The syntax summaries for CREATE FUNCTION and allied commands made it look like LEAKPROOF is an alternative to IMMUTABLE/STABLE/VOLATILE, when of course it is an orthogonal option. Improve that. Per gripe from aazamrafeeque0. Thanks to Davi

pgsql: Doc: fix confusion about LEAKPROOF in syntax summaries.

2021-06-23 Thread Tom Lane
Doc: fix confusion about LEAKPROOF in syntax summaries. The syntax summaries for CREATE FUNCTION and allied commands made it look like LEAKPROOF is an alternative to IMMUTABLE/STABLE/VOLATILE, when of course it is an orthogonal option. Improve that. Per gripe from aazamrafeeque0. Thanks to Davi

pgsql: Doc: fix confusion about LEAKPROOF in syntax summaries.

2021-06-23 Thread Tom Lane
Doc: fix confusion about LEAKPROOF in syntax summaries. The syntax summaries for CREATE FUNCTION and allied commands made it look like LEAKPROOF is an alternative to IMMUTABLE/STABLE/VOLATILE, when of course it is an orthogonal option. Improve that. Per gripe from aazamrafeeque0. Thanks to Davi

pgsql: Doc: fix confusion about LEAKPROOF in syntax summaries.

2021-06-23 Thread Tom Lane
Doc: fix confusion about LEAKPROOF in syntax summaries. The syntax summaries for CREATE FUNCTION and allied commands made it look like LEAKPROOF is an alternative to IMMUTABLE/STABLE/VOLATILE, when of course it is an orthogonal option. Improve that. Per gripe from aazamrafeeque0. Thanks to Davi

pgsql: Doc: fix confusion about LEAKPROOF in syntax summaries.

2021-06-23 Thread Tom Lane
Doc: fix confusion about LEAKPROOF in syntax summaries. The syntax summaries for CREATE FUNCTION and allied commands made it look like LEAKPROOF is an alternative to IMMUTABLE/STABLE/VOLATILE, when of course it is an orthogonal option. Improve that. Per gripe from aazamrafeeque0. Thanks to Davi

pgsql: Allow non-quoted identifiers as isolation test session/step name

2021-06-23 Thread Tom Lane
Allow non-quoted identifiers as isolation test session/step names. For no obvious reason, isolationtester has always insisted that session and step names be written with double quotes. This is fairly tedious and does little for test readability, especially since the names that people actually cho

pgsql: Allow non-quoted identifiers as isolation test session/step name

2021-06-23 Thread Tom Lane
Allow non-quoted identifiers as isolation test session/step names. For no obvious reason, isolationtester has always insisted that session and step names be written with double quotes. This is fairly tedious and does little for test readability, especially since the names that people actually cho

pgsql: Allow non-quoted identifiers as isolation test session/step name

2021-06-23 Thread Tom Lane
Allow non-quoted identifiers as isolation test session/step names. For no obvious reason, isolationtester has always insisted that session and step names be written with double quotes. This is fairly tedious and does little for test readability, especially since the names that people actually cho

pgsql: Allow non-quoted identifiers as isolation test session/step name

2021-06-23 Thread Tom Lane
Allow non-quoted identifiers as isolation test session/step names. For no obvious reason, isolationtester has always insisted that session and step names be written with double quotes. This is fairly tedious and does little for test readability, especially since the names that people actually cho

pgsql: Allow non-quoted identifiers as isolation test session/step name

2021-06-23 Thread Tom Lane
Allow non-quoted identifiers as isolation test session/step names. For no obvious reason, isolationtester has always insisted that session and step names be written with double quotes. This is fairly tedious and does little for test readability, especially since the names that people actually cho

pgsql: Allow non-quoted identifiers as isolation test session/step name

2021-06-23 Thread Tom Lane
Allow non-quoted identifiers as isolation test session/step names. For no obvious reason, isolationtester has always insisted that session and step names be written with double quotes. This is fairly tedious and does little for test readability, especially since the names that people actually cho

pgsql: pgcrypto: avoid name conflicts with OpenSSL in one more case.

2021-06-23 Thread Tom Lane
pgcrypto: avoid name conflicts with OpenSSL in one more case. I happened to notice that if compiled --with-gssapi, 9.6's contrib/pgcrypto tests report memory stomps for some SHA operations. Both MEMORY_CONTEXT_CHECKING and valgrind agree there's a problem, though nothing crashes; it appears that

pgsql: Doc: Update caveats in synchronous logical replication.

2021-06-23 Thread Amit Kapila
Doc: Update caveats in synchronous logical replication. Reported-by: Simon Riggs Author: Takamichi Osumi Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- REL9_6_STABLE Details --

pgsql: Doc: Update caveats in synchronous logical replication.

2021-06-23 Thread Amit Kapila
Doc: Update caveats in synchronous logical replication. Reported-by: Simon Riggs Author: Takamichi Osumi Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- REL_11_STABLE Details --

pgsql: Doc: Update caveats in synchronous logical replication.

2021-06-23 Thread Amit Kapila
Doc: Update caveats in synchronous logical replication. Reported-by: Simon Riggs Author: Takamichi Osumi Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- REL_12_STABLE Details --

pgsql: Doc: Update caveats in synchronous logical replication.

2021-06-23 Thread Amit Kapila
Doc: Update caveats in synchronous logical replication. Reported-by: Simon Riggs Author: Takamichi Osumi Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- REL_13_STABLE Details --

pgsql: Doc: Update caveats in synchronous logical replication.

2021-06-23 Thread Amit Kapila
Doc: Update caveats in synchronous logical replication. Reported-by: Simon Riggs Author: Takamichi Osumi Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- REL_10_STABLE Details --

pgsql: Doc: Update caveats in synchronous logical replication.

2021-06-23 Thread Amit Kapila
Doc: Update caveats in synchronous logical replication. Reported-by: Simon Riggs Author: Takamichi Osumi Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: https://www.postgresql.org/message-id/[email protected] Branch -- master Details --- https

pgsql: Doc: Update logical replication message formats.

2021-06-23 Thread Amit Kapila
Doc: Update logical replication message formats. Commits 9de77b5453 and ac4645c015 missed to update the logical replication message formats section in the docs. Author: Brar Piening Reviewed-by: Amit Kapila Discussion: https://www.postgresql.org/message-id/cc70956c-e578-e54f-49e6-b5d68c895...@gm