pgsql: Get rid of artificial restriction on hash table sizes on Windows

2021-07-25 Thread Tom Lane
Get rid of artificial restriction on hash table sizes on Windows. The point of introducing the hash_mem_multiplier GUC was to let users reproduce the old behavior of hash aggregation, i.e. that it could use more than work_mem at need. However, the implementation failed to get the job done on Win6

pgsql: Get rid of artificial restriction on hash table sizes on Windows

2021-07-25 Thread Tom Lane
Get rid of artificial restriction on hash table sizes on Windows. The point of introducing the hash_mem_multiplier GUC was to let users reproduce the old behavior of hash aggregation, i.e. that it could use more than work_mem at need. However, the implementation failed to get the job done on Win6

pgsql: Get rid of artificial restriction on hash table sizes on Windows

2021-07-25 Thread Tom Lane
Get rid of artificial restriction on hash table sizes on Windows. The point of introducing the hash_mem_multiplier GUC was to let users reproduce the old behavior of hash aggregation, i.e. that it could use more than work_mem at need. However, the implementation failed to get the job done on Win6

pgsql: Fix a couple of memory leaks in src/bin/pg_basebackup/

2021-07-25 Thread Michael Paquier
Fix a couple of memory leaks in src/bin/pg_basebackup/ These have been introduced by 7fbe0c8, and could happen for pg_basebackup and pg_receivewal. Per report from Coverity for the ones in walmethods.c, I have spotted the ones in receivelog.c after more review. Backpatch-through: 10 Branch

pgsql: Fix a couple of memory leaks in src/bin/pg_basebackup/

2021-07-25 Thread Michael Paquier
Fix a couple of memory leaks in src/bin/pg_basebackup/ These have been introduced by 7fbe0c8, and could happen for pg_basebackup and pg_receivewal. Per report from Coverity for the ones in walmethods.c, I have spotted the ones in receivelog.c after more review. Backpatch-through: 10 Branch

pgsql: Fix a couple of memory leaks in src/bin/pg_basebackup/

2021-07-25 Thread Michael Paquier
Fix a couple of memory leaks in src/bin/pg_basebackup/ These have been introduced by 7fbe0c8, and could happen for pg_basebackup and pg_receivewal. Per report from Coverity for the ones in walmethods.c, I have spotted the ones in receivelog.c after more review. Backpatch-through: 10 Branch

pgsql: Fix a couple of memory leaks in src/bin/pg_basebackup/

2021-07-25 Thread Michael Paquier
Fix a couple of memory leaks in src/bin/pg_basebackup/ These have been introduced by 7fbe0c8, and could happen for pg_basebackup and pg_receivewal. Per report from Coverity for the ones in walmethods.c, I have spotted the ones in receivelog.c after more review. Backpatch-through: 10 Branch

pgsql: Fix a couple of memory leaks in src/bin/pg_basebackup/

2021-07-25 Thread Michael Paquier
Fix a couple of memory leaks in src/bin/pg_basebackup/ These have been introduced by 7fbe0c8, and could happen for pg_basebackup and pg_receivewal. Per report from Coverity for the ones in walmethods.c, I have spotted the ones in receivelog.c after more review. Backpatch-through: 10 Branch

pgsql: Fix a couple of memory leaks in src/bin/pg_basebackup/

2021-07-25 Thread Michael Paquier
Fix a couple of memory leaks in src/bin/pg_basebackup/ These have been introduced by 7fbe0c8, and could happen for pg_basebackup and pg_receivewal. Per report from Coverity for the ones in walmethods.c, I have spotted the ones in receivelog.c after more review. Backpatch-through: 10 Branch

pgsql: Fix incorrect comment for get_agg_clause_costs

2021-07-25 Thread David Rowley
Fix incorrect comment for get_agg_clause_costs Adjust the header comment in get_agg_clause_costs so that it matches what the function currently does. No recursive searching has been done ever since 0a2bc5d61. It also does not determine the aggtranstype like the comment claimed. That's all done i

pgsql: Fix incorrect comment for get_agg_clause_costs

2021-07-25 Thread David Rowley
Fix incorrect comment for get_agg_clause_costs Adjust the header comment in get_agg_clause_costs so that it matches what the function currently does. No recursive searching has been done ever since 0a2bc5d61. It also does not determine the aggtranstype like the comment claimed. That's all done i

pgsql: Harden pg_stat_statements tests against CLOBBER_CACHE_ALWAYS.

2021-07-25 Thread Tom Lane
Harden pg_stat_statements tests against CLOBBER_CACHE_ALWAYS. Turns out the buildfarm hasn't been testing this, which will soon change. Julien Rouhaud, per report from me Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.

pgsql: Harden pg_stat_statements tests against CLOBBER_CACHE_ALWAYS.

2021-07-25 Thread Tom Lane
Harden pg_stat_statements tests against CLOBBER_CACHE_ALWAYS. Turns out the buildfarm hasn't been testing this, which will soon change. Julien Rouhaud, per report from me Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.post

pgsql: Harden pg_stat_statements tests against CLOBBER_CACHE_ALWAYS.

2021-07-25 Thread Tom Lane
Harden pg_stat_statements tests against CLOBBER_CACHE_ALWAYS. Turns out the buildfarm hasn't been testing this, which will soon change. Julien Rouhaud, per report from me Discussion: https://postgr.es/m/[email protected] Branch -- REL_14_STABLE Details --- https://git.post