pgsql: Fix typo

2021-08-25 Thread Peter Eisentraut
Fix typo Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a599109e591426689d5f79041af45525b00ef7b2 Modified Files -- src/include/utils/typcache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo

2021-08-25 Thread Peter Eisentraut
Fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bb9ff46bc4e659a865deaeb1b9aeac8d1ff4d36f Modified Files -- src/include/utils/typcache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: psql: Make cancel test more timing robust

2021-08-25 Thread Peter Eisentraut
psql: Make cancel test more timing robust The previous coding relied on the PID file appearing and the query starting "fast enough", which can fail on slow machines. Also, there might have been an undocumented interference between alarm and IPC::Run. This new coding doesn't rely on any of these

Re: pgsql: psql: Add test for query canceling

2021-08-25 Thread Daniel Gustafsson
> On 25 Aug 2021, at 07:37, Fabien COELHO wrote: > > >> That looks pretty solid to me, and I can confirm that it passes >> on wrasse's host. The only nit I can find to pick is that this: >> >> +usleep(10_000) until -s "$tempdir/psql.pid" or ($count++ > 180 * 100 >> and die 'pid file did n

pgsql: Fix broken snapshot handling in parallel workers.

2021-08-25 Thread Robert Haas
Fix broken snapshot handling in parallel workers. Pengchengliu reported an assertion failure in a parallel woker while performing a parallel scan using an overflowed snapshot. The proximate cause is that TransactionXmin was set to an incorrect value. The underlying cause is incorrect snapshot han

pgsql: Fix broken snapshot handling in parallel workers.

2021-08-25 Thread Robert Haas
Fix broken snapshot handling in parallel workers. Pengchengliu reported an assertion failure in a parallel woker while performing a parallel scan using an overflowed snapshot. The proximate cause is that TransactionXmin was set to an incorrect value. The underlying cause is incorrect snapshot han

pgsql: Fix broken snapshot handling in parallel workers.

2021-08-25 Thread Robert Haas
Fix broken snapshot handling in parallel workers. Pengchengliu reported an assertion failure in a parallel woker while performing a parallel scan using an overflowed snapshot. The proximate cause is that TransactionXmin was set to an incorrect value. The underlying cause is incorrect snapshot han

pgsql: Fix broken snapshot handling in parallel workers.

2021-08-25 Thread Robert Haas
Fix broken snapshot handling in parallel workers. Pengchengliu reported an assertion failure in a parallel woker while performing a parallel scan using an overflowed snapshot. The proximate cause is that TransactionXmin was set to an incorrect value. The underlying cause is incorrect snapshot han

pgsql: Fix broken snapshot handling in parallel workers.

2021-08-25 Thread Robert Haas
Fix broken snapshot handling in parallel workers. Pengchengliu reported an assertion failure in a parallel woker while performing a parallel scan using an overflowed snapshot. The proximate cause is that TransactionXmin was set to an incorrect value. The underlying cause is incorrect snapshot han

pgsql: Fix broken snapshot handling in parallel workers.

2021-08-25 Thread Robert Haas
Fix broken snapshot handling in parallel workers. Pengchengliu reported an assertion failure in a parallel woker while performing a parallel scan using an overflowed snapshot. The proximate cause is that TransactionXmin was set to an incorrect value. The underlying cause is incorrect snapshot han

pgsql: Remove redundant test.

2021-08-25 Thread Tom Lane
Remove redundant test. The condition "context_start < context_end" is strictly weaker than "context_end - context_start >= 50", so we don't need both. Oversight in commit ffd3944ab, noted by tanghy.fnst. In passing, line-wrap a nearby test to make it more readable. Discussion: https://postgr.es

pgsql: Remove redundant test.

2021-08-25 Thread Tom Lane
Remove redundant test. The condition "context_start < context_end" is strictly weaker than "context_end - context_start >= 50", so we don't need both. Oversight in commit ffd3944ab, noted by tanghy.fnst. In passing, line-wrap a nearby test to make it more readable. Discussion: https://postgr.es

pgsql: Rename unicode_combining_table to unicode_width_table

2021-08-25 Thread John Naylor
Rename unicode_combining_table to unicode_width_table No functional changes. A future commit will use this table for other purposes besides combining characters. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb0d0d2c7300c9c5c22b35975c11265aa4becc84 Modified Files

pgsql: Change mbbisearch to return the character range

2021-08-25 Thread John Naylor
Change mbbisearch to return the character range Add a width field to mbinterval and have mbbisearch return a pointer to the found range rather than just bool for success. A future commit will add another width besides zero, and this will allow that to use the same search. Reviewed by Jacob Champi

Re: pgsql: psql: Add test for query canceling

2021-08-25 Thread Peter Eisentraut
On 25.08.21 07:37, Fabien COELHO wrote: I finally came around to have a look at the patch. For the issue raised above, I can see that the file could be created but not yet written, but as the patch waits for the file to be non zero, ISTM that the probability of a torn write of a single integer