pgsql: Fix thinko in PQisBusy().

2022-02-12 Thread Tom Lane
Fix thinko in PQisBusy(). In commit 1f39a1c06 I made PQisBusy consider conn->write_failed, but that is now looking like complete brain fade. In the first place, the logic is quite wrong: it ought to be like "and not" rather than "or". This meant that once we'd gotten into a write_failed state, PQ

pgsql: Fix thinko in PQisBusy().

2022-02-12 Thread Tom Lane
Fix thinko in PQisBusy(). In commit 1f39a1c06 I made PQisBusy consider conn->write_failed, but that is now looking like complete brain fade. In the first place, the logic is quite wrong: it ought to be like "and not" rather than "or". This meant that once we'd gotten into a write_failed state, PQ

pgsql: Fix thinko in PQisBusy().

2022-02-12 Thread Tom Lane
Fix thinko in PQisBusy(). In commit 1f39a1c06 I made PQisBusy consider conn->write_failed, but that is now looking like complete brain fade. In the first place, the logic is quite wrong: it ought to be like "and not" rather than "or". This meant that once we'd gotten into a write_failed state, PQ

pgsql: Fix thinko in PQisBusy().

2022-02-12 Thread Tom Lane
Fix thinko in PQisBusy(). In commit 1f39a1c06 I made PQisBusy consider conn->write_failed, but that is now looking like complete brain fade. In the first place, the logic is quite wrong: it ought to be like "and not" rather than "or". This meant that once we'd gotten into a write_failed state, PQ

pgsql: Move libpq's write_failed mechanism down to pqsecure_raw_write()

2022-02-12 Thread Tom Lane
Move libpq's write_failed mechanism down to pqsecure_raw_write(). Commit 1f39a1c06 implemented write-failure postponement in pqSendSome, which is above SSL/GSS processing. However, we've now seen failures indicating that (some versions of?) OpenSSL have a tendency to report write failures prematu

Re: pgsql: Add decoding of sequences to test_decoding

2022-02-12 Thread Andres Freund
Hi, On 2022-02-11 23:52:20 +, Tomas Vondra wrote: > Add decoding of sequences to test_decoding > > Commit 0da92dc530 improved the logical decoding infrastructure to handle > sequences, and did various changes to related parts (WAL logging etc.). > But it did not include any implementation of t

Re: pgsql: Add suport for server-side LZ4 base backup compression.

2022-02-12 Thread Andres Freund
Hi, On 2022-02-12 13:38:45 +0900, Michael Paquier wrote: > Perhaps you'd better check that 'decompress_program' can be executed > and skip things if the command is not around? Note that > 020_pg_receivewal.pl does an extra lz4 --version as a safety measure, > but 008_untar.pl does not. Actually

pgsql: Fix skip-empty-xacts with sequences in test_decoding

2022-02-12 Thread Tomas Vondra
Fix skip-empty-xacts with sequences in test_decoding Regression tests need to use skip-empty-xacts = false, because there might be accidental concurrent activity (like autovacuum), particularly on slow machines. The tests added by 80901b3291 failed to do that in a couple places, triggering occasio

Re: pgsql: Add decoding of sequences to test_decoding

2022-02-12 Thread Tomas Vondra
On 2/12/22 23:04, Andres Freund wrote: > Hi, > > On 2022-02-11 23:52:20 +, Tomas Vondra wrote: >> Add decoding of sequences to test_decoding >> >> Commit 0da92dc530 improved the logical decoding infrastructure to handle >> sequences, and did various changes to related parts (WAL logging etc.).

pgsql: ci: macos: align sysinfo_script to other tasks.

2022-02-12 Thread Andres Freund
ci: macos: align sysinfo_script to other tasks. Author: Justin Pryzby Discussion: https://postgr.es/m/20220203035827.gg23...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0a156058aa49f7d60628efdba1787524bc3f2940 Modified Files -- .cirru

pgsql: ci: s/CCACHE_SIZE/CCACHE_MAXSIZE/.

2022-02-12 Thread Andres Freund
ci: s/CCACHE_SIZE/CCACHE_MAXSIZE/. The wrong environment variable was used in one place. Author: Justin Pryzby Discussion: https://postgr.es/m/20220203035827.gg23...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/79b79dd57a9672903951aa0d879500818b32

pgsql: ci: Only use one artifact instruction for logs.

2022-02-12 Thread Andres Freund
ci: Only use one artifact instruction for logs. Having the different types of logs in artifacts instruction makes it quicker to navigate between them. Either that didn't use to be possible, or I just did it wrong. I saw that / how it works in a patch by Justin Pryzby. Also remove a few unnecessar

pgsql: ci: fix copy-paste mistake in 16eb8231d1b.

2022-02-12 Thread Andres Freund
ci: fix copy-paste mistake in 16eb8231d1b. Reported-By: Justin Pryzby Discussion: https://postgr.es/m/20220213024704.gn31...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f79c94f39df092dfe3371257140ec76bba40bfb6 Modified Files -- .cirru