pgsql: Fix uninitialized variable.

2022-02-20 Thread Heikki Linnakangas
Fix uninitialized variable. I'm very surprised the compiler didn't warn about it. But Coverity and Valgrind did. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/69639e2b5c12c6f1eafa9db1a6b7d16e6471ac61 Modified Files -- src/backend/access/transam/xlog.c

pgsql: Remove most msys special processing in TAP tests

2022-02-20 Thread Andrew Dunstan
Remove most msys special processing in TAP tests Following migration of Windows buildfarm members running TAP tests to use of ucrt64 perl for those tests, special processing for msys perl is no longer necessary and so is removed. Backpatch to release 10 Discussion: https://postgr.es/m/c65a8781-

pgsql: Remove PostgreSQL::Test::Utils::perl2host completely

2022-02-20 Thread Andrew Dunstan
Remove PostgreSQL::Test::Utils::perl2host completely Commit f1ac4a74de disabled this processing, and as nothing has broken (as expected) here we proceed to remove the routine and adjust all the call sites. Backpatch to release 10 Discussion: https://postgr.es/m/0ba775a2-8aa0-0d56-d780-69427cf6f

pgsql: Remove most msys special processing in TAP tests

2022-02-20 Thread Andrew Dunstan
Remove most msys special processing in TAP tests Following migration of Windows buildfarm members running TAP tests to use of ucrt64 perl for those tests, special processing for msys perl is no longer necessary and so is removed. Backpatch to release 10 Discussion: https://postgr.es/m/c65a8781-

pgsql: Remove most msys special processing in TAP tests

2022-02-20 Thread Andrew Dunstan
Remove most msys special processing in TAP tests Following migration of Windows buildfarm members running TAP tests to use of ucrt64 perl for those tests, special processing for msys perl is no longer necessary and so is removed. Backpatch to release 10 Discussion: https://postgr.es/m/c65a8781-

pgsql: Remove PostgreSQL::Test::Utils::perl2host completely

2022-02-20 Thread Andrew Dunstan
Remove PostgreSQL::Test::Utils::perl2host completely Commit f1ac4a74de disabled this processing, and as nothing has broken (as expected) here we proceed to remove the routine and adjust all the call sites. Backpatch to release 10 Discussion: https://postgr.es/m/0ba775a2-8aa0-0d56-d780-69427cf6f

pgsql: Remove most msys special processing in TAP tests

2022-02-20 Thread Andrew Dunstan
Remove most msys special processing in TAP tests Following migration of Windows buildfarm members running TAP tests to use of ucrt64 perl for those tests, special processing for msys perl is no longer necessary and so is removed. Backpatch to release 10 Discussion: https://postgr.es/m/c65a8781-

pgsql: Remove PostgreSQL::Test::Utils::perl2host completely

2022-02-20 Thread Andrew Dunstan
Remove PostgreSQL::Test::Utils::perl2host completely Commit f1ac4a74de disabled this processing, and as nothing has broken (as expected) here we proceed to remove the routine and adjust all the call sites. Backpatch to release 10 Discussion: https://postgr.es/m/0ba775a2-8aa0-0d56-d780-69427cf6f

pgsql: Remove most msys special processing in TAP tests

2022-02-20 Thread Andrew Dunstan
Remove most msys special processing in TAP tests Following migration of Windows buildfarm members running TAP tests to use of ucrt64 perl for those tests, special processing for msys perl is no longer necessary and so is removed. Backpatch to release 10 Discussion: https://postgr.es/m/c65a8781-

pgsql: Ensure the right perl is used for TAP tests on msys

2022-02-20 Thread Andrew Dunstan
Ensure the right perl is used for TAP tests on msys In particular, perl with $Config{osname} = msys should only be used if the build target is msys (which is currently buildable but not usable). For builds targeted at native Windows, perl from the ucrt64 toolchain is suitable. Discussion: https:

pgsql: Remove most msys special processing in TAP tests

2022-02-20 Thread Andrew Dunstan
Remove most msys special processing in TAP tests Following migration of Windows buildfarm members running TAP tests to use of ucrt64 perl for those tests, special processing for msys perl is no longer necessary and so is removed. Backpatch to release 10 Discussion: https://postgr.es/m/c65a8781-

pgsql: Remove PostgreSQL::Test::Utils::perl2host completely

2022-02-20 Thread Andrew Dunstan
Remove PostgreSQL::Test::Utils::perl2host completely Commit f1ac4a74de disabled this processing, and as nothing has broken (as expected) here we proceed to remove the routine and adjust all the call sites. Backpatch to release 10 Discussion: https://postgr.es/m/0ba775a2-8aa0-0d56-d780-69427cf6f

pgsql: Remove PostgreSQL::Test::Utils::perl2host completely

2022-02-20 Thread Andrew Dunstan
Remove PostgreSQL::Test::Utils::perl2host completely Commit f1ac4a74de disabled this processing, and as nothing has broken (as expected) here we proceed to remove the routine and adjust all the call sites. Backpatch to release 10 Discussion: https://postgr.es/m/0ba775a2-8aa0-0d56-d780-69427cf6f

pgsql: Remove PostgreSQL::Test::Utils::perl2host completely

2022-02-20 Thread Andrew Dunstan
Remove PostgreSQL::Test::Utils::perl2host completely Commit f1ac4a74de disabled this processing, and as nothing has broken (as expected) here we proceed to remove the routine and adjust all the call sites. Backpatch to release 10 Discussion: https://postgr.es/m/0ba775a2-8aa0-0d56-d780-69427cf6f

pgsql: Reset conn->errorReported when PQrequestCancel sets errorMessage

2022-02-20 Thread Tom Lane
Reset conn->errorReported when PQrequestCancel sets errorMessage. Oversight in commit 618c16707. This is mainly neatnik-ism, since if PQrequestCancel is used per its API contract, we should perform pqClearConnErrorState before reaching any place that would consult errorReported. But still, it se

pgsql: Fix meaning-changing typo introduced in fa0e03c15a9f.

2022-02-20 Thread Andres Freund
Fix meaning-changing typo introduced in fa0e03c15a9f. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fbabdf8f9a55894f7cd8f0fa86c9a4ef55576296 Modified Files -- src/backend/utils/init/postinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Mention environment variable ZSTD in the TAP tests for MSVC

2022-02-20 Thread Michael Paquier
doc: Mention environment variable ZSTD in the TAP tests for MSVC 6c417bb has added the build infrastructure to support ZSTD, but forgot to update this section of the docs to mention the variable ZSTD, as per the change done in vcregress.pl. While on it, reword this section of the docs to describe