pgsql: vacuumlazy.c: document vistest and OldestXmin.

2022-03-12 Thread Peter Geoghegan
vacuumlazy.c: document vistest and OldestXmin. Explain the relationship between vacuumlazy.c's vistest and OldestXmin cutoffs. These closely related cutoffs are different in subtle but important ways. Also document a closely related rule: we must establish rel_pages _after_ OldestXmin to ensure

pgsql: vacuumlazy.c: Standardize rel_pages terminology.

2022-03-12 Thread Peter Geoghegan
vacuumlazy.c: Standardize rel_pages terminology. VACUUM's rel_pages field indicates the size of the target heap rel just after the table_relation_vacuum() operation began. There are specific expectations around how rel_pages can be related to other nearby state. In particular, the range of rel_pa

pgsql: Set synchronous_commit=on in test_setup.sql.

2022-03-12 Thread Andres Freund
Set synchronous_commit=on in test_setup.sql. Starting in cc50080a82 create_index test fails when run with synchronous_commit=off. synchronous_commit=off delays when hint bits may be set. Some plans change depending on the number of all-visible pages, which in turn can be influenced by the delayed

pgsql: Force track_io_timing off in explain.sql to avoid failures when

2022-03-12 Thread Andres Freund
Force track_io_timing off in explain.sql to avoid failures when enabled. Discussion: https://postgr.es/m/20201029231037.rkxo57ugnuchy...@alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7e12256b478b89518ff410f29192af21de37d070 Modified Files -