Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Julien Rouhaud
On Fri, Mar 18, 2022 at 02:36:48PM +0800, Julien Rouhaud wrote: > On Fri, Mar 18, 2022 at 06:15:47PM +1300, Thomas Munro wrote: > > > > No idea what's happening here but one observation is that that animal > > is running an older distro that shipped with ICU 5.0. Commit b8f9a2a6 > > may hold a clu

pgsql: doc: Remove mention to in-place tablespaces for pg_tablespace_lo

2022-03-18 Thread Michael Paquier
doc: Remove mention to in-place tablespaces for pg_tablespace_location() This paragraph has been added in the documentation by f6f0db4, but after more discussion we found that this just makes things more confusing, adding some cross-references between a general feature and something only aimed at

Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Tom Lane
Julien Rouhaud writes: > That being said, we could save the result and explicitly close the collator. > That wouldn't make much difference in initdb (but may be a bit cleaner), but I > see that there's a similar coding in createdb(), which seems like it could > leak > some memory according to uco

pgsql: Remove workarounds for avoiding [U]INT64_FORMAT in translatable

2022-03-18 Thread Tom Lane
Remove workarounds for avoiding [U]INT64_FORMAT in translatable strings. Update pg_backup_tar.c along the same lines as 62aa2bb29 and other previous cleanup: we can now rely on %lld or %llu as long as we explicitly cast to long long or unsigned long long. Japin Li Discussion: https://postgr.es/

pgsql: Doc: remove bogus instruction to install contrib/hstore.

2022-03-18 Thread Tom Lane
Doc: remove bogus instruction to install contrib/hstore. This test suite does not use hstore. Looks like this text was copied-and-pasted from src/test/subscription/README. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9eaef6f8ea951320eae0c0083b07d901fe9bd3e5 Mod

pgsql: Specify database encoding in new ICU test.

2022-03-18 Thread Tom Lane
Specify database encoding in new ICU test. Otherwise, the database encoding varies depending on the user's environment, and so the test might fail depending on whether ICU likes the encoding. In particular, the test fails completely if the prevailing locale is C. Branch -- master Details --

Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Tom Lane
I found a different problem with src/test/icu/: it fails altogether if the prevailing locale is "C", because then the database encoding defaults to SQL_ASCII which our ICU code won't cope with. I'm not sure if that explains any of the buildfarm failures, but it broke my local build (yeah, I'm that

Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Peter Eisentraut
On 18.03.22 18:29, Tom Lane wrote: I found a different problem with src/test/icu/: it fails altogether if the prevailing locale is "C", because then the database encoding defaults to SQL_ASCII which our ICU code won't cope with. I'm not sure if that explains any of the buildfarm failures, but it

pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.

2022-03-18 Thread Tom Lane
Fix incorrect xmlschema output for types timetz and timestamptz. The output of table_to_xmlschema() and allied functions includes a regex describing valid values for these types ... but the regex was itself invalid, as it failed to escape a literal "+" sign. Report and fix by Renan Soares Lopes.

pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.

2022-03-18 Thread Tom Lane
Fix incorrect xmlschema output for types timetz and timestamptz. The output of table_to_xmlschema() and allied functions includes a regex describing valid values for these types ... but the regex was itself invalid, as it failed to escape a literal "+" sign. Report and fix by Renan Soares Lopes.

pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.

2022-03-18 Thread Tom Lane
Fix incorrect xmlschema output for types timetz and timestamptz. The output of table_to_xmlschema() and allied functions includes a regex describing valid values for these types ... but the regex was itself invalid, as it failed to escape a literal "+" sign. Report and fix by Renan Soares Lopes.

pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.

2022-03-18 Thread Tom Lane
Fix incorrect xmlschema output for types timetz and timestamptz. The output of table_to_xmlschema() and allied functions includes a regex describing valid values for these types ... but the regex was itself invalid, as it failed to escape a literal "+" sign. Report and fix by Renan Soares Lopes.

pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.

2022-03-18 Thread Tom Lane
Fix incorrect xmlschema output for types timetz and timestamptz. The output of table_to_xmlschema() and allied functions includes a regex describing valid values for these types ... but the regex was itself invalid, as it failed to escape a literal "+" sign. Report and fix by Renan Soares Lopes.

pgsql: Fix incorrect xmlschema output for types timetz and timestamptz.

2022-03-18 Thread Tom Lane
Fix incorrect xmlschema output for types timetz and timestamptz. The output of table_to_xmlschema() and allied functions includes a regex describing valid values for these types ... but the regex was itself invalid, as it failed to escape a literal "+" sign. Report and fix by Renan Soares Lopes.

pgsql: ci: compile with -Og where applicable.

2022-03-18 Thread Andres Freund
ci: compile with -Og where applicable. To improve performance of check-world, and improve debugging, without significantly slower builds (they're cached anyway). This makes freebsd check-world run in 8.5 minutes rather than 15 minutes. Author: Justin Pryzby Reviewed-By: Andres Freund Discussio

pgsql: ci: include hints how to install OS packages.

2022-03-18 Thread Andres Freund
ci: include hints how to install OS packages. This is useful for patches during development, but once a feature is merged, new libraries should be added to the OS image files, rather than installed during every CI run forever into the future. Author: Justin Pryzby Reviewed-By: Andres Freund Dis

pgsql: Close race condition in slot_creation_error.spec.

2022-03-18 Thread Noah Misch
Close race condition in slot_creation_error.spec. Use the pattern from detach-partition-concurrently-3.spec. Per buildfarm member wrasse. Reviewed by Kyotaro Horiguchi and Andres Freund. Discussion: https://postgr.es/m/20220318072837.gc2739...@rfd.leadboat.com Branch -- master Details ---

pgsql: Silence -Wmaybe-uninitialized compiler warning in dbcommands.c.

2022-03-18 Thread Andres Freund
Silence -Wmaybe-uninitialized compiler warning in dbcommands.c. Introduced in f2553d43060e. See also 3f6b3be39ca9, which did so for nearby variables. Discussion: https://postgr.es/m/20220319014707.kgtomqdzm6m2u...@alap3.anarazel.de Branch -- master Details --- https://git.postgresql.or

Re: pgsql: Split ExecUpdate and ExecDelete into reusable pieces

2022-03-18 Thread Amit Langote
Hi Alvaro, On Thu, Mar 17, 2022 at 7:47 PM Alvaro Herrera wrote: > > Split ExecUpdate and ExecDelete into reusable pieces > > Create subroutines ExecUpdatePrologue / ExecUpdateAct / > ExecUpdateEpilogue, and similar for ExecDelete. > > Introduce a new struct to be used internally in nodeModifyTab

Re: pgsql: Split ExecUpdate and ExecDelete into reusable pieces

2022-03-18 Thread Amit Langote
On Sat, Mar 19, 2022 at 12:59 PM Amit Langote wrote: > On Thu, Mar 17, 2022 at 7:47 PM Alvaro Herrera > wrote: > > > > Split ExecUpdate and ExecDelete into reusable pieces > > > > Create subroutines ExecUpdatePrologue / ExecUpdateAct / > > ExecUpdateEpilogue, and similar for ExecDelete. > > > >