pgsql: Fix global ICU collations for ICU < 54

2022-03-20 Thread Peter Eisentraut
Fix global ICU collations for ICU < 54 createdb() didn't check for collation attributes validity, which has to be done explicitly on ICU < 54. It also forgot to close the ICU collator opened during the check which leaks some memory. To fix both, add a new check_icu_locale() that does all the app

pgsql: Doc: fix our example systemd script.

2022-03-20 Thread Tom Lane
Doc: fix our example systemd script. The example used "TimeoutSec=0", but systemd's documented way to get the desired effect is "TimeoutSec=infinity". Discussion: https://postgr.es/m/164770078557.670.5467111518383664...@wrigleys.postgresql.org Branch -- REL_12_STABLE Details --- https:

pgsql: Doc: fix our example systemd script.

2022-03-20 Thread Tom Lane
Doc: fix our example systemd script. The example used "TimeoutSec=0", but systemd's documented way to get the desired effect is "TimeoutSec=infinity". Discussion: https://postgr.es/m/164770078557.670.5467111518383664...@wrigleys.postgresql.org Branch -- REL_14_STABLE Details --- https:

pgsql: Doc: fix our example systemd script.

2022-03-20 Thread Tom Lane
Doc: fix our example systemd script. The example used "TimeoutSec=0", but systemd's documented way to get the desired effect is "TimeoutSec=infinity". Discussion: https://postgr.es/m/164770078557.670.5467111518383664...@wrigleys.postgresql.org Branch -- master Details --- https://git.p

pgsql: Doc: fix our example systemd script.

2022-03-20 Thread Tom Lane
Doc: fix our example systemd script. The example used "TimeoutSec=0", but systemd's documented way to get the desired effect is "TimeoutSec=infinity". Discussion: https://postgr.es/m/164770078557.670.5467111518383664...@wrigleys.postgresql.org Branch -- REL_10_STABLE Details --- https:

pgsql: Doc: fix our example systemd script.

2022-03-20 Thread Tom Lane
Doc: fix our example systemd script. The example used "TimeoutSec=0", but systemd's documented way to get the desired effect is "TimeoutSec=infinity". Discussion: https://postgr.es/m/164770078557.670.5467111518383664...@wrigleys.postgresql.org Branch -- REL_13_STABLE Details --- https:

pgsql: Doc: fix our example systemd script.

2022-03-20 Thread Tom Lane
Doc: fix our example systemd script. The example used "TimeoutSec=0", but systemd's documented way to get the desired effect is "TimeoutSec=infinity". Discussion: https://postgr.es/m/164770078557.670.5467111518383664...@wrigleys.postgresql.org Branch -- REL_11_STABLE Details --- https:

pgsql: Enforce foreign key correctly during cross-partition updates

2022-03-20 Thread Alvaro Herrera
Enforce foreign key correctly during cross-partition updates When an update on a partitioned table referenced in foreign key constraints causes a row to move from one partition to another, the fact that the move is implemented as a delete followed by an insert on the target partition causes the fo

pgsql: psql: handle tab completion of timezone names after "SET TIMEZON

2022-03-20 Thread Tom Lane
psql: handle tab completion of timezone names after "SET TIMEZONE TO". Dagfinn Ilmari Mannsåker and Tom Lane Discussion: https://postgr.es/m/87k0curq0w@wibble.ilmari.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7fa3db367986160dee2b2b0bbfb61e1a51d486fd M

Re: pgsql: Enforce foreign key correctly during cross-partition updates

2022-03-20 Thread Tom Lane
Alvaro Herrera writes: > Enforce foreign key correctly during cross-partition updates skink is not too happy with this: ==2663594== VALGRINDERROR-BEGIN ==2663594== Conditional jump or move depends on uninitialised value(s) ==2663594==at 0x421526: ExecUpdateAct (nodeModifyTable.c:1855) ==2663

pgsql: Log regression.diffs in 027_stream_regress.pl.

2022-03-20 Thread Thomas Munro
Log regression.diffs in 027_stream_regress.pl. To help diagnose the reasons for a regression test failure inside this TAP test, dump the contents of regression.diffs to the log. While the CI scripts show it automatically, the build farm client does not. Reviewed-by: Andrew Dunstan Discussion:

pgsql: Blind fix for uninitialized memory bug in ba9a7e392171

2022-03-20 Thread Alvaro Herrera
Blind fix for uninitialized memory bug in ba9a7e392171 Valgrind animal skink shows a crash in this new code. I couldn't reproduce the problem locally, but going by blind code inspection, initializing insert_destrel should be sufficient to fix the problem. Branch -- master Details --- ht

Re: pgsql: Enforce foreign key correctly during cross-partition updates

2022-03-20 Thread Alvaro Herrera
On 2022-Mar-20, Tom Lane wrote: > ==2663594== Conditional jump or move depends on uninitialised value(s) > ==2663594==at 0x421526: ExecUpdateAct (nodeModifyTable.c:1855) > It reproduces easily for me under valgrind. I guess > ExecCrossPartitionUpdate must be failing to set > inserted_tuple o

pgsql: pgstat: introduce pgstat_relation_should_count().

2022-03-20 Thread Andres Freund
pgstat: introduce pgstat_relation_should_count(). A later commit will make the check more complicated than the current (rel)->pgstat_info != NULL. It also just seems nicer to have a central copy of the logic, even while still simple. Author: Andres Freund Discussion: https://postgr.es/m/2022030

pgsql: pgstat: separate "xact level" handling out of relation specific

2022-03-20 Thread Andres Freund
pgstat: separate "xact level" handling out of relation specific functions. This is in preparation of a later commit moving relation stats handling into its own file. Author: Andres Freund Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zco...@alap3.anarazel.de Branch -- master De

pgsql: pgstat: rename pgstat_initstats() to pgstat_relation_init().

2022-03-20 Thread Andres Freund
pgstat: rename pgstat_initstats() to pgstat_relation_init(). The old name was overly generic. An upcoming commit moves relation stats handling into its own file, making pgstat_initstats() look even more out of place. Author: Andres Freund Discussion: https://postgr.es/m/20220303021600.hs34ghqcw