pgsql: Fix the dates of some copyright notices

2022-04-11 Thread Michael Paquier
Fix the dates of some copyright notices 0ad8032 and 4e34747 are at the origin of that. Julien has found the one in parse_jsontable.c, while I have spotted the rest. Author: Julien Rouhaud, Michael Paquier Discussion: https://postgr.es/m/20220411060838.ftnzyvflpwu6f74w@jrouhaud Branch -- mas

pgsql: Docs: Fix various mistakes and typos

2022-04-11 Thread David Rowley
Docs: Fix various mistakes and typos Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bba3c35b29d07a27bbf5dd0d7d5e7c7592e02f81 Modified Files -- doc/src/sgml/confi

pgsql: Fix various typos and spelling mistakes in code comments

2022-04-11 Thread David Rowley
Fix various typos and spelling mistakes in code comments Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b0e5f02ddc836499bdcf093df52e4c342dda5891 Modified Files -

pgsql: Docs: Mention that relpersistence is for sequences now too

2022-04-11 Thread David Rowley
Docs: Mention that relpersistence is for sequences now too Per 344d62fb9. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e0064f0ff6dfada2695330c6bc1945fa7ae813be Modified F

pgsql: docs: Note the recovery_min_apply_delay bloats pg_wal.

2022-04-11 Thread Robert Haas
docs: Note the recovery_min_apply_delay bloats pg_wal. Those WAL files that we're waiting to apply have to be stored somewhere. Thom Brown Discussion: http://postgr.es/m/caa-alv4skjrk6ggcd0axt8kt6_ewmebtg7f8njpfh+rnsht...@mail.gmail.com Branch -- master Details --- https://git.postgre

pgsql: Avoid re-writing files unnecessarily in src/tools/copyright.pl.

2022-04-11 Thread Tom Lane
Avoid re-writing files unnecessarily in src/tools/copyright.pl. The existing coding resulted in touching every copyright-containing file in the tree, even if it was already up to date. That doesn't matter much for the annual run, but it's an annoyance if you try to use the script for mop-up at th

pgsql: Add color support for new frontend detail/hint messages

2022-04-11 Thread Peter Eisentraut
Add color support for new frontend detail/hint messages As before, the defaults are similar to gcc's default appearance. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c215cc7b61cbe06425c8ea3ac9d49581e6b5c6cd Modified Files -- doc/src/sgml/color.sgml |

pgsql: Improve readability of SQL/JSON documentation.

2022-04-11 Thread Andrew Dunstan
Improve readability of SQL/JSON documentation. Per review from Justin Pryzby. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b46bcf7a4b6f161eae1cee3ed9b6c4a28d04f4d0 Modified Files

pgsql: Doc build fix: remove tab from filelist.sgml.

2022-04-11 Thread Jeff Davis
Doc build fix: remove tab from filelist.sgml. Author: Amit Kapila Discussion: https://postgr.es/m/CAA4eK1K6z=gu-jppU1dtsyr2BC-pzrq3TYe=rfy+w386dfd...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8638c76cc9f47b86bd6500559fbf023a8886d9d6 Modified F

pgsql: fgetc() returns int, not char.

2022-04-11 Thread Tom Lane
fgetc() returns int, not char. This has no practical effect, since this code doesn't actually need to distinguish EOF (-1) from \0377; but it silences a Coverity complaint. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/93fcf2d2095674834e1ddbc6803ec043e3216afa Mod

pgsql: Explicitly ignore guaranteed-true result from pgstat_lock_entry(

2022-04-11 Thread Tom Lane
Explicitly ignore guaranteed-true result from pgstat_lock_entry(). With nowait passed as false, pgstat_lock_entry() must return true so there's no need to check its result. Coverity seems unconvinced of this, so whack it upside the head with a (void) cast. Branch -- master Details --- h

pgsql: Tweak the default behavior of psql's \dconfig.

2022-04-11 Thread Tom Lane
Tweak the default behavior of psql's \dconfig. \dconfig without an argument originally printed all parameters, but it seems more useful to print only those parameters with non-default settings. You can easily get the show-everything behavior with "\dconfig *", but that output is unwieldy and seem

pgsql: Remove dead code in do_pg_backup_start().

2022-04-11 Thread Tom Lane
Remove dead code in do_pg_backup_start(). As of commit 39969e2a1, no caller of do_pg_backup_start() passes NULL for labelfile or tblspcmapfile, nor is it plausible that any would do so in the future. Remove the code that coped with that case, as (a) it's dead and (b) it causes Coverity to bleat a

pgsql: Remove comment about historic heap vacuuming issue.

2022-04-11 Thread Peter Geoghegan
Remove comment about historic heap vacuuming issue. Remove comment block about how heap page vacuuming used to set tuples with storage to LP_UNUSED in a rare edge case that can no longer happen following commit 8523492d4e. The comments seem unnecessary now, since it's now generally clear that hea

pgsql: Make XLogRecGetBlockTag() throw error if there's no such block.

2022-04-11 Thread Tom Lane
Make XLogRecGetBlockTag() throw error if there's no such block. All but a few existing callers assume without checking that this function succeeds. While it probably will, that's a poor excuse for not checking. Let's make it return void and instead throw an error if it doesn't find the block ref

pgsql: Rename backup_compression.{c,h} to compression.{c,h}

2022-04-11 Thread Michael Paquier
Rename backup_compression.{c,h} to compression.{c,h} Compression option handling (level, algorithm or even workers) can be used across several parts of the system and not only base backups. Structures, objects and routines are renamed in consequence, to remove the concept of base backups from this