pgsql: Fix markup in synopsis

2022-05-18 Thread Peter Eisentraut
Fix markup in synopsis There is no need for a inside a , since the latter is already all "literal" implicitly. Also, create_help.pl misparses it. So just remove it. Reported-by: Kyotaro Horiguchi Discussion: https://www.postgresql.org/message-id/flat/20220517.174342.1884842412165214815.horik

pgsql: Make EXPLAIN MERGE output format more compact

2022-05-18 Thread Alvaro Herrera
Make EXPLAIN MERGE output format more compact We can use a single line to print all tuple counts that MERGE processed, for conciseness, and elide those that are zeroes. Non-text formats report all numbers, as is typical. Per comment from Justin Pryzby Discussion: https://postgr.es/m/2022051116

pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Alvaro Herrera
Check column list length in XMLTABLE/JSON_TABLE alias We weren't checking the length of the column list in the alias clause of an XMLTABLE or JSON_TABLE function (a "tablefunc" RTE), and it was possible to make the server crash by passing an overly long one. Fix it by throwing an error in that ca

pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Alvaro Herrera
Check column list length in XMLTABLE/JSON_TABLE alias We weren't checking the length of the column list in the alias clause of an XMLTABLE or JSON_TABLE function (a "tablefunc" RTE), and it was possible to make the server crash by passing an overly long one. Fix it by throwing an error in that ca

pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Alvaro Herrera
Check column list length in XMLTABLE/JSON_TABLE alias We weren't checking the length of the column list in the alias clause of an XMLTABLE or JSON_TABLE function (a "tablefunc" RTE), and it was possible to make the server crash by passing an overly long one. Fix it by throwing an error in that ca

pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Alvaro Herrera
Check column list length in XMLTABLE/JSON_TABLE alias We weren't checking the length of the column list in the alias clause of an XMLTABLE or JSON_TABLE function (a "tablefunc" RTE), and it was possible to make the server crash by passing an overly long one. Fix it by throwing an error in that ca

pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Alvaro Herrera
Check column list length in XMLTABLE/JSON_TABLE alias We weren't checking the length of the column list in the alias clause of an XMLTABLE or JSON_TABLE function (a "tablefunc" RTE), and it was possible to make the server crash by passing an overly long one. Fix it by throwing an error in that ca

pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Alvaro Herrera
Check column list length in XMLTABLE/JSON_TABLE alias We weren't checking the length of the column list in the alias clause of an XMLTABLE or JSON_TABLE function (a "tablefunc" RTE), and it was possible to make the server crash by passing an overly long one. Fix it by throwing an error in that ca

pgsql: Fix EXPLAIN MERGE output when no tuples are processed

2022-05-18 Thread Alvaro Herrera
Fix EXPLAIN MERGE output when no tuples are processed An 'else' clause was misplaced in commit 598ac10be1c2, making zero-rows output look a bit silly. Add a test case for it. Pointed out by Tom Lane. Discussion: https://postgr.es/m/21030.1652893...@sss.pgh.pa.us Branch -- master Details -

Re: pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Tom Lane
Alvaro Herrera writes: > Check column list length in XMLTABLE/JSON_TABLE alias Per buildfarm, you forgot to update xml_1.out and xml_2.out. regards, tom lane

Re: pgsql: Check column list length in XMLTABLE/JSON_TABLE alias

2022-05-18 Thread Alvaro Herrera
On 2022-May-18, Tom Lane wrote: > Alvaro Herrera writes: > > Check column list length in XMLTABLE/JSON_TABLE alias > > Per buildfarm, you forgot to update xml_1.out and xml_2.out. Sigh. Will fix. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ "In Europe they

pgsql: Update xml_1.out and xml_2.out

2022-05-18 Thread Alvaro Herrera
Update xml_1.out and xml_2.out Commit 0fbf01120023 should have updated them but didn't. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/62221ef187b0098c8f331f804b7c63859e5ee6ff Modified Files -- src/test/regress/expected/xml_1.out | 3 +++ src/test/regre

pgsql: Update xml_1.out and xml_2.out

2022-05-18 Thread Alvaro Herrera
Update xml_1.out and xml_2.out Commit 0fbf01120023 should have updated them but didn't. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/29d11151875fb7b4c76ac7b03444dcd7b4a8597f Modified Files -- src/test/regress/expected/xml_1.out | 3 +++ src/tes

pgsql: Update xml_1.out and xml_2.out

2022-05-18 Thread Alvaro Herrera
Update xml_1.out and xml_2.out Commit 0fbf01120023 should have updated them but didn't. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/50bf3157a1a5cd7196ba5b5feaca4b71e035afb4 Modified Files -- src/test/regress/expected/xml_1.out | 3 +++ src/tes

pgsql: Update xml_1.out and xml_2.out

2022-05-18 Thread Alvaro Herrera
Update xml_1.out and xml_2.out Commit 0fbf01120023 should have updated them but didn't. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0ebd20e20ff48a5df16ebfa49947c4044b948fa8 Modified Files -- src/test/regress/expected/xml_1.out | 3 +++ src/tes

pgsql: Update xml_1.out and xml_2.out

2022-05-18 Thread Alvaro Herrera
Update xml_1.out and xml_2.out Commit 0fbf01120023 should have updated them but didn't. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e8b93c6e2810306887dc8477aab88ae08cf335f9 Modified Files -- src/test/regress/expected/xml_1.out | 3 +++ src/tes

pgsql: Update xml_1.out and xml_2.out

2022-05-18 Thread Alvaro Herrera
Update xml_1.out and xml_2.out Commit 0fbf01120023 should have updated them but didn't. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5139db55636bc39c06232ada1b195f7d5d6950e0 Modified Files -- src/test/regress/expected/xml_1.out | 3 +++ src/tes

pgsql: Extend pg_publication_tables to display column list and row filt

2022-05-18 Thread Amit Kapila
Extend pg_publication_tables to display column list and row filter. Commit 923def9a53 and 52e4f0cd47 allowed to specify column lists and row filters for publication tables. This commit extends the pg_publication_tables view and pg_get_publication_tables function to display that information. This

Re: pgsql: Extend pg_publication_tables to display column list and row filt

2022-05-18 Thread Tom Lane
Amit Kapila writes: > Extend pg_publication_tables to display column list and row filter. Is this really something to be doing post-beta1? > This information will be useful to users and we also need this for the > later commit that prohibits combining multiple publications with different > colum

Re: pgsql: Extend pg_publication_tables to display column list and row filt

2022-05-18 Thread Amit Kapila
On Thu, May 19, 2022 at 8:40 AM Tom Lane wrote: > > Amit Kapila writes: > > Extend pg_publication_tables to display column list and row filter. > > Is this really something to be doing post-beta1? > I am sorry if we don't allow to make catalog changes post-beta1. If we can't do that then I can r

pgsql: Fix incorrect comments for Memoize struct

2022-05-18 Thread David Rowley
Fix incorrect comments for Memoize struct Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/0635f5aa-4973-8dc2-4e4e-df9fd5778...@enterprisedb.com Backpatch-through: 14, where Memoize was added Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c4a4e760f6b0

pgsql: Fix incorrect comments for Memoize struct

2022-05-18 Thread David Rowley
Fix incorrect comments for Memoize struct Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/0635f5aa-4973-8dc2-4e4e-df9fd5778...@enterprisedb.com Backpatch-through: 14, where Memoize was added Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3f712