pgsql: Renumber confusing value for GUC_UNIT_BYTE

2022-09-07 Thread Peter Eisentraut
Renumber confusing value for GUC_UNIT_BYTE It had a power-of-two value, which looks right, and causes the other values which aren't powers-of-two to look wrong. But this is tested for equality and not a bitwise test. See also: 6e7baa322773ff8c79d4d8883c99fdeff5bfa679 https://www.postgresql.org/m

Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE

2022-09-07 Thread Justin Pryzby
On Wed, Sep 07, 2022 at 11:11:37AM +0200, Peter Eisentraut wrote: > On 06.09.22 08:27, Michael Paquier wrote: > > On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote: > > > Peter Eisentraut writes: > > > > I think renumbering this makes sense. We could just leave the comment > > > > as is if

pgsql: Tag refs/tags/REL_15_BETA4 was created

2022-09-07 Thread noreply
Tag refs/tags/REL_15_BETA4 was created.

pgsql: Make MemoryContextContains work correctly again

2022-09-07 Thread David Rowley
Make MemoryContextContains work correctly again c6e0fe1f2 recently changed the way we store headers for allocated chunks of memory. Prior to that commit, we stored a pointer to the owning MemoryContext directly prior to the pointer to the allocated memory. That's no longer true and c6e0fe1f2 negl

pgsql: Message style fixes

2022-09-07 Thread Alvaro Herrera
Message style fixes Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/144cefac92644f338c35b77f6d9b4a9456c80563 Modified Files -- src/backend/replication/logical/worker.c | 6 +++--- src/backend/utils/init/postinit.c| 7 --- src/backend/uti

pgsql: Message style fixes

2022-09-07 Thread Alvaro Herrera
Message style fixes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b4663fb4a704b7a145ed6ec018b1f0c116eeb6b Modified Files -- src/backend/replication/logical/worker.c | 6 +++--- src/backend/utils/init/postinit.c| 7 --- src/backend/utils/misc

pgsql: Raise a warning if there is a possibility of data from multiple

2022-09-07 Thread Amit Kapila
Raise a warning if there is a possibility of data from multiple origins. This commit raises a warning message for a combination of options ('copy_data = true' and 'origin = none') during CREATE/ALTER subscription operations if the publication tables were also replicated from other publishers. Dur

pgsql: Fix the test case introduced by commit 8756930190.

2022-09-07 Thread Amit Kapila
Fix the test case introduced by commit 8756930190. Before dropping a relation, ensure that it has reached a 'ready' state after initial synchronization. Author: Vignesh C Reviewed-By: Amit Kapila Discussion: https://www.postgresql.org/message-id/CALDaNm0gwjY_4HFxvvty01BOT01q_fJLKQ3pWP9=9orqubh..

Re: pgsql: Raise a warning if there is a possibility of data from multiple

2022-09-07 Thread Masahiko Sawada
On Thu, Sep 8, 2022 at 10:39 AM Amit Kapila wrote: > > Raise a warning if there is a possibility of data from multiple origins. > > This commit raises a warning message for a combination of options > ('copy_data = true' and 'origin = none') during CREATE/ALTER subscription > operations if the publ

pgsql: Parse catalog .dat files as a whole when compiling the backend

2022-09-07 Thread John Naylor
Parse catalog .dat files as a whole when compiling the backend Previously Catalog.pm eval'd each individual hash reference so that comments and whitespace can be preserved when running reformat-dat-files. This is unnecessary when building, and we can save ~15% off the run time of genbki.pl by simp