Re: pgsql: Fix unlink() for STATUS_DELETE_PENDING on Windows.

2022-10-26 Thread Andres Freund
Hi, On 2022-10-25 18:57:54 -0500, Justin Pryzby wrote: > It'd be swell if we could use a separate device in CI, to be used for > running tests. Bonus points if it supports COW. My colleague Bilal just got the generation of windows VMs and running the test with cirrus working, not done by any mea

pgsql: Add some tests to check the SQL functions of control file

2022-10-26 Thread Michael Paquier
Add some tests to check the SQL functions of control file As the recent commit 05d4cbf (reverted after as a448e49) has proved, there is zero coverage for the four SQL functions that can scan the control file data: - pg_control_checkpoint() - pg_control_init() - pg_control_recovery() - pg_control_s

pgsql: Move pg_pwritev_with_retry() to src/common/file_utils.c

2022-10-26 Thread Michael Paquier
Move pg_pwritev_with_retry() to src/common/file_utils.c This commit moves pg_pwritev_with_retry(), a convenience wrapper of pg_writev() able to handle partial writes, to common/file_utils.c so that the frontend code is able to use it. A first use-case targetted for this routine is pg_basebackup a