pgsql: Fix comments atop ReorderBufferAddInvalidations.

2022-11-10 Thread Amit Kapila
Fix comments atop ReorderBufferAddInvalidations. The comments atop seem to indicate that we always accumulate invalidation messages in a top-level transaction which is neither required nor matches with the code. Author: Amit Kapila Reviewd by: Masahiko Sawada Backpatch-through: 14, where it was i

pgsql: Fix comments atop ReorderBufferAddInvalidations.

2022-11-10 Thread Amit Kapila
Fix comments atop ReorderBufferAddInvalidations. The comments atop seem to indicate that we always accumulate invalidation messages in a top-level transaction which is neither required nor matches with the code. Author: Amit Kapila Reviewd by: Masahiko Sawada Backpatch-through: 14, where it was i

pgsql: Fix comments atop ReorderBufferAddInvalidations.

2022-11-10 Thread Amit Kapila
Fix comments atop ReorderBufferAddInvalidations. The comments atop seem to indicate that we always accumulate invalidation messages in a top-level transaction which is neither required nor matches with the code. Author: Amit Kapila Reviewd by: Masahiko Sawada Backpatch-through: 14, where it was i

pgsql: Re-allow building on Microsoft Visual Studio 2013.

2022-11-10 Thread Tom Lane
Re-allow building on Microsoft Visual Studio 2013. In commit 450ee7012 I supposed that all platforms we now care about have snprintf(), since that's required by C99. Turns out that Microsoft did not get around to adding that until VS2015. We've dropped support for VS2013 as of HEAD (cf 6203583b7

pgsql: Re-allow building on Microsoft Visual Studio 2013.

2022-11-10 Thread Tom Lane
Re-allow building on Microsoft Visual Studio 2013. In commit 450ee7012 I supposed that all platforms we now care about have snprintf(), since that's required by C99. Turns out that Microsoft did not get around to adding that until VS2015. We've dropped support for VS2013 as of HEAD (cf 6203583b7

pgsql: Re-allow building on Microsoft Visual Studio 2013.

2022-11-10 Thread Tom Lane
Re-allow building on Microsoft Visual Studio 2013. In commit 450ee7012 I supposed that all platforms we now care about have snprintf(), since that's required by C99. Turns out that Microsoft did not get around to adding that until VS2015. We've dropped support for VS2013 as of HEAD (cf 6203583b7

pgsql: Re-allow building on Microsoft Visual Studio 2013.

2022-11-10 Thread Tom Lane
Re-allow building on Microsoft Visual Studio 2013. In commit 450ee7012 I supposed that all platforms we now care about have snprintf(), since that's required by C99. Turns out that Microsoft did not get around to adding that until VS2015. We've dropped support for VS2013 as of HEAD (cf 6203583b7

pgsql: Fix alter_table.sql test case to test what it claims to.

2022-11-10 Thread Tom Lane
Fix alter_table.sql test case to test what it claims to. The stanza "SET STORAGE may need to add a TOAST table" does not test what it's supposed to, and hasn't done so since we added the ability to store constant column default values as metadata. We need to use a non-constant default to get the e

pgsql: Fix alter_table.sql test case to test what it claims to.

2022-11-10 Thread Tom Lane
Fix alter_table.sql test case to test what it claims to. The stanza "SET STORAGE may need to add a TOAST table" does not test what it's supposed to, and hasn't done so since we added the ability to store constant column default values as metadata. We need to use a non-constant default to get the e

pgsql: Fix alter_table.sql test case to test what it claims to.

2022-11-10 Thread Tom Lane
Fix alter_table.sql test case to test what it claims to. The stanza "SET STORAGE may need to add a TOAST table" does not test what it's supposed to, and hasn't done so since we added the ability to store constant column default values as metadata. We need to use a non-constant default to get the e

pgsql: Fix alter_table.sql test case to test what it claims to.

2022-11-10 Thread Tom Lane
Fix alter_table.sql test case to test what it claims to. The stanza "SET STORAGE may need to add a TOAST table" does not test what it's supposed to, and hasn't done so since we added the ability to store constant column default values as metadata. We need to use a non-constant default to get the e

pgsql: Fix alter_table.sql test case to test what it claims to.

2022-11-10 Thread Tom Lane
Fix alter_table.sql test case to test what it claims to. The stanza "SET STORAGE may need to add a TOAST table" does not test what it's supposed to, and hasn't done so since we added the ability to store constant column default values as metadata. We need to use a non-constant default to get the e

pgsql: Fix alter_table.sql test case to test what it claims to.

2022-11-10 Thread Tom Lane
Fix alter_table.sql test case to test what it claims to. The stanza "SET STORAGE may need to add a TOAST table" does not test what it's supposed to, and hasn't done so since we added the ability to store constant column default values as metadata. We need to use a non-constant default to get the e

pgsql: Support writing "CREATE/ALTER TABLE ... SET STORAGE DEFAULT".

2022-11-10 Thread Tom Lane
Support writing "CREATE/ALTER TABLE ... SET STORAGE DEFAULT". We already allow explicitly writing DEFAULT for SET COMPRESSION, so it seems a bit inflexible and non-orthogonal to not have it for STORAGE. Aleksander Alekseev Discussion: https://postgr.es/m/caj7c6tmx9ui+6y3tqfaxjyvpzybukvqhqbvdj8o