pgsql: meson: Define HAVE_LOCALE_T for msvc

2022-11-11 Thread Peter Eisentraut
meson: Define HAVE_LOCALE_T for msvc Meson doesn't see the redefinition of locale_t done in src/include/port/win32_port.h, so it is not defining HAVE_LOCALE_T, HAVE_WCSTOMBS_L nor HAVE_MBSTOWCS_L as the current src/tools/msvc/build.pl script does. Add manual overrides to fix. Author: Author: Jua

pgsql: Remove obsolete comments and code from prior to f8f4227976.

2022-11-11 Thread Jeff Davis
Remove obsolete comments and code from prior to f8f4227976. XLogReadBufferForRedo() and XLogReadBufferForRedoExtended() only return BLK_NEEDS_REDO if the record LSN is greater than the page LSN, so the redo routine doesn't need to do the LSN check again. Discussion: https://postgr.es/m/0c37b80e6

pgsql: Fix theoretical torn page hazard.

2022-11-11 Thread Jeff Davis
Fix theoretical torn page hazard. The original report was concerned with a possible inconsistency between the heap and the visibility map, which I was unable to confirm. The concern has been retracted. However, there did seem to be a torn page hazard when using checksums. By not setting the heap

pgsql: Fix theoretical torn page hazard.

2022-11-11 Thread Jeff Davis
Fix theoretical torn page hazard. The original report was concerned with a possible inconsistency between the heap and the visibility map, which I was unable to confirm. The concern has been retracted. However, there did seem to be a torn page hazard when using checksums. By not setting the heap

pgsql: Fix theoretical torn page hazard.

2022-11-11 Thread Jeff Davis
Fix theoretical torn page hazard. The original report was concerned with a possible inconsistency between the heap and the visibility map, which I was unable to confirm. The concern has been retracted. However, there did seem to be a torn page hazard when using checksums. By not setting the heap

pgsql: Fix theoretical torn page hazard.

2022-11-11 Thread Jeff Davis
Fix theoretical torn page hazard. The original report was concerned with a possible inconsistency between the heap and the visibility map, which I was unable to confirm. The concern has been retracted. However, there did seem to be a torn page hazard when using checksums. By not setting the heap

pgsql: Fix theoretical torn page hazard.

2022-11-11 Thread Jeff Davis
Fix theoretical torn page hazard. The original report was concerned with a possible inconsistency between the heap and the visibility map, which I was unable to confirm. The concern has been retracted. However, there did seem to be a torn page hazard when using checksums. By not setting the heap

pgsql: Fix theoretical torn page hazard.

2022-11-11 Thread Jeff Davis
Fix theoretical torn page hazard. The original report was concerned with a possible inconsistency between the heap and the visibility map, which I was unable to confirm. The concern has been retracted. However, there did seem to be a torn page hazard when using checksums. By not setting the heap